From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2B216740034 for ; Wed, 15 Jan 2025 18:53:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XwVZOU+vsUboF+wtUS9aNDeSsDLPhrlIDwOMnVZnfQk=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240830; t=1736967185; v=1; x=1737226384; b=AaWWlcNDtbwe63ntrFScegErrenL5qYQFwWRrkWQ1wDziKwKZMm12acZwN9xKpZ7wS4ygs1Z tv1Z0F91NFPtX1nRMCyvfsk36o0X69MGS+O93ax+EFc03idl1UIqqZBLxT07moYy92kiGiTC5R4 UA4ptUw3oaDHViCsWH0kOipHNoEEPnXEhXKbTetulaSHD5KGPVN6OJ8AFWNw3HCLUTvtZyOHcL5 MLSCEaotphH4ShJLKOfrps8FjOeRN74SVDiylzPKfTqY28t4ufwDCtJz9zcOqFLF2BgDBHdlS9r xNQ0wvIoswQSC+8Kx1RM4giWPSeXQ+mSLk+Qe7vEllgtA== X-Received: by 127.0.0.2 with SMTP id RuNgYY7687511xo2zVcujU9W; Wed, 15 Jan 2025 10:53:04 -0800 X-Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by mx.groups.io with SMTP id smtpd.web11.15879.1736507564300828326 for ; Fri, 10 Jan 2025 03:12:44 -0800 X-Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-aa67ac42819so281835566b.0 for ; Fri, 10 Jan 2025 03:12:44 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVUOAevzLsoOxgXxjlI6+pAV+69cx1p1gzfRYG/yzVKAj6Cxv2sftvlmDNSRfFCVW0gvbmMHA==@edk2.groups.io X-Gm-Message-State: SEl0nFijpfjc5bm0jmb4qTrWx7686176AA= X-Gm-Gg: ASbGncvyoaKyefcprc1uaaJGTqYBJ6H3BIkBHDYATuEMHah+h9e2LO8KTp3rafBfdnO fCSZXdSRii9QoWJuf4XCx/yZOnE4s1aTxqWt1git5ep8rnnO6f6o2ULfQV6yUrJoASmF4jKvfCk KOGc+jkfiOcyC/bdenJ4h58PQi3pSZxy4jTLF9TZ6I7SpP8SUSmVVjD+UsxAKTXGtefreyXJfNE awZZYlZEnelP/F86Pw98cMopcZTUJ0iC7zh7VJcMIjiovZ+AWvzCuE6Uusq6qxAQskTtASEwbP1 1uI9MFF8HXThkfsgcdZZYRLBMilC X-Google-Smtp-Source: AGHT+IEr3DYjbmxJfOi4g+OJHmU/3Mg1uURC8lJFwHS/uzBUjhDVzsWaDhSM2tE7YGlD4il6vC880g== X-Received: by 2002:a17:906:dc8d:b0:aaf:4008:5e2c with SMTP id a640c23a62f3a-ab2ab66fea4mr827120266b.2.1736507562473; Fri, 10 Jan 2025 03:12:42 -0800 (PST) X-Received: from ?IPV6:2a03:83e0:1126:4:829:739b:3caa:6500? ([2620:10d:c092:500::5:e213]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c905f0b3sm157026166b.21.2025.01.10.03.12.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 03:12:42 -0800 (PST) Message-ID: <4ed67e5b-c2ea-4dc3-b4c5-f8f112b0cd40@gmail.com> Date: Fri, 10 Jan 2025 11:12:41 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [RFC 2/2] efi/memattr: add efi_mem_attr_table as a reserved region in 820_table_firmware To: Dave Young Cc: linux-efi@vger.kernel.org, devel@edk2.groups.io, kexec@lists.infradead.org, ardb@kernel.org, hannes@cmpxchg.org, x86@kernel.org, linux-kernel@vger.kernel.org, leitao@debian.org, gourry@gourry.net, kernel-team@meta.com References: <20250108215957.3437660-1-usamaarif642@gmail.com> <20250108215957.3437660-3-usamaarif642@gmail.com> From: "Usama Arif via groups.io" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 15 Jan 2025 10:52:52 -0800 Resent-From: usamaarif642@gmail.com Reply-To: devel@edk2.groups.io,usamaarif642@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=AaWWlcND; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/01/2025 02:50, Dave Young wrote: > Hi Usama, >=20 > On Thu, 9 Jan 2025 at 06:00, Usama Arif wrote: >> >> When this area is not reserved, it comes up as usable in >> /sys/firmware/memmap. This means that kexec, which uses that memmap >> to find usable memory regions, can select the region where >> efi_mem_attr_table is and overwrite it and relocate_kernel. >=20 > Is the attr table BOOT SERVICE DATA? If so, does efi_mem_reserve() > work for you? > Just refer to esrt.c. >=20 Hi Dave, Its a bit difficult to reproduce the problem and therefore test the fix, bu= t we are seeing it a lot in production. Ard proposed the same thing in=20 https://lore.kernel.org/all/6b4780a5-ada0-405e-9f0a-4d2186177f29@gmail.com/ but as I mentioned there, I dont think that efi_mem_reserve would help, as efi_mem_reserve changes e820_table, while kexec looks at /sys/firmware/memmap which uses e820_table_firmware. Thanks, Usama > Thanks > Dave >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121008): https://edk2.groups.io/g/devel/message/121008 Mute This Topic: https://groups.io/mt/110518541/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-