From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by mx.groups.io with SMTP id smtpd.web10.10338.1603372369784751088
 for <devel@edk2.groups.io>;
 Thu, 22 Oct 2020 06:12:51 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gWJiWhs1;
 spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1603372368;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=8xdGptxL4hrFjhTvn7RGl50jzFLVwBjIyo/MxFvBZUs=;
	b=gWJiWhs1s4ZRnMWyBTx1n/s/9wcxmI5Zwf7fqvaxWQw6IeuNR13RBeaIqI+Xepuc7a5NF4
	xig3wc/dM6cgNlmyqk0c2IuzoeCELI5hCT6CJobvcTHhuLbvNuxm0AM+XGNsg42ogjjf/t
	dGRkNx5SsKInO17rRpUBuvr0SkJ1UX8=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-2-hwEnzN7wMk6lBh3tJWLELw-1; Thu, 22 Oct 2020 09:12:46 -0400
X-MC-Unique: hwEnzN7wMk6lBh3tJWLELw-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 77B581882FA1;
	Thu, 22 Oct 2020 13:12:44 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-174.ams2.redhat.com [10.36.113.174])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 6A53A6EF42;
	Thu, 22 Oct 2020 13:12:42 +0000 (UTC)
Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIOWbnuWkjTog5Zue5aSNOiDlm57lpI06IFtQQVRDSCB2MiAwMS8xMV0gTWRlUGtnLCBPdm1mUGtnOiBDbGVhbiB1cCBHSENCIGZpZWxkIG9mZnNldHMgYW5kIHNhdmUgYXJlYQ==?=
To: gaoliming <gaoliming@byosoft.com.cn>, devel@edk2.groups.io,
 thomas.lendacky@amd.com
Cc: 'Brijesh Singh' <brijesh.singh@amd.com>,
 'Michael D Kinney' <michael.d.kinney@intel.com>,
 'Zhiguang Liu' <zhiguang.liu@intel.com>,
 'Jordan Justen' <jordan.l.justen@intel.com>,
 'Ard Biesheuvel' <ard.biesheuvel@arm.com>
References: <cover.1602864557.git.thomas.lendacky@amd.com>
 <523f270e4e6f7a62cdbebc541b442bd766e7ab3a.1602864557.git.thomas.lendacky@amd.com>
 <000d01d6a5b9$03d14ef0$0b73ecd0$@byosoft.com.cn>
 <93c3b271-ccdb-6242-ce23-957eb73a66c0@amd.com>
 <b0078a32-19d3-b7ed-64de-2f597d217abb@redhat.com>
 <006f01d6a67d$80b77d80$82267880$@byosoft.com.cn>
 <cbbbef09-2e81-3711-41b3-57d46647bf45@redhat.com>
 <8734b948-e36c-81f4-43ae-6c63fba1374b@amd.com>
 <004401d6a744$b6208e90$2261abb0$@byosoft.com.cn>
 <a4f885c7-2adc-5376-4dd1-9afe8885796a@amd.com>
 <008b01d6a812$4a331df0$de9959d0$@byosoft.com.cn>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <4f1962a2-f417-4c27-1ddb-957b3d3abeb0@redhat.com>
Date: Thu, 22 Oct 2020 15:12:41 +0200
MIME-Version: 1.0
In-Reply-To: <008b01d6a812$4a331df0$de9959d0$@byosoft.com.cn>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 10/22/20 03:25, gaoliming wrote:
> Tom:
>   For the patch in UefiCpuPkg, this changes the library interface. So, the consumer and producer code is required to be changed together. There is no good compatible way to do it. I still prefer to separate them for the different package. Although the first commit breaks the tree, your patch is the patch serial, they will be merged together. Its impact should be small. 

I really disagree here. Bisectability is way more important, in my
opinion, than avoiding a multi-package patch.

I agree we should avoid multi-package patches as much as we can -- but
not more than we can. Bisectability (= keeping the tree buildable at
every commit) is very important, in my opinion.

Thanks,
Laszlo