From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0059.outbound.protection.outlook.com [104.47.32.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B8BA721EA35A5 for ; Tue, 5 Sep 2017 11:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=tOCeesFgoAgW3cVSDXWCbhjGvAbYuS5wdmBfs20UYEw=; b=QzeF+NJhvYmniX0Pk8l3Znxl0tKuIWLivV0AIZASizhpvb5kRVMb7MstI+JZPQPi2DuHU7GplPlXbMz7L+2hsA1qpZf4Nir0DMaM6vtl9xj1tQer4C42aA9Gh+W1VsXrZEWOS3EwlfTScZutAkK12eAX2qS2v1YNWexAoHQ9QCY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Received: from [10.236.136.62] (165.204.77.1) by CY1PR12MB0151.namprd12.prod.outlook.com (10.161.173.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Tue, 5 Sep 2017 18:57:10 +0000 Cc: brijesh.singh@amd.com, Jordan Justen , Tom Lendacky , Ard Biesheuvel To: Laszlo Ersek , edk2-devel@lists.01.org References: <1504265045-19008-1-git-send-email-brijesh.singh@amd.com> <1504265045-19008-2-git-send-email-brijesh.singh@amd.com> <04fefb16-23d5-f6df-0657-9d4c5e96ac57@redhat.com> From: Brijesh Singh Message-ID: <4f286363-6f04-bee0-8b12-34b50a813e70@amd.com> Date: Tue, 5 Sep 2017 13:57:05 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <04fefb16-23d5-f6df-0657-9d4c5e96ac57@redhat.com> X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR01CA0026.prod.exchangelabs.com (10.172.172.140) To CY1PR12MB0151.namprd12.prod.outlook.com (10.161.173.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 50294a79-ab7b-4e1b-3bd4-08d4f48fea73 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR12MB0151; X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 3:bsYcKbzA/ugX41qOisHBN4ha2hi3rFGP6SbdgNReIGr75eOa7bXBertpeUsZR+waE2OlllFbsUfHXWMN4+3Ji036vNmc4ZdYw3pw2CUWHzc4mJxUGNe5I+9MLJsgO5FsIrHoz/1MrPMMQxPrTyae/IhX+F5/Ka37p0JnQELSCFv5jSupU3ZfxldEEstK+kiD5dfeQodpKRV3mgoTdYMYZxRuOn+bfp36uQuVmN/UFGvDIZocI/CrckQRjV0vZqOA; 25:uedJv2QjcowcF/YnCQJmOdhc4nXK4Ngo6htGiI/AzJ63phPd8AR3HPP7wuxlvNXMJRR4nXma1NSO5eWmLbhv3d7BhC4+h9ldAFK5XIIgaAXFLLKqs3zJzvd9jXBNSnGDXFsvvNYvte+cqfVyzfIkP81/v2NSq5m+nX6CNt4+Eea9VKN8wcIdI3KS8rpgKcgdpPwsmJB9v9PXsPF/YCBhwsmU8mRkBgbeu2/XjmwqFMGkI7JDyxPE3fTvcP9BuTCLksnzPYSMKwLmnaMuzEnxwy39xkacw3eZ8jfif7oKlETCSP0t9u2LOAZGs9cCFriJgPa2aCbKHB1MDdSsaBZblA==; 31:Fv1KOHEKqccli0K/0C8oGwIWfBqpbMJ2S4RKi+b3Ge785SU0AAXJOlSTUqRKK3v5zXAlgUFP41vgEMJKs7cp5UFis2mbCXeZk6ANHUCwRyBuVqsK//D/v+Waunn1+nCxgwd9cMePi/+ylSQTQ4VkmbOg9NTpfr0WDqfedV8K/m0CAUP/ntcpZhDFb85A6XHhFCQIT0LRPO542i/K/LQfYGMhhYESgyflnUISh23TOWg= X-MS-TrafficTypeDiagnostic: CY1PR12MB0151: X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 20:lg+C2Op2kRvZTbEdc5wAeGz8Kh5kKixu/ZvGLfoBvYWrWzqWo8q3zGxbbSUQFJ4nshsNisLH9mP0dtNoFcfbFSa2ICUHeSQ80KeaApR7/quxMqM0nhJ4302oVPo/INEgzIafgYaVVY3e5/P9zla6dpprSNDk5kjx9hJivbI6HE+Xo58AQfn6OdJxahdALfhaFvQW/2qy7//u6x48sqYl8961c/4sV5La9KuDH43+fRmQEdP6xWMaLAwpG9P40qJvoaL4c3S7vNpuqFfcI55oaODGXNd/+KQPbCKOs/9nnADGoKrFqeGaITL2Du+1lJYJcP+O2Y+sZtCqtlJr+hN7DwiKOGVGMPRol+RzuBSZtFwv9i8dd+/2ikC8BREzR/luEUHIPvNkp+02U/6uoRKDJVfENKBpKTamkcKmsRMKPZwUoM0qnLGTaHRUNUQ/UuQz4SBB/3GHuTYK7E97jMHngFc2RvkAoK7/kHHawoU5Oc1UViOnlc+VC7YKd9mUBPJk; 4:Om7B8ppgA0hVRGhAimnCvKvwYlKlxcRDdDJaFvjgqWEBxJTndxKCQUXPq80Y6+/eXsMECvCPJUnGEh3bL/NDt7w1NQ3gsfPuna8kjqpNZMguDHChIGc6kSd76jftwcpyqkZQ8qUKENBYRUcn8SuyzqCaJpVexC60IZSrRmnADJ4KqdtYjJ/F4lZxDReFr7nlWM156pA2XCmF0QWgh08FSWH3lOXcADt/qkiTFRn91LgXWJFM12UzHo6b8MLuuORm X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR12MB0151; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR12MB0151; X-Forefront-PRVS: 0421BF7135 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(6009001)(199003)(24454002)(377454003)(189002)(65806001)(36756003)(47776003)(25786009)(23676002)(106356001)(65956001)(90366009)(189998001)(77096006)(66066001)(42186005)(54356999)(76176999)(110136004)(229853002)(101416001)(6486002)(54906002)(33646002)(53936002)(4326008)(6246003)(64126003)(50986999)(230700001)(105586002)(53546010)(2906002)(65826007)(6116002)(81156014)(8676002)(81166006)(97736004)(3846002)(305945005)(68736007)(50466002)(31696002)(5660300001)(83506001)(31686004)(6666003)(2950100002)(4001350100001)(7736002)(86362001)(8936002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR12MB0151; H:[10.236.136.62]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUxOzIzOnB0WDc3SXBrNzNLUXJhM3kwUFN6M25FZmR2?= =?utf-8?B?YmpJVjJXcHlnWHA0bDlrdHlaVzhlMTJ0YTJkdGlmbTRMVlFTaVdpVFZ3a3l2?= =?utf-8?B?bnFQWWs2cmxaaFRPTkN3cFhmQytaOVB3TjZwTlJ5YlB3UjI2VVZuaUF3MjFF?= =?utf-8?B?bFVSYlNJb3lVOE4wTTM1dEJOd0VaNlFGeFB0UzZRbTBMWXVRdEJjVGFuSlgw?= =?utf-8?B?MjZlcDJYc2NadkxSM3JTWTRZSVZUMWE3Zkt4QVFxQ1NXektFY2JyMjd3Nk82?= =?utf-8?B?cmw2RUZjZU15Y1JjK21ibVN4WmM2RmhqelFuUkIwdHE0VmJTdjZxVG43QjlM?= =?utf-8?B?UkVKekc5SDFlQmFQb2o5TGZ0Si81NExrZUFIOWtQand3Rmxnb1pkRUd2Q0gr?= =?utf-8?B?YnplbXZYSkpWeHA1MlpuN1JLV1huMEdUVGNoWTQ4c3RLV1phWTdkWTJiZ256?= =?utf-8?B?YklFb0xMWS9LM0xnYlBZc0FEZWRSMkRGOEUzSE9ucUhZTUtYeTYyZjUrTXNo?= =?utf-8?B?aGsrYjJVb3poT2lHRmUvQXV2K29kemlxeTFIdnp4MXBoMW5jbVhNMG9CVXRY?= =?utf-8?B?RFVGSk9kRjRiZzNtNWFqb3pVWDJsWTdncy9yUGdUeTJZQzdHTDczNmE1andI?= =?utf-8?B?UW13dDRKaE13TThjcDlXNDJiRFlEaWVIdlNKQ0xlZEtpeUZFMmVjK2JmTm1I?= =?utf-8?B?aWJtVUFpRVlJZkRSWXNCV3VoUXpiYUdPeXNtckZMbUhZUXJnbU9ESEx4c3Bt?= =?utf-8?B?YW81UnNRMjRRYnFYTHM2NEhHM3RHTWlhMjJKQUpwWS8vaWRuNTUyL2hXTjRD?= =?utf-8?B?a1dITVpMa0F6ODhscTFHSk1rMmxGRzFGbXBLVjNncHBVUmswYTMzMkdhRDBm?= =?utf-8?B?UXp6bkV4VzRjMU9meUI1T1p6TjFYUHZDRUNwbzBURU8vYitMckRXRmJBbkp1?= =?utf-8?B?SjM0UWtlMkJiRDgwQk0ybVZkNHNzUlRLQ1BqV29JZitGVGFZVmhncXN5aHhY?= =?utf-8?B?WVlvNThVTDZWRlptN1h3dTRsOFN2Sk9sRGJML2p6SEpoelZKM0ZMTmVtUW5D?= =?utf-8?B?amY5L2ZuTnJwMDZQTTBOOHJzanRFeWphUzNXMVVWQmc3MDRnQ3AvVzg4Vm9H?= =?utf-8?B?Z2lPb2Faak05OFQxbWswb1hZK0o0LzlnWE91MWJJQmg2Uy90b3V4Y3pTOEx6?= =?utf-8?B?SHBnZm9ERHNpVkVvb0MzWFhzaTRIb3VnTmQ1SWVDWEwzNC9sYllNakxsbEt4?= =?utf-8?B?aUZ5V0dLek1MTmVnUnRJUXZ5QUJscU43WVFvMmt3VGVhZzVkRU9NcUswOHlF?= =?utf-8?B?bFlyeEhrZ3lHQWNSZmJMVHVxQW1xNmxWNWRCNVhxTEFXblBZY0FnT1dXYUI1?= =?utf-8?B?SGFwMURDR2g5QUVWeSt2ZlVoK0dQVU9yMHlselpTRVdCUVFyZTZGZlBrWUVy?= =?utf-8?B?dHZaUXVRM0YwaVppMkU5ME5nbi9MTnFieVN1cFRQdjJKNWVUWCtPUStWejla?= =?utf-8?B?bWt5TE9pdTRqbFdERTVtVUxGcGdDQmlTQ3dBcDk5M25yWThuQjhMZzZhY3l2?= =?utf-8?B?UlhaT3FobEloeGlvRkJpaFpualNBcTg1MGM1dFNlOC9zUldVSlhyKzdMT0ln?= =?utf-8?B?dFJSRmhFNXc1MElNL3FiV1BST0RSdDdSSG12emhuNmUxSzNXVzQyOTdOWXBu?= =?utf-8?B?b3JEd1FFWFQ3bnRLVjBjN0ZyZFFHWHZoVHBUb3d2WG1DWm9QVGRtb0tKVkFo?= =?utf-8?B?dXlwREJnK0dGRTgwSDY2SWlIV1pGT0pQWEROZkhvSkZ0aThsdG0xWHpsZG5m?= =?utf-8?Q?KgdK5aE9CzFVf?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 6:qkA1jyOzuMPdSMn581WxRRpKN+afUXw8yz9CST4uHAecSKea4sNXlI4fD+s6h1dxhxCoOfbl08F8s2KvfvtFUiRz/kAdal90Aa0qbCdC3TEaB4Prkx3anCpef6SmP0uHED+hzndRpkbstkc1WLUQrka683e++ov8fjTjoTcpo9oDZYflQMF6BeCRzDSxXVGhseMNuLX2eirtRzcmsEoSsrspCxNtkDUg528UULAh4lsGv10KtzfV1GvH7ScMpkgwJwzBONj1DQ5DLKUeXFkiuw2KkRv5cYHgt/dhr8vH+J+7ihSXfiLph19r70Jh1QY6U6Qt3Aa+8lq1ohL3N9TVkQ==; 5:IV93NpiJlQSUI1ZKfPOtzzlUbIr2/XCEfbas5WKmeNe4Jxs2Ljnve/Zr8dUKctYt7ibVoErOM9piAe9ciFgudCIFuiuFtpQ8S+bK1zene8wbjTufpL1OIJ50egUPTTgWYuTsmdvWaRuvwbadwD1vjQ==; 24:BGiIltRLBkqRkD24ARu2p4ExM/wEnpoJGIrPe1mQXJxv5WzetiW6ObTDOOLF9cRGedbY+pIywOdGNfB3NxUMzLF5VhERhGjtygV7i7GXkUU=; 7:pv0chfTpEblg2d8oA+drOdSaaAFsa3uK7hgnr3Ig4yBtijgpXUcTDQgXGJ6pjZImWOW6HvP75RkfUDpjxSuG5EMqBFuWv0R/4bQJDFVHNQkJHWjNnyX81lNYRxOBTdsvtdYsQNjO2DJxB0HhA8X00KXx1bk12rKRNsO/aD3Gejq5zYpxXfrojokkyP/RjX3aTstjSkYKMwzRhh/zlrP7tInKexB3dH/4qS5HVYhVAG8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR12MB0151; 20:XBarVpdtUnMxs96ckMrVOHeXFjDdCebrLgxYN2WyhXf2kNo/niRuDBI4yujRLDRuM1etkZefg/yqu1jSS9WEsYmFtgg+KCRkgstQ7IjfXehllW6IkRC+eGhqfzTUp/8WFnCubPxyMNNNhaND61WcbUxkQ/PWumlZdeg2oDOLBhU9iR4dTAof9b1mKYIhRtKe5AzboJvSVwDotThOklEH6ZxI2hnCz+FbxjOA3Kck30CWOgftbZMRipe61QDtn0/u X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2017 18:57:10.9816 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0151 Subject: Re: [PATCH 1/5] OvmfPkg/VirtioNetDxe: map VRING using VirtioRingMap() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 18:54:25 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Laszlo, Thanks for quick reviews. I will go through each feedback address them in v2. On 09/05/2017 06:47 AM, Laszlo Ersek wrote: [...] > > Please also modify the commit message similarly: "map the VRING system > physical address[es] to device address[es]". > > > Would it be OK with you to submit only these two patches next? I saw that you looked at other patches, just wondering, do you still want me to submit two patches and advance in small steps ? > > I wouldn't like to look at the rest of the patches just now. I expect > quite a few tweaks -- especially because I would *really* like to keep > "TechNotes.txt" up to date! --, and I'd like to keep my focus, and > advance in small steps. I must re-read TechNotes.txt myself, in parallel > to the progress that we make with this series. > > Once we consider these patches complete, we can test them and commit > them in isolation. Further versions of the series won't have to repeat > these patches. > > I'll strive to be very responsive, so that you don't have to wait long > after every small step. >