From: Andrei Borzenkov <arvidjaar@gmail.com>
To: edk2-devel-01 <edk2-devel@ml01.01.org>,
The development of GNU GRUB <grub-devel@gnu.org>
Subject: Should Path Name in File Path Media Device Path node be NULL terminated?
Date: Fri, 24 Feb 2017 10:06:03 +0300 [thread overview]
Message-ID: <4f2ae7ff-9e79-8fd7-5a09-0841e3f21d0c@gmail.com> (raw)
Historically grub2 built image paths using two File Path nodes - one for
directory and one for file name relative to directory. These nodes had
path names that were not NULL terminated.
Recently we had bug report that secure boot using grub2 failed. It was
tracked down to exactly the fact that paths were not NULL terminated.
See
http://git.savannah.gnu.org/cgit/grub.git/commit/?id=ce95549cc54b5d6f494608a7c390dba3aab4fba7
Unfortunately this caused another regression which looks like firmware
truncating passed image path on first NULL
https://bugzilla.opensuse.org/show_bug.cgi?id=1026344
Could someone clarify what is expected by EFI spec? Should each Path
Name (even intermediate) be NULL terminated, or spec intends to say that
only full path must be NULL terminated?
next reply other threads:[~2017-02-24 7:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 7:06 Andrei Borzenkov [this message]
2017-02-24 7:40 ` Should Path Name in File Path Media Device Path node be NULL terminated? Tian, Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f2ae7ff-9e79-8fd7-5a09-0841e3f21d0c@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox