From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "discuss@edk2.groups.io" <discuss@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
Michael Kubacki <mikuback@linux.microsoft.com>
Subject: [edk2-devel] github impact:breaking-change
Date: Mon, 8 Jul 2024 12:00:09 +0100 [thread overview]
Message-ID: <4f3b1520-065f-4f43-9950-162cbdc0266a@quicinc.com> (raw)
Hi,
I'm seeing something in several PRs in flight (and merged) that have
"impact:breaking-change" set, where the purpose of the PR is to fix said
breakage, not introduce API compatibilities.
Am I correct in my understanding that this is not the intended use, and
if so how do we address the misconception?
Can we start by adding a description for the label? It currently has none.
Mu uses "Requires integration attention", which matches my
understanding, but feels a bit abstract. How about
"This change breaks existing APIs"
or
"This change may require corresponding updates to code in other
repositories"?
/
Leif
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119813): https://edk2.groups.io/g/devel/message/119813
Mute This Topic: https://groups.io/mt/107100295/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next reply other threads:[~2024-07-08 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 11:00 Leif Lindholm [this message]
2024-07-09 14:44 ` [edk2-devel] github impact:breaking-change Michael Kubacki
2024-07-09 15:03 ` Leif Lindholm
2024-07-09 15:12 ` Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f3b1520-065f-4f43-9950-162cbdc0266a@quicinc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox