From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 242DA7803D8 for ; Mon, 8 Jul 2024 11:00:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=jQUR3HUFxByIFP3McHfeKMPefR+hsIPLwfWuvgxTzXg=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:To:CC:From:Subject:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1720436431; v=1; b=0h5TJIxOCeALG7k2tA/HLACuTid1Nd9n3kq/8xqEJUdZsR5iVvH2Cvbf9DGzPAjdkt5C9KYC +gQPDUL/TeEHgUXqLH6PUEiF2kHKAtbxrsJ1flQ2nYSORaR9kW5iX73kVpIWQzuEk1go7BqEW3o AKoVabNr6IPP2lP9UUNvjEvIDvraRQ9ApmwBDTya2AcfnSc3OU7OLiF2x1b0SeusDIIsFf3BB4b BAv+q0s5ftljzpWow3DEsP8VuHKJc0D7dWgMmEeTKzQhMuFkRgqrUg30USGwjtbYhWE2rOxGw4s wNaLmgp2xKJPGb8OCmsdb65gVvRmsnC+pjlKGum3Do4Wg== X-Received: by 127.0.0.2 with SMTP id o9Y7YY7687511xf4OyonT8Tr; Mon, 08 Jul 2024 04:00:30 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.77028.1720436429473555326 for ; Mon, 08 Jul 2024 04:00:29 -0700 X-Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 468AZgkG029428; Mon, 8 Jul 2024 11:00:28 GMT X-Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 406xa63c6u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 08 Jul 2024 11:00:28 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 468B0CYZ018130 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 8 Jul 2024 11:00:12 GMT X-Received: from [10.111.132.33] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 8 Jul 2024 04:00:11 -0700 Message-ID: <4f3b1520-065f-4f43-9950-162cbdc0266a@quicinc.com> Date: Mon, 8 Jul 2024 12:00:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: "devel@edk2.groups.io" CC: "discuss@edk2.groups.io" , "Kinney, Michael D" , Michael Kubacki From: "Leif Lindholm" Subject: [edk2-devel] github impact:breaking-change X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: TuPEw8vk1DpSVdxUFuKlKyb-Y1JscBdy X-Proofpoint-ORIG-GUID: TuPEw8vk1DpSVdxUFuKlKyb-Y1JscBdy Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 08 Jul 2024 04:00:29 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: rM5jMZjwVfvVZw7ZypPByUYMx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=0h5TJIxO; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Hi, I'm seeing something in several PRs in flight (and merged) that have=20 "impact:breaking-change" set, where the purpose of the PR is to fix said=20 breakage, not introduce API compatibilities. Am I correct in my understanding that this is not the intended use, and=20 if so how do we address the misconception? Can we start by adding a description for the label? It currently has none. Mu uses "Requires integration attention", which matches my=20 understanding, but feels a bit abstract. How about "This change breaks existing APIs" or "This change may require corresponding updates to code in other=20 repositories"? / Leif -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119813): https://edk2.groups.io/g/devel/message/119813 Mute This Topic: https://groups.io/mt/107100295/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-