Re: [PATCH v4 3/5] OvmfPkg: Add RngLib based on TimerLib for Crypto

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 8/11/20 4:21 AM, matthewfcarlson@gmail.com wrote:
> From: Matthew Carlson <macarl@microsoft.com>
> 

How am I supposed to review this change? The commit log is empty and I 
was not cc'ed on the cover letter.

In general, please try to muster up the energy to write at least one 
sentence that describes *why* the patch is needed, complementing the 
subject line, which in this case summarizes correctly *what* the patch does.

Thanks,
Ard.



> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Julien Grall <julien@xen.org>
> Signed-off-by: Matthew Carlson <matthewfcarlson@gmail.com>
> ---
>   OvmfPkg/OvmfPkgIa32.dsc    | 1 +
>   OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
>   OvmfPkg/OvmfPkgX64.dsc     | 1 +
>   OvmfPkg/OvmfXen.dsc        | 1 +
>   4 files changed, 4 insertions(+)
> 
> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
> index 9178ffeb71cb..118fd1aff246 100644
> --- a/OvmfPkg/OvmfPkgIa32.dsc
> +++ b/OvmfPkg/OvmfPkgIa32.dsc
> @@ -116,6 +116,7 @@
>   [LibraryClasses]
>     PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>     TimerLib|OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.inf
> +  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
>     ResetSystemLib|OvmfPkg/Library/ResetSystemLib/BaseResetSystemLib.inf
>     PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>     BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf
> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
> index a665f78f0dc7..6b9da5b996ff 100644
> --- a/OvmfPkg/OvmfPkgIa32X64.dsc
> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc
> @@ -120,6 +120,7 @@
>   [LibraryClasses]
>     PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>     TimerLib|OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.inf
> +  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
>     ResetSystemLib|OvmfPkg/Library/ResetSystemLib/BaseResetSystemLib.inf
>     PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>     BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf
> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
> index 17f345acf4ee..3a354eb3a2bd 100644
> --- a/OvmfPkg/OvmfPkgX64.dsc
> +++ b/OvmfPkg/OvmfPkgX64.dsc
> @@ -120,6 +120,7 @@
>   [LibraryClasses]
>     PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>     TimerLib|OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.inf
> +  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
>     ResetSystemLib|OvmfPkg/Library/ResetSystemLib/BaseResetSystemLib.inf
>     PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>     BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf
> diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc
> index 782803cb2787..f97e2b7e07d0 100644
> --- a/OvmfPkg/OvmfXen.dsc
> +++ b/OvmfPkg/OvmfXen.dsc
> @@ -110,6 +110,7 @@
>   [LibraryClasses]
>     PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
>     TimerLib|MdePkg/Library/SecPeiDxeTimerLibCpu/SecPeiDxeTimerLibCpu.inf
> +  RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
>     ResetSystemLib|OvmfPkg/Library/ResetSystemLib/BaseResetSystemLib.inf
>     PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>     BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf
>