From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web10.4772.1635927200767302723 for ; Wed, 03 Nov 2021 01:13:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=muke0FNm; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: dovmurik@linux.ibm.com) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1A37vRNd005474; Wed, 3 Nov 2021 08:13:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=/2hmOTJ6eftlAX5NO6d/h49N7n+3TlEsFkMzOanDfrQ=; b=muke0FNmDiKZ6PGCdr2dvPVWQ+72bGWCO7j1GJapfWDYSkQs9FFEwLeUy40IDpOuwUOh 3cb39z/PzKryqJZctoGNg0tZ7gVvAiZVeTZATNVMVdL1vRdk8f9t/bf/O0Bukq4+lmQy IdiQKn1NJ7D/3DAe1S5YZkPMh1Lx6M7UVkfPIs4NUYPVkA+RHc1MIKdWYf8Iv/ylyv9C hQ7aTXdFyNv0Tn2hyN302O5XUICEvBrOxTebNL813MT7pZSlfVP8M9yfWglyvHPkKayQ c3Ytwy5SlOZqGQlUQkbEb8owCbUySapCc8ODAX4+fohX4EZ6fR7B/S6lCrjmgF8/Esym tQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3c3ju4m6g0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Nov 2021 08:13:16 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1A37uvxf030029; Wed, 3 Nov 2021 08:13:16 GMT Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 3c3ju4m6fc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Nov 2021 08:13:15 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1A38CfZc006844; Wed, 3 Nov 2021 08:13:14 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma04wdc.us.ibm.com with ESMTP id 3c0wpbbytn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Nov 2021 08:13:14 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1A38DDaD38732226 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 3 Nov 2021 08:13:13 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C1C53124058; Wed, 3 Nov 2021 08:13:13 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A4911124053; Wed, 3 Nov 2021 08:13:11 +0000 (GMT) Received: from [9.65.202.213] (unknown [9.65.202.213]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 3 Nov 2021 08:13:11 +0000 (GMT) Message-ID: <4fa80c5c-45c8-109f-ec41-a17adb29131b@linux.ibm.com> Date: Wed, 3 Nov 2021 10:13:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD To: Gerd Hoffmann , Tom Lendacky Cc: James Bottomley , devel@edk2.groups.io, Brijesh Singh , Ard Biesheuvel , Jordan Justen , Erdem Aktas , Jiewen Yao , Min Xu , Dov Murik References: <20211102073422.340858-1-dovmurik@linux.ibm.com> <20211102073422.340858-2-dovmurik@linux.ibm.com> <20211102100347.ulf4mt4fwjrsbaud@sirius.home.kraxel.org> <07819666-8465-6e46-7e07-a99b1b793073@linux.ibm.com> <20211102132954.5q2dxrbrz77fcdao@sirius.home.kraxel.org> <5f3cbabe-9a50-662a-16d9-09a1d04a3542@amd.com> <20211103060711.uaalevtxebwfnvgg@sirius.home.kraxel.org> From: "Dov Murik" In-Reply-To: <20211103060711.uaalevtxebwfnvgg@sirius.home.kraxel.org> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: HAuVCYAEgEWuaW1tpBBVdX9vHgY2dHFt X-Proofpoint-GUID: AefCgM10tVOtRh428oQa5kSCWRwvgKYt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-11-03_02,2021-11-02_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 bulkscore=0 mlxscore=0 clxscore=1011 mlxlogscore=999 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2111030049 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/11/2021 8:07, Gerd Hoffmann wrote: > Hi, > >>>> Does SEV need and/or use SMM mode? Looking through AmdSevX64.dsc >>>> doesn't give a clear answer, on one hand there is a >>>> LibraryClasses.common.SMM_CORE section, but on the other hand it uses >>>> the non-SMM variable driver stack. >>> >>> I think SEV doesn't work with SMM. James - can you please give a more >>> definitive answer here? >> >> SEV works with SMM, but SEV-ES (and likely SEV-SNP) doesn't work with SMM >> because of the fact that the hypervisor wants to change the guest register >> state to enter SMM, which isn't allowed and results in a VMRUN failure. > > Ok. So the same reason why TDX doesn't support SMM either. > >> It might be possible to get SMM to work by having separate VMSAs for the SMM >> state, but it is not anything that really has been investigated too deeply. > > Should we just drop the SMM leftovers in AmdSevX64.{dsc,fdf} then? > Yes please. I can test such changes with the AmdSevX86 build. -Dov