Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Require Package node in hierarchy

["PierreGondois" <pierre.gondois@arm.com>]

Hello Jeshua,

On 2/2/24 20:19, Jeshua Smith wrote:
> The code was incorrectly assuming that root nodes had to be physical
> package nodes and vice versa. This is not always true, so update the
> check to simply require exactly one package node somewhere in the
> hierarchy.
> 
> Signed-off-by: Jeshua Smith <jeshuas@nvidia.com>
> ---
> Note: This is a complete replacement for [PATCH] DynamicTablesPkg/SSDT: Remove incorrect root node check
> 
>   .../SsdtCpuTopologyGenerator.c                | 30 ++++++++++++-------
>   1 file changed, 20 insertions(+), 10 deletions(-)
> 
> diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> index 9e3efb49e6..e400ac4ae5 100644
> --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
> @@ -1083,23 +1083,24 @@ CheckProcNode (
>     UINT32           NodeFlags,
>     BOOLEAN          IsLeaf,
>     CM_OBJECT_TOKEN  NodeToken,
> -  CM_OBJECT_TOKEN  ParentNodeToken
> +  CM_OBJECT_TOKEN  ParentNodeToken,
> +  BOOLEAN          PackageNodeSeen
>     )

NIT: I think 'PackageNodeSeen' must be added to the function's documentation.

Otherwise:
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>

Regards,
Pierre


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115111): https://edk2.groups.io/g/devel/message/115111
Mute This Topic: https://groups.io/mt/104126146/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-