From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A3E11D80144 for ; Mon, 5 Feb 2024 09:38:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DzkFqY6YkF9aUiB3puOGRoRQ6X5aIB9yiMf8LkD/HEw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707125934; v=1; b=w8f9Fy0pNk18MXq8LnrBqGDogOoqChqR+SuNfktILuaccpcQSpLrWrrenbeW4Ch5Rue2Y5/A fhQosGiAr/UH7EkUE/uU4vDVXN5Ak91CJuTjmNPGfYqO0ino6md8YdTj9fydMOV+gaIMQVtE7pr 4N9eaSt/dWlHReMjKfNBpmck= X-Received: by 127.0.0.2 with SMTP id qL1xYY7687511xRW5rHDdOBj; Mon, 05 Feb 2024 01:38:54 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.59132.1707125933367923299 for ; Mon, 05 Feb 2024 01:38:53 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EC84E1FB; Mon, 5 Feb 2024 01:39:34 -0800 (PST) X-Received: from [10.34.100.129] (e126645.nice.arm.com [10.34.100.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB34A3F5A1; Mon, 5 Feb 2024 01:38:51 -0800 (PST) Message-ID: <4fd86ffb-766e-4318-952b-ef547342a4af@arm.com> Date: Mon, 5 Feb 2024 10:38:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH] DynamicTablesPkg/SSDT: Require Package node in hierarchy To: Jeshua Smith , devel@edk2.groups.io Cc: ardb+tianocore@kernel.org, quic_llindhol@quicinc.com, Sami.Mujawar@arm.com References: From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HcJm2Za69BvwdZKyn8t3TN2Gx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=w8f9Fy0p; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none) Hello Jeshua, On 2/2/24 20:19, Jeshua Smith wrote: > The code was incorrectly assuming that root nodes had to be physical > package nodes and vice versa. This is not always true, so update the > check to simply require exactly one package node somewhere in the > hierarchy. >=20 > Signed-off-by: Jeshua Smith > --- > Note: This is a complete replacement for [PATCH] DynamicTablesPkg/SSDT: R= emove incorrect root node check >=20 > .../SsdtCpuTopologyGenerator.c | 30 ++++++++++++------- > 1 file changed, 20 insertions(+), 10 deletions(-) >=20 > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/= SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuT= opologyLibArm/SsdtCpuTopologyGenerator.c > index 9e3efb49e6..e400ac4ae5 100644 > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpu= TopologyGenerator.c > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpu= TopologyGenerator.c > @@ -1083,23 +1083,24 @@ CheckProcNode ( > UINT32 NodeFlags, > BOOLEAN IsLeaf, > CM_OBJECT_TOKEN NodeToken, > - CM_OBJECT_TOKEN ParentNodeToken > + CM_OBJECT_TOKEN ParentNodeToken, > + BOOLEAN PackageNodeSeen > ) NIT: I think 'PackageNodeSeen' must be added to the function's documentatio= n. Otherwise: Reviewed-by: Pierre Gondois Regards, Pierre -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115111): https://edk2.groups.io/g/devel/message/115111 Mute This Topic: https://groups.io/mt/104126146/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-