From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.4648.1591700331832846018 for ; Tue, 09 Jun 2020 03:58:52 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 53EB51FB; Tue, 9 Jun 2020 03:58:51 -0700 (PDT) Received: from [192.168.1.69] (unknown [10.37.8.184]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 23DC13F66F; Tue, 9 Jun 2020 03:58:49 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH] OvmfPkg/GenericQemuLoadImageLib: log "Not Found" at INFO level To: devel@edk2.groups.io, lersek@redhat.com Cc: Jordan Justen , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20200609105414.12474-1-lersek@redhat.com> From: "Ard Biesheuvel" Message-ID: <4fe4280e-0171-098f-1ed5-fa2b37d00a41@arm.com> Date: Tue, 9 Jun 2020 12:58:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200609105414.12474-1-lersek@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/9/20 12:54 PM, Laszlo Ersek via groups.io wrote: > gBS->LoadImage() returning EFI_NOT_FOUND is an expected condition; it > means that QEMU wasn't started with "-kernel". Log this status code as > INFO rather than ERROR. >=20 > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daud=C3=A9 > Signed-off-by: Laszlo Ersek Acked-by: Ard Biesheuvel > --- >=20 > Notes: > Repo: https://pagure.io/lersek/edk2.git > Branch: gqlil_not_found >=20 > OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c | 3= ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadIma= geLib.c b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib= .c > index 14c8417d43e7..114db7e8441f 100644 > --- a/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c > +++ b/OvmfPkg/Library/GenericQemuLoadImageLib/GenericQemuLoadImageLib.c > @@ -106,7 +106,8 @@ QemuLoadKernelImage ( > goto UnloadImage; > =20 > default: > - DEBUG ((DEBUG_ERROR, "%a: LoadImage(): %r\n", __FUNCTION__, Status= )); > + DEBUG ((Status =3D=3D EFI_NOT_FOUND ? DEBUG_INFO : DEBUG_ERROR, > + "%a: LoadImage(): %r\n", __FUNCTION__, Status)); > return Status; > } > =20 >=20