From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id D9391AC0D3D for ; Wed, 17 Apr 2024 07:13:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=A93AypxgwI1+HxGsomSt+DY8p4Bspoa48fVVqlZDviY=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20240206; t=1713338018; v=1; b=VYvk/lIIDn+JO8lVnYUbcERMPcvhALRLPVpCO9Y9MYvyyKi9AGg5ATaZ0AbItLtNS8jQfowi /4Ve3UNlb2Fwt2nu+GBVg585X9RbitSr6OKxHqc9iJIQMRQ+fLP8CkBhJOmusFwuKGjqrVasjhn YFQ24T9uhlJtOXJcBIhuAlIk9qNo1QUccqoraPf1jMuQMIrnokb1IVEhD02ggO/fniZR3hYAFKV wbNhc+iMWYBcEGPCpJPSwyGCs22MFsH6yAGqNWQl1bSb+Vu32Ra59brLE9BA+pEwbMl/C5hc6DF f2LAOoIE58hqleXwVVo2SqhmBTL8Ihuw94ownGe36CeQg== X-Received: by 127.0.0.2 with SMTP id STGxYY7687511xOBSiOpckvm; Wed, 17 Apr 2024 00:13:38 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.7018.1713338017731980837 for ; Wed, 17 Apr 2024 00:13:37 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-533-0H-7DFWQMp6MGvVhhd1SFg-1; Wed, 17 Apr 2024 03:13:33 -0400 X-MC-Unique: 0H-7DFWQMp6MGvVhhd1SFg-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2F6233C13A89; Wed, 17 Apr 2024 07:13:33 +0000 (UTC) X-Received: from dobby.home.kraxel.org (unknown [10.39.192.214]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F228351EF; Wed, 17 Apr 2024 07:13:32 +0000 (UTC) X-Received: by dobby.home.kraxel.org (Postfix, from userid 1000) id 7B8F0EE01C; Wed, 17 Apr 2024 09:13:27 +0200 (CEST) Date: Wed, 17 Apr 2024 09:13:27 +0200 From: "Gerd Hoffmann" To: "Yao, Jiewen" Cc: "devel@edk2.groups.io" , "Xu, Min M" , Ard Biesheuvel Subject: Re: [edk2-devel] [PATCH V1 0/5] Move Tdx specific lib from SecurityPkg to OvmfPkg Message-ID: <4pwzvrbg4ix3xtzed56mhp3tmz4wqetw6fnehkqfgb3ep6tcpn@5l2odwuohtt7> References: <20240415075555.499-1-min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 17 Apr 2024 00:13:37 -0700 Resent-From: kraxel@redhat.com Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: seSAW9Q2zP4wsoeYaYEh6OXPx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="VYvk/lII"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Apr 16, 2024 at 03:40:08PM +0000, Yao, Jiewen wrote: > Yeah, I also considered that before. But after look at current code structure, I give up. > > Since following SEV component are NOT in AmdSev directory (especially the TCG one), I do not see a strong reason to put them to IntelTdx dir. > https://github.com/tianocore/edk2/tree/master/OvmfPkg/AmdSevDxe > https://github.com/tianocore/edk2/tree/master/OvmfPkg/Tcg/TpmMmioSevDecryptPei > https://github.com/tianocore/edk2/tree/master/OvmfPkg/Library/BaseMemEncryptSevLib Yes, existing placement is inconsistent. Some code is in AmdSev / IntelTdx subdirs, some is not. There are also some Tdx libraries in OvmfPkg/Library instead of OvmfPkg/IntelTdx > I think we can follow the existing code structure in this patch set. OK take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117900): https://edk2.groups.io/g/devel/message/117900 Mute This Topic: https://groups.io/mt/105531957/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-