From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.3572.1589367945896329959 for ; Wed, 13 May 2020 04:05:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BTJ6fqZE; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589367945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PNBQcRo8chE+3hIysJJRLSzZfx6wDY0dYlfIWV4v4ZI=; b=BTJ6fqZEQkghTkZtSjA3+4wZuST2O5jPZJCr0Rem5CZm3LAHINfv8t2Nn99SCoyOlkWQ+A loaeZV/jrJOOo56ogFiQMihSZCNDhhtz9L1ypYHXRpPwCOl7IYC6sKtgGBJS9QVGF56Wa5 lHevx48fWU/DziO7VpkIYmWhMGI8k3k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-283-kfgRkfCWPAKYLnoMc3xZQA-1; Wed, 13 May 2020 07:05:40 -0400 X-MC-Unique: kfgRkfCWPAKYLnoMc3xZQA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D52EE107ACCA; Wed, 13 May 2020 11:05:38 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-95.ams2.redhat.com [10.36.115.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id B61335C1C3; Wed, 13 May 2020 11:05:37 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH V5 07/27] ArmVirtPkg: Add support for DebugCommonLib To: devel@edk2.groups.io, cheptsov@ispras.ru Cc: Ard Biesheuvel , Leif Lindholm References: <20200512170237.19796-1-cheptsov@ispras.ru> <20200512170237.19796-8-cheptsov@ispras.ru> From: "Laszlo Ersek" Message-ID: <500e6b38-3ac4-ea7c-e738-eb8318f2719e@redhat.com> Date: Wed, 13 May 2020 13:05:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200512170237.19796-8-cheptsov@ispras.ru> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 05/12/20 19:02, Vitaly Cheptsov wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > CC: Laszlo Ersek > CC: Ard Biesheuvel > CC: Leif Lindholm > Signed-off-by: Vitaly Cheptsov > --- > ArmVirtPkg/ArmVirt.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index cf44fc7389..4f3092a201 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -39,6 +39,7 @@ [LibraryClasses.common] > !else > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > !endif > + DebugCommonLib|MdePkg/Library/BaseDebugCommonLib/BaseDebugCommonLib.inf > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > This patch is identical to the v4 one; you should have picked up my R-b from there: http://mid.mail-archive.com/2ea78a2b-9736-0b4e-5596-d0bd68a339fa@redhat.com https://edk2.groups.io/g/devel/message/59199 Anyway: Reviewed-by: Laszlo Ersek