From: "Rebecca Cran" <rebecca@nuviainc.com>
To: devel@edk2.groups.io, pierre.gondois@arm.com,
bob.c.feng@intel.com, gaoliming@byosoft.com.cn
Cc: sami.mujawar@arm.com
Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Align include guards policy
Date: Mon, 15 Feb 2021 15:08:01 -0700 [thread overview]
Message-ID: <50128f55-dbdd-1884-77b3-ce27a560bad6@nuviainc.com> (raw)
In-Reply-To: <20210125154525.18449-1-Pierre.Gondois@arm.com>
On 1/25/21 8:45 AM, PierreGondois wrote:
> diff --git a/BaseTools/Source/Python/Ecc/Check.py b/BaseTools/Source/Python/Ecc/Check.py
> index 6087abfa4d8d..14759d21f5d8 100644
> --- a/BaseTools/Source/Python/Ecc/Check.py
> +++ b/BaseTools/Source/Python/Ecc/Check.py
> @@ -2,6 +2,7 @@
> # This file is used to define checkpoints used by ECC tool
> #
> # Copyright (c) 2008 - 2020, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> diff --git a/BaseTools/Source/Python/Ecc/EccToolError.py b/BaseTools/Source/Python/Ecc/EccToolError.py
> index 0ff3b42674d4..58d0749477b2 100644
> --- a/BaseTools/Source/Python/Ecc/EccToolError.py
> +++ b/BaseTools/Source/Python/Ecc/EccToolError.py
> @@ -2,6 +2,7 @@
> # Standardized Error Handling infrastructures.
> #
> # Copyright (c) 2008 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
> # SPDX-License-Identifier: BSD-2-Clause-Patent
I don't think this is in the coding standards, but newer copyright lines
are generally placed above, not below, older ones.
--
Rebecca Cran
prev parent reply other threads:[~2021-02-15 22:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 15:45 [PATCH v1 1/1] BaseTools: Align include guards policy PierreGondois
2021-01-25 15:56 ` [edk2-devel] " PierreGondois
2021-01-26 1:22 ` 回复: " gaoliming
2021-01-26 11:07 ` [edk2-devel] " Leif Lindholm
2021-02-03 22:31 ` PierreGondois
2021-02-04 7:27 ` 回复: " gaoliming
2021-02-04 10:16 ` Sami Mujawar
2021-02-15 22:03 ` [edk2-devel] 回复: " PierreGondois
2021-02-18 5:42 ` 回复: " gaoliming
2021-02-04 10:22 ` Sami Mujawar
2021-02-15 22:08 ` Rebecca Cran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50128f55-dbdd-1884-77b3-ce27a560bad6@nuviainc.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox