From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173])
 by mx.groups.io with SMTP id smtpd.web09.471.1613426883671203471
 for <devel@edk2.groups.io>;
 Mon, 15 Feb 2021 14:08:03 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=1tVssn/z;
 spf=pass (domain: nuviainc.com, ip: 209.85.166.173, mailfrom: rebecca@nuviainc.com)
Received: by mail-il1-f173.google.com with SMTP id m20so6674063ilj.13
        for <devel@edk2.groups.io>; Mon, 15 Feb 2021 14:08:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
        h=subject:to:cc:references:from:message-id:date:user-agent
         :mime-version:in-reply-to:content-language:content-transfer-encoding;
        bh=ZB8BSZTttSTjSo0bIzElqieBZ+ZI9nxLrDaDQ54PYrs=;
        b=1tVssn/zjHH3biNtsU/seEJWYVQLRKYRYqCLxYL+sHuEPQefd9IIyV/fEXhIuJoNc6
         AVe24eKUdK7TjscASKBUPr6rQLmFv61LtX8+07FVoumOUOzzOd27Mb32NJRW+RWTc6hI
         7Vwd/oPWX3kXUbw5eIxMKVVixop/AAsAiDNiZ042O7B1wqMJLRSzBHnMY3q2xufSCDBh
         syUgRkD3Cj7b3+ZRcuTnySCfATJwgvAYrYk5iBduxkxPdhiFqZn5Ul1oLq3rfxwib8WN
         51AMfjkmBXLGs+zw4rCekwxXd3lR7lYIC7nSzBcbRuR6tUTClGfFFaWf3S1DLQRkByCi
         JoLg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=ZB8BSZTttSTjSo0bIzElqieBZ+ZI9nxLrDaDQ54PYrs=;
        b=HTgDe9ms3cUWu1CLs3yQmYb/1/cSt87LWyJOt/Wx5BNmBYsYcSaUevDcZaUz8gtoXI
         JyuR67RcLc6q25BWrRRk0MQwJZD1nGV9nbuXtrJXmy6kGq4oQoG23JplcZbUaOnZ5MTE
         k28L3xewUhNu4OJenaGtL1udx1cC1QC4/HZ/VfRDxde5pRLu3DxINKhMJJfJ9ripIJNn
         uWDHBXYNW5/zi9vj91WHIcTc1HMnVXxHJ1RTOpXslWOXQJuYKFqqk4RKnTzyuz/YnVf+
         QRO9UGYZPB9NgcB9jXOZFxbzZvsf4dWnkOxtSIUzhmtHmd0ps8oFCQ2A1/C1a0T9YcUq
         lk/g==
X-Gm-Message-State: AOAM531sC84BO3y2dNETN/H6F1E38yPGOIRKDA1Kgxbz3IfRW99JFJYK
	BGcY5ADnMXsuWuM3MnJoW3xxZg==
X-Google-Smtp-Source: ABdhPJz8wz4o41XHYhoLj4wL0iO+7TY5klugMAiuAHL6AwvSIkIjmpbxbZyHSrVFCWzcMthRAkHK+w==
X-Received: by 2002:a92:cda1:: with SMTP id g1mr14278288ild.267.1613426883146;
        Mon, 15 Feb 2021 14:08:03 -0800 (PST)
Return-Path: <rebecca@nuviainc.com>
Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57])
        by smtp.gmail.com with ESMTPSA id r12sm9984754ile.59.2021.02.15.14.08.02
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Mon, 15 Feb 2021 14:08:02 -0800 (PST)
Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Align include guards policy
To: devel@edk2.groups.io, pierre.gondois@arm.com, bob.c.feng@intel.com,
 gaoliming@byosoft.com.cn
Cc: sami.mujawar@arm.com
References: <20210125154525.18449-1-Pierre.Gondois@arm.com>
From: "Rebecca Cran" <rebecca@nuviainc.com>
Message-ID: <50128f55-dbdd-1884-77b3-ce27a560bad6@nuviainc.com>
Date: Mon, 15 Feb 2021 15:08:01 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <20210125154525.18449-1-Pierre.Gondois@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 1/25/21 8:45 AM, PierreGondois wrote:

> diff --git a/BaseTools/Source/Python/Ecc/Check.py b/BaseTools/Source/Python/Ecc/Check.py
> index 6087abfa4d8d..14759d21f5d8 100644
> --- a/BaseTools/Source/Python/Ecc/Check.py
> +++ b/BaseTools/Source/Python/Ecc/Check.py
> @@ -2,6 +2,7 @@
>   # This file is used to define checkpoints used by ECC tool
>   #
>   # Copyright (c) 2008 - 2020, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
>   # SPDX-License-Identifier: BSD-2-Clause-Patent

> diff --git a/BaseTools/Source/Python/Ecc/EccToolError.py b/BaseTools/Source/Python/Ecc/EccToolError.py
> index 0ff3b42674d4..58d0749477b2 100644
> --- a/BaseTools/Source/Python/Ecc/EccToolError.py
> +++ b/BaseTools/Source/Python/Ecc/EccToolError.py
> @@ -2,6 +2,7 @@
>   # Standardized Error Handling infrastructures.
>   #
>   # Copyright (c) 2008 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2021, Arm Limited. All rights reserved.<BR>
>   # SPDX-License-Identifier: BSD-2-Clause-Patent

I don't think this is in the coding standards, but newer copyright lines 
are generally placed above, not below, older ones.

-- 
Rebecca Cran