public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Jian J Wang <jian.j.wang@intel.com>
Cc: devel@edk2.groups.io, christopher.j.zurcher@intel.com,
	Xiaoyu Lu <xiaoyux.lu@intel.com>
Subject: Re: [edk2-devel] [PATCH v3 0/2] CryptoPkg/OpensslLib: Remove "no-autoalginit" flag from OpenSSL build
Date: Tue, 10 Mar 2020 11:52:11 +0100	[thread overview]
Message-ID: <5044f973-ff61-7e4a-889d-61b883a35eb9@redhat.com> (raw)
In-Reply-To: <20200214004021.17300-1-christopher.j.zurcher@intel.com>

Jian,

On 02/14/20 01:40, Zurcher, Christopher J wrote:
> In order to implement the EVP interface, the EVP_get_digestbyname function
> requires the desired digest to be already initialized. Removing the
> "no-autoalginit" build option will allow algorithms to be retrieved by name.
> I plan to submit a future patch with an EVP implementation; the OpenSSL
> documentation has stated that the EVP interface "should almost always be
> used" over direct digest interfaces at least as far back as version 0.9.6c.
> 
> This patch set also adds the "sort" keyword to the header file parsing loop
> so the .inf files aren't randomized after every run of process_files.pl.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> 
> Christopher J Zurcher (2):
>   CryptoPkg/OpensslLib: Add "sort" keyword to header file parsing loop
>   CryptoPkg/OpensslLib: Remove "no-autoalginit" flag from OpenSSL build
> 
>  CryptoPkg/Library/OpensslLib/OpensslLib.inf       | 66 ++++++++++----------
>  CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 62 +++++++++---------
>  CryptoPkg/Library/Include/openssl/opensslconf.h   |  3 -
>  CryptoPkg/Library/OpensslLib/process_files.pl     |  5 +-
>  4 files changed, 66 insertions(+), 70 deletions(-)
> 

please revert commit 6b7855209ad8e3e077a24faa40f69acdc231ff4f (merged
via your PR <https://github.com/tianocore/edk2/pull/433/>).

I have never given my R-b for the second patch in this series, only for
the first one.

Feel free to reapply the 2nd patch after the revert, but the re-applied
patch should *not* carry my R-b.

It's not that I "disagree" with patch#2 (if that had been the case, I
would have spoken up). I have no input on patch#2, instead.

Please pay more attention to review feedback.

Thanks
Laszlo


      parent reply	other threads:[~2020-03-10 10:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  0:40 [PATCH v3 0/2] CryptoPkg/OpensslLib: Remove "no-autoalginit" flag from OpenSSL build Zurcher, Christopher J
2020-02-14  0:40 ` [PATCH v3 1/2] CryptoPkg/OpensslLib: Add "sort" keyword to header file parsing loop Zurcher, Christopher J
2020-02-14 16:10   ` [edk2-devel] " Laszlo Ersek
2020-02-14  0:40 ` [PATCH v3 2/2] CryptoPkg/OpensslLib: Remove "no-autoalginit" flag from OpenSSL build Zurcher, Christopher J
2020-02-14  8:51 ` [edk2-devel] [PATCH v3 0/2] " Liming Gao
2020-02-22  4:28   ` Zurcher, Christopher J
2020-02-17  6:50 ` Wang, Jian J
2020-03-10 10:52 ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5044f973-ff61-7e4a-889d-61b883a35eb9@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox