From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.2854.1583837538261008370 for ; Tue, 10 Mar 2020 03:52:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QBbtFBlW; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583837537; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QELRez10EK61BLZMF5gNXmPJc6l+9YyA4Mtv7dPnDuw=; b=QBbtFBlWBxCUh5a7TpfulinyfPowPoOKRUsdhrtZ50oMhx+6cyhv4Jf3JqR9Y9m+RaEGhn 5cFupiQcqrhaZZVthIAV/d97IzfzDdMfeVIHV+N1ClmlJEQhubKzn314zJj+jJ4YVpiwpV g0NGb5O1fw0bVmd6P9T58qAX0Hks5l0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274--wQzjD45NXCeb4BRlxVUgg-1; Tue, 10 Mar 2020 06:52:14 -0400 X-MC-Unique: -wQzjD45NXCeb4BRlxVUgg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B54E8107ACC9; Tue, 10 Mar 2020 10:52:13 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-246.ams2.redhat.com [10.36.116.246]) by smtp.corp.redhat.com (Postfix) with ESMTP id BABA192982; Tue, 10 Mar 2020 10:52:12 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 0/2] CryptoPkg/OpensslLib: Remove "no-autoalginit" flag from OpenSSL build To: Jian J Wang Cc: devel@edk2.groups.io, christopher.j.zurcher@intel.com, Xiaoyu Lu References: <20200214004021.17300-1-christopher.j.zurcher@intel.com> From: "Laszlo Ersek" Message-ID: <5044f973-ff61-7e4a-889d-61b883a35eb9@redhat.com> Date: Tue, 10 Mar 2020 11:52:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200214004021.17300-1-christopher.j.zurcher@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Jian, On 02/14/20 01:40, Zurcher, Christopher J wrote: > In order to implement the EVP interface, the EVP_get_digestbyname function > requires the desired digest to be already initialized. Removing the > "no-autoalginit" build option will allow algorithms to be retrieved by name. > I plan to submit a future patch with an EVP implementation; the OpenSSL > documentation has stated that the EVP interface "should almost always be > used" over direct digest interfaces at least as far back as version 0.9.6c. > > This patch set also adds the "sort" keyword to the header file parsing loop > so the .inf files aren't randomized after every run of process_files.pl. > > Cc: Jian J Wang > Cc: Xiaoyu Lu > > Christopher J Zurcher (2): > CryptoPkg/OpensslLib: Add "sort" keyword to header file parsing loop > CryptoPkg/OpensslLib: Remove "no-autoalginit" flag from OpenSSL build > > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 66 ++++++++++---------- > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 62 +++++++++--------- > CryptoPkg/Library/Include/openssl/opensslconf.h | 3 - > CryptoPkg/Library/OpensslLib/process_files.pl | 5 +- > 4 files changed, 66 insertions(+), 70 deletions(-) > please revert commit 6b7855209ad8e3e077a24faa40f69acdc231ff4f (merged via your PR ). I have never given my R-b for the second patch in this series, only for the first one. Feel free to reapply the 2nd patch after the revert, but the re-applied patch should *not* carry my R-b. It's not that I "disagree" with patch#2 (if that had been the case, I would have spoken up). I have no input on patch#2, instead. Please pay more attention to review feedback. Thanks Laszlo