From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=ryszard.knop@linux.intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5798F211BFCA3 for ; Wed, 30 Jan 2019 03:48:14 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 03:48:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="295644785" Received: from linux.intel.com ([10.54.29.200]) by orsmga005.jf.intel.com with ESMTP; 30 Jan 2019 03:48:13 -0800 Received: from torii (torii.igk.intel.com [10.102.24.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 742D058042B; Wed, 30 Jan 2019 03:48:11 -0800 (PST) Message-ID: <5051dcf8857ea4ced2674a6f632c079fcd4e7905.camel@linux.intel.com> From: Ryszard Knop To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: kamil.kacperski@intel.com, eric.jin@intel.com, pawel.orlowski@intel.com, michael.d.kinney@intel.com, harry.l.hsiung@intel.com Date: Wed, 30 Jan 2019 12:48:09 +0100 In-Reply-To: <20181106175833.26964-8-ard.biesheuvel@linaro.org> References: <20181106175833.26964-1-ard.biesheuvel@linaro.org> <20181106175833.26964-8-ard.biesheuvel@linaro.org> Organization: Intel Corporation User-Agent: Evolution 3.30.4 Mime-Version: 1.0 Subject: Re: [PATCH edk2-staging 07/19] IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build options X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 11:48:14 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Just one note for this: We have separate defines for EFI32 (IA32), EFI64 (IPF) and EFIX64 (X64) to sprinkle some workarounds where needed. It seems ARM doesn't need that for now, but I'll add similar defines for it as well so that we have that available in the future. Reviewed-by: Ryszard Knop On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote: > Prefix the existing MSFT only build option overrides with MSFT: and > create the GCC: counterparts so we can build this code with GCC as > well. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > index 6c195872c00f..19dae9a0987a 100644 > --- a/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > +++ b/IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf > @@ -41,20 +41,20 @@ ENTRY_POINT = InitializeGigUNDIDriver > UNLOAD_IMAGE = GigUndiUnload > > [BuildOptions.common] > - > -*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG > + MSFT:*_*_*_CC_FLAGS = /FAcs /D MDEPKG_NDEBUG > + GCC:RELEASE_*_*_CC_FLAGS = -D MDEPKG_NDEBUG > > [BuildOptions.X64] > - > -*_*_*_CC_FLAGS = /D EFIX64 > + MSFT:*_*_*_CC_FLAGS = /D EFIX64 > + GCC:*_*_*_CC_FLAGS = -D EFIX64 > > [BuildOptions.IPF] > - > -*_*_*_CC_FLAGS = /D EFI64 > + MSFT:*_*_*_CC_FLAGS = /D EFI64 > + GCC:*_*_*_CC_FLAGS = -D EFI64 > > [BuildOptions.IA32] > - > -*_*_*_CC_FLAGS = /D EFI32 > + MSFT:*_*_*_CC_FLAGS = /D EFI32 > + GCC:*_*_*_CC_FLAGS = -D EFI32 > > [sources.common] > InventoryStrings.uni