From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 9B91D2194D38B
 for <edk2-devel@lists.01.org>; Wed, 26 Apr 2017 12:47:38 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 0FE313DBF5;
 Wed, 26 Apr 2017 19:47:38 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0FE313DBF5
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com;
 dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com;
 spf=pass smtp.mailfrom=lersek@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0FE313DBF5
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-72.phx2.redhat.com
 [10.3.116.72])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 148AF18695;
 Wed, 26 Apr 2017 19:47:36 +0000 (UTC)
To: Jeff Westfahl <jeff.westfahl@ni.com>
References: <1493228430-15322-1-git-send-email-jeff.westfahl@ni.com>
 <CB6E33457884FA40993F35157061515C54C0F8D9@FMSMSX103.amr.corp.intel.com>
 <7a8b3c50-10ed-8eb7-7653-f37a63430a01@redhat.com>
 <alpine.DEB.2.20.1704261436360.19449@jmw-lm181>
 <22d1ef65-2e54-944e-d842-bbe17251a43e@redhat.com>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>,
 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 "Ni, Ruiyu" <ruiyu.ni@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <5056a68c-2b17-41ff-c591-80c48c21e3bc@redhat.com>
Date: Wed, 26 Apr 2017 21:47:36 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <22d1ef65-2e54-944e-d842-bbe17251a43e@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.30]); Wed, 26 Apr 2017 19:47:38 +0000 (UTC)
Subject: Re: [PATCH] ShellPkg/ShellCommandLib: Update DumpHex to print {|}~
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Apr 2017 19:47:38 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 04/26/17 21:46, Laszlo Ersek wrote:
> On 04/26/17 21:37, Jeff Westfahl wrote:
>> Hi Laszlo,
>>
>> I liked your description so much that I copied it basically word for
>> word in my PATCH v2 commit description. Is there some way I can
>> attribute this to you in the commit description?
> 
> Sure! For example, add:

... since I've looked at the patch anyway, feel free to add my

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

as well.

Thanks!
Laszlo