From: "Marvin Häuser" <mhaeuser@posteo.de>
To: "Ni, Ray" <ray.ni@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"mcb30@ipxe.org" <mcb30@ipxe.org>
Cc: "Ma, Maurice" <maurice.ma@intel.com>,
"Dong, Guo" <guo.dong@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload
Date: Tue, 15 Jun 2021 17:31:26 +0000 [thread overview]
Message-ID: <50593faa-de78-defb-5e6e-c74a87b29ddd@posteo.de> (raw)
In-Reply-To: <CO1PR11MB4930FA6BAF20FC98CD4623678C309@CO1PR11MB4930.namprd11.prod.outlook.com>
Hey Ray,
Sure, thanks a lot for taking the time. I will need a bit longer to get
to it, sorry. :)
Best regards,
Marvin
On 15.06.21 16:36, Ni, Ray wrote:
> Marvin,
> I have sent out https://edk2.groups.io/g/devel/message/76429 <UefiPayloadPkg/PayloadLoader: Add more checks to verify ELF images> to address your feedbacks.
>
> Can I merge the 3 patches first? (we can continue discussing the more-checks patch.)
>
> Thanks,
> Ray
>
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
>> Sent: Thursday, June 10, 2021 7:37 PM
>> To: devel@edk2.groups.io; mcb30@ipxe.org; mhaeuser@posteo.de
>> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
>> Subject: Re: [edk2-devel] [PATCH v2 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload
>>
>>
>>
>>> -----Original Message-----
>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael Brown
>>> Sent: Thursday, June 10, 2021 6:43 PM
>>> To: devel@edk2.groups.io; mhaeuser@posteo.de; Ni, Ray <ray.ni@intel.com>
>>> Cc: Ma, Maurice <maurice.ma@intel.com>; Dong, Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
>>> Subject: Re: [edk2-devel] [PATCH v2 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload
>>>
>>> On 10/06/2021 11:13, Marvin Häuser wrote:
>>>> On 10.06.21 11:39, Ni, Ray wrote:
>>>>>> Maybe for some context, my main issue at first was that the checks are
>>>>>> all proper runtime checks with no ASSERTs at all, so I got confused how
>>>>>> this situation could happen in a realistic scenario. I needed to trace
>>>>>> the ParseStatus data flow to understand the idea is basically the same
>>>>>> as in the PE library. Code in a way is self-documenting, and this
>>>>>> personally gave me a hard time understanding why it is written this way.
>>>>>> But thanks for clarifying your intention! :)
>>>>> I assume you are ok with the ParseStatus.
>>>>> I will send new version based on mail discussion. Thanks!
>>>> I don't need to be okay with anything, I'm not a maintainer nor an
>>>> authority. But I gave my opinion, which is that it is dead code that
>>>> makes the design/flow harder to understand for a third party, at no
>>>> obvious benefit.
>>> FWIW, I strongly agree with Marvin on this: having ParseStatus in its
>>> current form is a bad idea since it adds no value but does incur a cost.
>> OK. I can remove that😊
>>
>>
>>
>>
>>
next prev parent reply other threads:[~2021-06-15 17:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 6:22 [PATCH v2 0/3] Add PayloadLoaderPeim which can load ELF payload Ni, Ray
2021-06-03 6:22 ` [PATCH v2 1/3] MdeModulePkg/UniversalPayload: Add definition for extra info in payload Ni, Ray
2021-06-03 6:37 ` [edk2-devel] " Wu, Hao A
2021-06-04 1:01 ` Ni, Ray
2021-06-04 1:02 ` Wu, Hao A
2021-06-07 9:07 ` Ni, Ray
2021-06-07 23:25 ` Wu, Hao A
2021-06-03 6:22 ` [PATCH v2 2/3] UefiPayloadPkg: Add PayloadLoaderPeim which can load ELF payload Ni, Ray
2021-06-07 1:47 ` Guo Dong
2021-06-07 21:53 ` [edk2-devel] " Marvin Häuser
2021-06-08 2:06 ` Ni, Ray
2021-06-08 3:10 ` Ni, Ray
2021-06-08 8:12 ` Marvin Häuser
2021-06-09 9:49 ` Ni, Ray
2021-06-09 10:03 ` Marvin Häuser
2021-06-10 3:40 ` Ni, Ray
2021-06-10 7:30 ` Marvin Häuser
2021-06-10 9:39 ` Ni, Ray
2021-06-10 10:13 ` Marvin Häuser
2021-06-10 10:43 ` Michael Brown
2021-06-10 11:37 ` Ni, Ray
[not found] ` <168735878F610E03.10233@groups.io>
2021-06-15 14:36 ` Ni, Ray
2021-06-15 17:31 ` Marvin Häuser [this message]
2021-06-03 6:22 ` [PATCH v2 3/3] PeiCore: Remove assertion when failing to load PE image Ni, Ray
2021-06-07 23:28 ` Wu, Hao A
2021-06-07 20:33 ` [edk2-devel] [PATCH v2 0/3] Add PayloadLoaderPeim which can load ELF payload Guo Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50593faa-de78-defb-5e6e-c74a87b29ddd@posteo.de \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox