From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web11.104.1662564808236751917
 for <devel@edk2.groups.io>;
 Wed, 07 Sep 2022 08:33:28 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=BjTAG5Qo;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.195.228.134])
	by linux.microsoft.com (Postfix) with ESMTPSA id 45703204A584;
	Wed,  7 Sep 2022 08:33:27 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 45703204A584
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1662564807;
	bh=BLCwK/FOmuMTSpbc559GPaSbhwQhjkzoKoh6w3q3hGA=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=BjTAG5QoPZ+pmv+bastyWE2TF4f7+wFhJEC7tKOPL7bhQRkAiiLuZMACazQCWWUki
	 7MLawMo7wYddHmfsdMBA63sMxByTNj8jPf2GISa1zjODeAvoxeWP5+xAaX1d0PjIDV
	 YcFKFBHKtxZu35v7OyD5LPeDVOQ+ifFKIiEZMwpA=
Message-ID: <506e16ac-5232-408f-b5c9-c9333a3a7daf@linux.microsoft.com>
Date: Wed, 7 Sep 2022 11:33:25 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH] ArmPkg, ArmVirtPkg: put SpellCheck in AuditOnly mode
To: Ard Biesheuvel <ardb@kernel.org>, devel@edk2.groups.io
Cc: quic_llindhol@quicinc.com
References: <20220907152712.1236460-1-ardb@kernel.org>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <20220907152712.1236460-1-ardb@kernel.org>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 9/7/2022 11:27 AM, Ard Biesheuvel wrote:
> Don't allow spelling errors to break the CI build and inadvertently
> reject pull requests - spelling is important but not that important.
> 
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>   ArmPkg/ArmPkg.ci.yaml         | 2 +-
>   ArmVirtPkg/ArmVirtPkg.ci.yaml | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ArmPkg/ArmPkg.ci.yaml b/ArmPkg/ArmPkg.ci.yaml
> index b7e07aaef675..24db74250513 100644
> --- a/ArmPkg/ArmPkg.ci.yaml
> +++ b/ArmPkg/ArmPkg.ci.yaml
> @@ -87,7 +87,7 @@
>   
> 
>       ## options defined .pytool/Plugin/SpellCheck
> 
>       "SpellCheck": {
> 
> -        "AuditOnly": False,
> 
> +        "AuditOnly": True,
> 
>           "IgnoreFiles": [
> 
>               "Library/ArmSoftFloatLib/berkeley-softfloat-3/**"
> 
>           ],                           # use gitignore syntax to ignore errors
> 
> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> index d5d63ddd4fd7..1e799dc4e194 100644
> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml
> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml
> @@ -96,7 +96,7 @@
>   
> 
>       ## options defined .pytool/Plugin/SpellCheck
> 
>       "SpellCheck": {
> 
> -        "AuditOnly": False,           # Fails right now with over 270 errors
> 
> +        "AuditOnly": True,
> 
>           "IgnoreFiles": [],           # use gitignore syntax to ignore errors in matching files
> 
>           "ExtendWords": [
> 
>               "acpiview",
>