From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web09.3586.1574687036041455242 for ; Mon, 25 Nov 2019 05:03:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IdHp57C8; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574687035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jEwI3iWsaXF7hVVBqa9FG0y2iuwdkzjau4u/EOOrOf4=; b=IdHp57C8YHqP5CZWIVUKR73Z1mUqzaz0M/Qq6Gcv4i0Br4pUH6VCPBxG695wwxDsDHVOnE MKzEl5kjhZFjKbULml11q9P23I1Hi0v56nOBq7HA7DR7MTIm4gF1cWRIiU6pMhxN8XXhf1 /TJmFTxUQN9Ykr/+jK7LIrf2z8zeLpM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-211-itzEQrJtMuKjpVfs_t1AQw-1; Mon, 25 Nov 2019 08:03:51 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4791C802C72; Mon, 25 Nov 2019 13:03:49 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-167.ams2.redhat.com [10.36.116.167]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4A1F910016DA; Mon, 25 Nov 2019 13:03:47 +0000 (UTC) Subject: Re: [PATCH v2 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 To: Sami Mujawar , "devel@edk2.groups.io" Cc: Achin Gupta , "jiewen.yao@intel.com" , Supreeth Venkatesh , Matteo Carlini , Laura Moretta , nd References: <20191125090604.2076-1-sami.mujawar@arm.com> From: "Laszlo Ersek" Message-ID: <50b01cb2-d30c-106f-3297-6f4f5c624f8a@redhat.com> Date: Mon, 25 Nov 2019 14:03:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: itzEQrJtMuKjpVfs_t1AQw-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 11/25/19 12:10, Sami Mujawar wrote: > Apologies, I missed #28 'Pick up the tags that you got on the list', from Laszlo's guide. > > This patch has also received a Reviewed-by from: > Reviewed-by: jiewen.yao@intel.com > Reviewed-by: Laszlo Ersek Right, I noticed, but I figured I wouldn't obsess about it. :) Thank you though! Laszlo > -----Original Message----- > From: Sami Mujawar > Sent: 25 November 2019 09:06 AM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; Achin Gupta ; jiewen.yao@intel.com; Supreeth Venkatesh ; lersek@redhat.com; Matteo Carlini ; Laura Moretta ; nd > Subject: [PATCH v2 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 > > The StandaloneMmPkg currently has code for supporting Arm architecture only. Support for X64 and IA32 is currently under development on a separate branch. > > However, StandaloneMmPkg/StandaloneMmPkg.dsc is indicating that support for X64 and IA32 is available which is causing build failures. > This has been reported in > https://bugzilla.tianocore.org/show_bug.cgi?id=2253 > > This issue has been discussed earlier on the list: > (1) https://edk2.groups.io/g/devel/message/47276 > > (2) https://edk2.groups.io/g/devel/message/47283 > > In light of the above, this patch removes IA32 and X64 from SUPPORTED_ARCHITECTURES, until support for the respective architectures is merged into StandaloneMmPkg. > > Cc: Achin Gupta > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > Cc: Laszlo Ersek > Signed-off-by: Sami Mujawar > > --- > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/697_stmm_disable_unsupported_arch_v1 > > Notes: > v2: > - Fixed patch check failure in commit message, [SAMI] > changed 'CC' to 'Cc'. No code change. > v1: > - Fix for Bug 2253 [SAMI] > (https://bugzilla.tianocore.org/show_bug.cgi?id=2253) > > StandaloneMmPkg/StandaloneMmPkg.dsc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/StandaloneMmPkg.dsc > index 8a68d397469bdb83586bfeaebedcd52fd528b20f..f9546e182e25fbcd253de0986a1bb554dae1e975 100644 > --- a/StandaloneMmPkg/StandaloneMmPkg.dsc > +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc > @@ -2,7 +2,7 @@ > # Standalone MM Platform. > # > # Copyright (c) 2015, Intel Corporation. All rights reserved.
-# Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
> +# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -19,7 +19,7 @@ [Defines] > PLATFORM_VERSION = 1.0 > DSC_SPECIFICATION = 0x00010011 > OUTPUT_DIRECTORY = Build/StandaloneMm > - SUPPORTED_ARCHITECTURES = IA32|X64|AARCH64 > + SUPPORTED_ARCHITECTURES = AARCH64 > BUILD_TARGETS = DEBUG|RELEASE > SKUID_IDENTIFIER = DEFAULT > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > >