Re: [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 2/27/19 10:21 PM, Laszlo Ersek wrote:
> The current language for "Package Reviewer" only vaguely hints that
> Package Reviewers should be able to provide guidance and directions.
> Make this more obvious.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daude <philmd@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     - this is clearly a political patch; feel free to disagree
>     - I'm proposing this for the next development cycle
> 
>  Maintainers.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7772926b2fb1..ed090aeb4bdb 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -20,7 +20,10 @@ Descriptions of section entries:
>    M: Package Maintainer: Cc address for patches and questions. Responsible
>       for reviewing and pushing package changes to source control.
>    R: Package Reviewer: Cc address for patches and questions. Reviewers help
> -     maintainers review code, but don't have push access.
> +     maintainers review code, but don't have push access. A designated Package
> +     Reviewer is reasonably familiar with the Package (or some modules
> +     thereof), and/or provides testing or regression testing for the Package
> +     (or some modules thereof), in certain platforms and environments.

Definitively an improvement, thanks for clarifying this.

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

>    W: Web-page with status/info
>    T: SCM tree type and location.  Type is one of: git, svn.
>    S: Status, one of the following:
>