[PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities

[PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities

[Laszlo Ersek]

The current language for "Package Reviewer" only vaguely hints that
Package Reviewers should be able to provide guidance and directions.
Make this more obvious.

Cc: Andrew Fish <afish@apple.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Philippe Mathieu-Daude <philmd@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---

Notes:
    - this is clearly a political patch; feel free to disagree
    - I'm proposing this for the next development cycle

 Maintainers.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index 7772926b2fb1..ed090aeb4bdb 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -20,7 +20,10 @@ Descriptions of section entries:
   M: Package Maintainer: Cc address for patches and questions. Responsible
      for reviewing and pushing package changes to source control.
   R: Package Reviewer: Cc address for patches and questions. Reviewers help
-     maintainers review code, but don't have push access.
+     maintainers review code, but don't have push access. A designated Package
+     Reviewer is reasonably familiar with the Package (or some modules
+     thereof), and/or provides testing or regression testing for the Package
+     (or some modules thereof), in certain platforms and environments.
   W: Web-page with status/info
   T: SCM tree type and location.  Type is one of: git, svn.
   S: Status, one of the following:
-- 
2.19.1.3.g30247aa5d201

Re: [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities

[Gao, Liming]

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>Laszlo Ersek
>Sent: Thursday, February 28, 2019 5:22 AM
>To: edk2-devel-01 <edk2-devel@lists.01.org>
>Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>
>Subject: [edk2] [PATCH] Maintainers.txt: clarify Reviewer requirements and
>responsibilities
>
>The current language for "Package Reviewer" only vaguely hints that
>Package Reviewers should be able to provide guidance and directions.
>Make this more obvious.
>
>Cc: Andrew Fish <afish@apple.com>
>Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>Cc: Leif Lindholm <leif.lindholm@linaro.org>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Philippe Mathieu-Daude <philmd@redhat.com>
>Contributed-under: TianoCore Contribution Agreement 1.1
>Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>---
>
>Notes:
>    - this is clearly a political patch; feel free to disagree
>    - I'm proposing this for the next development cycle
>
> Maintainers.txt | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/Maintainers.txt b/Maintainers.txt
>index 7772926b2fb1..ed090aeb4bdb 100644
>--- a/Maintainers.txt
>+++ b/Maintainers.txt
>@@ -20,7 +20,10 @@ Descriptions of section entries:
>   M: Package Maintainer: Cc address for patches and questions. Responsible
>      for reviewing and pushing package changes to source control.
>   R: Package Reviewer: Cc address for patches and questions. Reviewers help
>-     maintainers review code, but don't have push access.
>+     maintainers review code, but don't have push access. A designated
>Package
>+     Reviewer is reasonably familiar with the Package (or some modules
>+     thereof), and/or provides testing or regression testing for the Package
>+     (or some modules thereof), in certain platforms and environments.
>   W: Web-page with status/info
>   T: SCM tree type and location.  Type is one of: git, svn.
>   S: Status, one of the following:
>--
>2.19.1.3.g30247aa5d201
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities

[Andrew Fish]

Reviewed-by: Andrew Fish <afish@apple.com>

> On Feb 27, 2019, at 5:12 PM, Gao, Liming <liming.gao@intel.com> wrote:
> 
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> 
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
>> Laszlo Ersek
>> Sent: Thursday, February 28, 2019 5:22 AM
>> To: edk2-devel-01 <edk2-devel@lists.01.org>
>> Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
>> <michael.d.kinney@intel.com>
>> Subject: [edk2] [PATCH] Maintainers.txt: clarify Reviewer requirements and
>> responsibilities
>> 
>> The current language for "Package Reviewer" only vaguely hints that
>> Package Reviewers should be able to provide guidance and directions.
>> Make this more obvious.
>> 
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Philippe Mathieu-Daude <philmd@redhat.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> 
>> Notes:
>>   - this is clearly a political patch; feel free to disagree
>>   - I'm proposing this for the next development cycle
>> 
>> Maintainers.txt | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>> 
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index 7772926b2fb1..ed090aeb4bdb 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -20,7 +20,10 @@ Descriptions of section entries:
>>  M: Package Maintainer: Cc address for patches and questions. Responsible
>>     for reviewing and pushing package changes to source control.
>>  R: Package Reviewer: Cc address for patches and questions. Reviewers help
>> -     maintainers review code, but don't have push access.
>> +     maintainers review code, but don't have push access. A designated
>> Package
>> +     Reviewer is reasonably familiar with the Package (or some modules
>> +     thereof), and/or provides testing or regression testing for the Package
>> +     (or some modules thereof), in certain platforms and environments.
>>  W: Web-page with status/info
>>  T: SCM tree type and location.  Type is one of: git, svn.
>>  S: Status, one of the following:
>> --
>> 2.19.1.3.g30247aa5d201
>> 
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities

[Philippe Mathieu-Daudé]

On 2/27/19 10:21 PM, Laszlo Ersek wrote:
> The current language for "Package Reviewer" only vaguely hints that
> Package Reviewers should be able to provide guidance and directions.
> Make this more obvious.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daude <philmd@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     - this is clearly a political patch; feel free to disagree
>     - I'm proposing this for the next development cycle
> 
>  Maintainers.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7772926b2fb1..ed090aeb4bdb 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -20,7 +20,10 @@ Descriptions of section entries:
>    M: Package Maintainer: Cc address for patches and questions. Responsible
>       for reviewing and pushing package changes to source control.
>    R: Package Reviewer: Cc address for patches and questions. Reviewers help
> -     maintainers review code, but don't have push access.
> +     maintainers review code, but don't have push access. A designated Package
> +     Reviewer is reasonably familiar with the Package (or some modules
> +     thereof), and/or provides testing or regression testing for the Package
> +     (or some modules thereof), in certain platforms and environments.

Definitively an improvement, thanks for clarifying this.

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

>    W: Web-page with status/info
>    T: SCM tree type and location.  Type is one of: git, svn.
>    S: Status, one of the following:
> 

Re: [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities

[Laszlo Ersek]

On 02/27/19 22:21, Laszlo Ersek wrote:
> The current language for "Package Reviewer" only vaguely hints that
> Package Reviewers should be able to provide guidance and directions.
> Make this more obvious.
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daude <philmd@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     - this is clearly a political patch; feel free to disagree
>     - I'm proposing this for the next development cycle
> 
>  Maintainers.txt | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 7772926b2fb1..ed090aeb4bdb 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -20,7 +20,10 @@ Descriptions of section entries:
>    M: Package Maintainer: Cc address for patches and questions. Responsible
>       for reviewing and pushing package changes to source control.
>    R: Package Reviewer: Cc address for patches and questions. Reviewers help
> -     maintainers review code, but don't have push access.
> +     maintainers review code, but don't have push access. A designated Package
> +     Reviewer is reasonably familiar with the Package (or some modules
> +     thereof), and/or provides testing or regression testing for the Package
> +     (or some modules thereof), in certain platforms and environments.
>    W: Web-page with status/info
>    T: SCM tree type and location.  Type is one of: git, svn.
>    S: Status, one of the following:
> 

Thank you all for the feedback, this has been pushed as commit c9e1e28b6195.

Thanks,
Laszlo