From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.221.66; helo=mail-wr1-f66.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 65A5C208EB3E5 for ; Thu, 28 Feb 2019 02:41:11 -0800 (PST) Received: by mail-wr1-f66.google.com with SMTP id d17so21309421wre.10 for ; Thu, 28 Feb 2019 02:41:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lUfV13OGXSKA+XGw43FPjMjqekUSrcTiYPzlMY61Zoo=; b=JrfJJvsyISRB5y1h9cOY05lCrCmfFnAo+mv+w6FlLvhL/5dpsMTxuP9ql2f61LIhC4 de86orV/3zMH4NjiOGRPFEx2B5v6MtjTyCbvFRFmdJvla+kLT/nzJMXza0e3hO8wMpTo Z+ElU9ctZjfodiiLKXgx46gkJbLO2h9V3IgytEQU5exF/NaKNPlTs/n9somsEmrg3vkC HM846owI3G7LNRHbilciondlAksd8RFCVL5bFpe6QoFvBpcf8NAZKHDE50u1DrypWi5I EEh5b0yjY1TwyC12Fe5HT0+nXPZFZQLy3s740soXf6ewK2n1aL7ZCfJG0jCkZH/WwB0a Mp3g== X-Gm-Message-State: APjAAAXW3bP/ICCLExhVGukbdXk2DAxhQHb1GkcsFgrZ4KbLl+boI1Dv AY0Hg23o9ZoUriPgbCMszaWTCA== X-Google-Smtp-Source: APXvYqz2Pg0h/8E5v1CrQHmM4rfH6p3GVsnOgdNW3xnklZH30Sc42X9kUDQphTn9uLoKXCZUIbP7bQ== X-Received: by 2002:adf:ee01:: with SMTP id y1mr5614388wrn.268.1551350470262; Thu, 28 Feb 2019 02:41:10 -0800 (PST) Received: from [192.168.1.37] (43.red-88-25-181.staticip.rima-tde.net. [88.25.181.43]) by smtp.gmail.com with ESMTPSA id 132sm7609254wmd.30.2019.02.28.02.41.09 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 28 Feb 2019 02:41:09 -0800 (PST) To: Laszlo Ersek , edk2-devel-01 Cc: Andrew Fish , Ard Biesheuvel , Leif Lindholm , Liming Gao , Michael D Kinney References: <20190227212157.20107-1-lersek@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <50b68bd7-ba8b-e2a3-f653-7f54979fe1b4@redhat.com> Date: Thu, 28 Feb 2019 11:41:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190227212157.20107-1-lersek@redhat.com> Subject: Re: [PATCH] Maintainers.txt: clarify Reviewer requirements and responsibilities X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2019 10:41:12 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/27/19 10:21 PM, Laszlo Ersek wrote: > The current language for "Package Reviewer" only vaguely hints that > Package Reviewers should be able to provide guidance and directions. > Make this more obvious. > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daude > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > --- > > Notes: > - this is clearly a political patch; feel free to disagree > - I'm proposing this for the next development cycle > > Maintainers.txt | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 7772926b2fb1..ed090aeb4bdb 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -20,7 +20,10 @@ Descriptions of section entries: > M: Package Maintainer: Cc address for patches and questions. Responsible > for reviewing and pushing package changes to source control. > R: Package Reviewer: Cc address for patches and questions. Reviewers help > - maintainers review code, but don't have push access. > + maintainers review code, but don't have push access. A designated Package > + Reviewer is reasonably familiar with the Package (or some modules > + thereof), and/or provides testing or regression testing for the Package > + (or some modules thereof), in certain platforms and environments. Definitively an improvement, thanks for clarifying this. Reviewed-by: Philippe Mathieu-Daude > W: Web-page with status/info > T: SCM tree type and location. Type is one of: git, svn. > S: Status, one of the following: >