Re: Bug 843 - Need to remove unnecessary return statements in void functions of EDKII.

[Laszlo Ersek <lersek@redhat.com>]

Hello Younas,

On 06/11/18 09:17, Mohammad Younas Khan Pathan wrote:
> Hi all,
> 
> Please find the differences updated below, review and share your comments:

(1) Please submit the patch according to the edk2 development process.

https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process

In particular, please don't paste a diff into whatever email client you
use (e.g. gmail web interface); please use "git send-email" (or another
tool that can send out pristine patches that were generated with "git
format-patch").

(2) You need to add your Contributed-by and Signed-off-by lines at the
end of the commit message. Please refer to "Contributions.txt" in the
project root directory. In general, please write an appropriate commit
message.

(3) Please don't update copyright notices in source code that don't
belong to you (or to your employer). For example, you update Intel
copyright notices in several spots, but you don't seem to have an
@intel.com email address.

(4) Please split the patch to one patch per top-level directory. For
example, you should have a separate patch for OvmfPkg.

(5) Preferably, if the goal is to remove useless "return" statements,
don't remove or add unrelated empty lines; for example in
"OptionRomPkg/UndiRuntimeDxe/Init.c". It's OK to remove adjacent empty
lines that had been clearly added, originally, to separate the "return"
statements from the rest of the code.

I suggest that we work on the OvmfPkg patch at first, to get your
environment and workflow set up. Once the OvmfPkg patch looks good in
all areas, you can submit the rest of the patches the same way.

Thanks
Laszlo