From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0A01120359A90 for ; Wed, 22 Nov 2017 01:01:12 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B1231C04AC7C; Wed, 22 Nov 2017 09:05:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-45.rdu2.redhat.com [10.10.120.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9F8E660600; Wed, 22 Nov 2017 09:05:27 +0000 (UTC) To: "Zeng, Star" , "Wang, Jian J" Cc: "edk2-devel@lists.01.org" , "Yao, Jiewen" References: <20171121061725.11028-1-jian.j.wang@intel.com> <2e083f9d-4009-dd3e-c845-108f0c1eb24a@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B9BA58E@shsmsx102.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <50d15b34-cb80-95e2-e123-caa3b05526a5@redhat.com> Date: Wed, 22 Nov 2017 10:05:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B9BA58E@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 22 Nov 2017 09:05:28 +0000 (UTC) Subject: Re: [PATCH v7 0/2] Fix multiple entries of RT_CODE in memory map X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Nov 2017 09:01:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/22/17 08:56, Zeng, Star wrote: > How about we have the v6 patch series in first with the feedback from Jiewen (about comments) and you (about MemoryMapStart) addressed? > > Then we can have a separated patch for the merging. Good idea! Thanks! Laszlo > > > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek > Sent: Tuesday, November 21, 2017 9:38 PM > To: Wang, Jian J > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v7 0/2] Fix multiple entries of RT_CODE in memory map > > Jian, > > On 11/21/17 07:17, Jian J Wang wrote: >>> v7: >>> Merge memory map after filtering paging attributes >> >> More than one entry of RT_CODE memory might cause boot problem for >> some old OSs. This patch will fix this issue to keep OS compatibility >> as much as possible. >> >> Jian J Wang (2): >> MdeModulePkg/DxeCore: Filter out all paging capabilities >> UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map >> >> MdeModulePkg/Core/Dxe/DxeMain.h | 18 ++++++ >> MdeModulePkg/Core/Dxe/Mem/Page.c | 21 +++++++ >> MdeModulePkg/Core/Dxe/Misc/PropertiesTable.c | 1 - >> UefiCpuPkg/CpuDxe/CpuPageTable.c | 94 +++++++++++++++++++++------- >> 4 files changed, 112 insertions(+), 22 deletions(-) >> > > I don't have capacity to retest and re-review the series. > > Considering the following two options, I like none of them: > > (1) Version 7 is merged with my feedback tags from v6. I don't like this because I didn't review or test version 7. > > (2) Version 7 is merged without my feedback tags. I don't like this because I've put a lot of BZ writeup, and patch review and testing effort for this series, and I'd like the commit log to reflect that. > > > Instead, I would like to request the following, for v8: > > Please submit a series that consists of three patches: > > - patch v8 1/3: identical to v6 1/2, except for the code comment update, > - patch v8 2/3: identical to v6 2/2, > - patch v8 3/3: please implement the merging of the memory map as a separate patch. > > Patches v8 1/3 and 2/3 should include *both* my Tested-by *and* my Reviewed-by tags, from v6. > > Patch v8 3/3 should be reviewed / tested separately by others. I don't think I can find the capacity for that at the moment. > > This approach will correctly reflect all the work done thus far, and it will provide the desired result for the code as well. > > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >