From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) by mx.groups.io with SMTP id smtpd.web10.12484.1625245563432803040 for ; Fri, 02 Jul 2021 10:06:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@bsdio.com header.s=xmission header.b=BIZYquqj; spf=none, err=SPF record not found (domain: bsdio.com, ip: 166.70.13.231, mailfrom: rebecca@bsdio.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=bsdio.com; s=xmission; h=Subject:Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Sender:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=Y9UeiIHdDynUlUIvVKVR86UpNT3j+f8QT4v0z2lj2N4=; b=BIZYquqjS1UJejhSp0yfa/T/A0 zTETBxmb3jw72DWdkKQEpRlOA2KPrpKMF2z89EOXmkXO58pIN+8rOU6bz9Qr84okOCrMRUXQc8syC mDcjsfs7sXfCmevuDT36UNv6wzubc6zRzH+pyhtdaL8IrZfBk4l7GS7MjDElrE1uLIRQ=; Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lzMc1-00FxkW-Pe; Fri, 02 Jul 2021 11:05:57 -0600 Received: from mta5.zcs.xmission.com ([166.70.13.69]:48652) by in02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lzMc0-00E6UL-RL; Fri, 02 Jul 2021 11:05:57 -0600 Received: from localhost (localhost [127.0.0.1]) by mta5.zcs.xmission.com (Postfix) with ESMTP id 94787128159E; Fri, 2 Jul 2021 11:05:56 -0600 (MDT) X-Amavis-Modified: Mail body modified (using disclaimer) - mta5.zcs.xmission.com Received: from mta5.zcs.xmission.com ([127.0.0.1]) by localhost (mta5.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id v67de6vM0D2e; Fri, 2 Jul 2021 11:05:56 -0600 (MDT) Received: from photon.int.bsdio.com (c-174-52-16-57.hsd1.ut.comcast.net [174.52.16.57]) by mta5.zcs.xmission.com (Postfix) with ESMTPSA id 4F077128158B; Fri, 2 Jul 2021 11:05:56 -0600 (MDT) To: =?UTF-8?Q?Corvin_K=c3=b6hne?= , devel@edk2.groups.io Cc: p.bruenn@beckhoff.com, grehan@freebsd.org, lersek@redhat.com, ardb+tianocore@kernel.org, jordan.l.justen@intel.com References: <20210701120152.27482-1-c.koehne@beckhoff.com> <20210701120152.27482-2-c.koehne@beckhoff.com> From: "Rebecca Cran" Message-ID: <50ea0a43-fc7d-52e3-adb7-30a28e9f4480@bsdio.com> Date: Fri, 2 Jul 2021 11:05:55 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210701120152.27482-2-c.koehne@beckhoff.com> X-XM-SPF: eid=1lzMc0-00E6UL-RL;;;mid=<50ea0a43-fc7d-52e3-adb7-30a28e9f4480@bsdio.com>;;;hst=in02.mta.xmission.com;;;ip=166.70.13.69;;;frm=rebecca@bsdio.com;;;spf=none X-SA-Exim-Connect-IP: 166.70.13.69 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa04.xmission.com X-Spam-Level: X-Spam-Status: No, score=0.8 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,NICE_REPLY_A,T_TM2_M_HEADER_IN_MSG,TooManyTo_001, XMSubLong,XM_B_Unicode autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 0.3 TooManyTo_001 Multiple "To" Header Recipients 2x (uncommon) * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.0 XM_B_Unicode BODY: Testing for specific types of unicode * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa04 1397; IP=ok Body=1 Fuz1=1] [Fuz2=1] * -0.0 NICE_REPLY_A Looks like a legit reply (A) X-Spam-DCC: XMission; sa04 1397; IP=ok Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: =?ISO-8859-1?Q?;Corvin K=c3=b6hne , devel@edk2.groups.io?= X-Spam-Relay-Country: X-Spam-Timing: total 479 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 10 (2.2%), b_tie_ro: 9 (1.9%), parse: 1.13 (0.2%), extract_message_metadata: 12 (2.5%), get_uri_detail_list: 1.20 (0.3%), tests_pri_-1000: 4.0 (0.8%), tests_pri_-950: 1.15 (0.2%), tests_pri_-900: 0.95 (0.2%), tests_pri_-90: 54 (11.2%), check_bayes: 52 (10.9%), b_tokenize: 8 (1.6%), b_tok_get_all: 6 (1.3%), b_comp_prob: 2.00 (0.4%), b_tok_touch_all: 33 (6.9%), b_finish: 0.89 (0.2%), tests_pri_0: 379 (79.0%), check_dkim_signature: 0.71 (0.1%), check_dkim_adsp: 41 (8.5%), poll_dns_idle: 30 (6.2%), tests_pri_10: 4.1 (0.9%), tests_pri_500: 11 (2.2%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v3 2/2] OvmfPkg/Bhyve: use static PCI32Base address X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Acked-by: Rebecca Cran On 7/1/21 6:01 AM, Corvin Köhne wrote: > It's neccessary to allocate a Graphics Stolen Memory area to enable > GPU-Passthrough for integrated Intel GPUs. Therefore, use a new > memory layout with a static Pci32Baseaddress. > > Old layout: > [... , lowmemlimit] RAM > [lowmemlimit, 0xE000 0000] PCI Space > New layout: > [... , lowmemlimit] RAM > [lowmemlimit, gsmbase ] Memory hole (may be absent) > [gsmbase , 0xC000 0000] GSM (may be absent) > [0xC000 0000, 0xE000 0000] PCI Space > --- > OvmfPkg/Bhyve/BhyveX64.dsc | 4 ++-- > OvmfPkg/Bhyve/PlatformPei/Platform.c | 4 +++- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc > index a0a2071b86..c435dadc0a 100644 > --- a/OvmfPkg/Bhyve/BhyveX64.dsc > +++ b/OvmfPkg/Bhyve/BhyveX64.dsc > @@ -537,8 +537,8 @@ > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0 > gUefiOvmfPkgTokenSpaceGuid.PcdPciIoBase|0x0 > gUefiOvmfPkgTokenSpaceGuid.PcdPciIoSize|0x0 > - gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio32Base|0x0 > - gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio32Size|0x0 > + gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio32Base|0xC0000000 > + gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio32Size|0x20000000 > gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Base|0x0 > gUefiOvmfPkgTokenSpaceGuid.PcdPciMmio64Size|0x800000000 > > diff --git a/OvmfPkg/Bhyve/PlatformPei/Platform.c b/OvmfPkg/Bhyve/PlatformPei/Platform.c > index 3a414ffcb7..f38e74ccfc 100644 > --- a/OvmfPkg/Bhyve/PlatformPei/Platform.c > +++ b/OvmfPkg/Bhyve/PlatformPei/Platform.c > @@ -191,7 +191,9 @@ MemMapInitialization ( > ASSERT (PciExBarBase <= MAX_UINT32 - SIZE_256MB); > PciBase = (UINT32)(PciExBarBase + SIZE_256MB); > } else { > - PciBase = (TopOfLowRam < BASE_2GB) ? BASE_2GB : TopOfLowRam; > + PciBase = PcdGet64(PcdPciMmio32Base); > + if (PciBase == 0) > + PciBase = (TopOfLowRam < BASE_2GB) ? BASE_2GB : TopOfLowRam; > } > > //