From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65])
 by mx.groups.io with SMTP id smtpd.web09.3253.1663311077997637184
 for <devel@edk2.groups.io>;
 Thu, 15 Sep 2022 23:51:18 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@posteo.de header.s=2017 header.b=rh1fgY/P;
 spf=pass (domain: posteo.de, ip: 185.67.36.65, mailfrom: mhaeuser@posteo.de)
Received: from submission (posteo.de [185.67.36.169]) 
	by mout01.posteo.de (Postfix) with ESMTPS id 721B4240026
	for <devel@edk2.groups.io>; Fri, 16 Sep 2022 08:51:15 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017;
	t=1663311075; bh=J5yoQZzLhkJRbCM12bpPSFg75Lm58i8KPSaUPrENcsI=;
	h=From:Subject:Date:Cc:To:From;
	b=rh1fgY/P0MrvO+pYiJjykG9L00oWc6fgCxc+y5GjJF5dI9ingG3+PP5ADeJ3tvmHE
	 tac8+OZnEXhXQ39IIdF9J3wStJKUWXRXaBym7USna458h3dJx8kYCew6Et22StJHDA
	 wgZoXloVTFeM9hQFY1yiAaSV8MgpeugGuA9aOWu53c1RUkoaLQHK0kB1nS3IwUVU9u
	 RgvWbtCYNjSnrY1eW0NuNkmex19Jf4s8qP37L/KJuhvl83GKlMqcJrKfZt8wbbTylv
	 QeII5SFEomCBorTDY25VZ9NAjfkr2WNfo+GuuH/UCURwI+jgKW1tkeo06HeJmTeUBq
	 JXG9u/6kfrJoQ==
Received: from customer (localhost [127.0.0.1])
	by submission (posteo.de) with ESMTPSA id 4MTPqQ2NfPz6tn8;
	Fri, 16 Sep 2022 08:51:14 +0200 (CEST)
From: =?utf-8?Q?Marvin_H=C3=A4user?= <mhaeuser@posteo.de>
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds
Date: Fri, 16 Sep 2022 06:51:13 +0000
Message-Id: <51187D88-0566-4E97-892D-FB705D6A24BA@posteo.de>
References: <20220915230609.228037-1-pedro.falcato@gmail.com>
Cc: devel@edk2.groups.io, Rebecca Cran <rebecca@quicinc.com>
In-Reply-To: <20220915230609.228037-1-pedro.falcato@gmail.com>
To: Pedro Falcato <pedro.falcato@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Marvin H=C3=A4user <mhaeuser@posteo.de>

> On 16. Sep 2022, at 01:06, Pedro Falcato <pedro.falcato@gmail.com> wrote:
>=20
> =EF=BB=BFAs reported by Rebecca Cran, there was some build breakage when
> compiling with stack-protector-on-by-default toolchains. Adding the
> proper library to the DSC should fix it.
>=20
> Cc: Rebecca Cran <rebecca@quicinc.com>
> Cc: Marvin H=C3=A4user <mhaeuser@posteo.de>
> Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
> Features/Ext4Pkg/Ext4Pkg.dsc | 5 +++++
> 1 file changed, 5 insertions(+)
>=20
> diff --git a/Features/Ext4Pkg/Ext4Pkg.dsc b/Features/Ext4Pkg/Ext4Pkg.dsc
> index 57f279a4d918..59bc327ebf6e 100644
> --- a/Features/Ext4Pkg/Ext4Pkg.dsc
> +++ b/Features/Ext4Pkg/Ext4Pkg.dsc
> @@ -46,6 +46,11 @@
>   DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
>   OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib=
/BaseOrderedCollectionRedBlackTreeLib.inf
>   BaseUcs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
> + =20
> +  #
> +  # Required for stack protector support
> +  #
> +  NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>=20
> ##########################################################################=
#########################
> #
> --=20
> 2.37.3
>=20