From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 49A45740048 for ; Tue, 16 Jan 2024 15:29:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qHmCNjYw3AG9owJTLS43aWMBgepCGqZDfzBHyWzucX4=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705418952; v=1; b=rNt91nFxYIBfOHjQaCSB6oFAwoi27r85N5dGtr0xlj7D2uaKo224nY3pOYgbdVPOfyIMy6WG mgB9jo2XSTYu+Tr2PfQTmn/2sMK5ZFAKme/7oJlxPYlZJY6in2tMZHgLz7eynawYvmJXQimU+Oe 9eeUNbbd9yOHj2HMFPFdsqnc= X-Received: by 127.0.0.2 with SMTP id asvJYY7687511xcInOHLKjOj; Tue, 16 Jan 2024 07:29:12 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.17859.1705418952375333548 for ; Tue, 16 Jan 2024 07:29:12 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-6Gv3xaHnP4SQpl08cQaRtw-1; Tue, 16 Jan 2024 10:29:10 -0500 X-MC-Unique: 6Gv3xaHnP4SQpl08cQaRtw-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C78CA891068 for ; Tue, 16 Jan 2024 15:29:09 +0000 (UTC) X-Received: from [10.39.193.181] (unknown [10.39.193.181]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36E86C15A0C; Tue, 16 Jan 2024 15:29:09 +0000 (UTC) Message-ID: <511b50db-6dca-8ce7-b83f-74273c380732@redhat.com> Date: Tue, 16 Jan 2024 16:29:07 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 6/6] OvmfPkg/VirtNorFlashDxe: move DoErase code block into new function From: "Laszlo Ersek" To: devel@edk2.groups.io, kraxel@redhat.com Cc: oliver@redhat.com References: <20240115155948.136499-1-kraxel@redhat.com> <20240115155948.136499-7-kraxel@redhat.com> <4c9e81d6-59ca-ace0-0670-59a3e2ec507b@redhat.com> In-Reply-To: <4c9e81d6-59ca-ace0-0670-59a3e2ec507b@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8wGMOvcPEtmE6qjLR8XewGThx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=rNt91nFx; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/16/24 14:44, Laszlo Ersek wrote: > On 1/15/24 16:59, Gerd Hoffmann wrote: >> Move the DoErase code block into a separate function, call the function >> instead of jumping around with goto. >> >> Signed-off-by: Gerd Hoffmann >> --- >> OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 76 +++++++++++++++++--------- >> 1 file changed, 51 insertions(+), 25 deletions(-) >> >> diff --git a/OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c b/OvmfPkg/VirtNorFla= shDxe/VirtNorFlash.c >> index d80e9f0a2f3a..203bd64f2bdf 100644 >> --- a/OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c >> +++ b/OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c >> @@ -502,6 +502,37 @@ NorFlashRead ( >> return EFI_SUCCESS; >> } >> >> +STATIC EFI_STATUS >=20 > (1) EFI_STATUS is not needed (and if it were needed, then we'd put it on > a separate line) >=20 >> +NorFlashWriteSingleBlockWithErase ( >> + IN NOR_FLASH_INSTANCE *Instance, >> + IN EFI_LBA Lba, >> + IN UINTN Offset, >> + IN OUT UINTN *NumBytes, >> + IN UINT8 *Buffer >> + ) >> +{ Sigh. In your patch, I mistook / misread "EFI_STATUS" for "EFIAPI". :/ So, please ignore this; we obviously need the EFI_STATUS return type. ... Perhaps consider breaking "EFI_STATUS" to its own line. (Strange how the brain works; my "mental alarm" about having typed something foolish went off approx. 90 minutes after hitting Send -- while I was running outside. I know that some people get the best programming ideas while showering...) Sorry! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113909): https://edk2.groups.io/g/devel/message/113909 Mute This Topic: https://groups.io/mt/103741665/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-