From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c09::22b; helo=mail-wm0-x22b.google.com; envelope-from=julien.grall@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DF2C721A1099D for ; Mon, 27 Nov 2017 02:34:50 -0800 (PST) Received: by mail-wm0-x22b.google.com with SMTP id r68so33940972wmr.1 for ; Mon, 27 Nov 2017 02:39:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HFx4nKCGE8otm4VMwtOtx52jjq1q4Hcluz1ow26pju8=; b=hDSKUoH0ssF4xlFgaLqaChFXWJRL6K/6ldPjzfWo5x7Ni2g476C6UVDaAoVTGRmfvu dg9u356NG0BcTYT/8XgOxvskvtD2IkPebGbt0WO9ybvI7a19ycdQR1REVm8E3ed2y/iN 9+5BgdQjh5UHK36BTUgj1s1n8oEYWUp8sgZWw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HFx4nKCGE8otm4VMwtOtx52jjq1q4Hcluz1ow26pju8=; b=e82XfVFNJsKu8uYHcOiQTKnuqtKNP3uJcCHf012QHQa2pAbWuxU3bU2YFEr6QClarM pgxeOcSkRLSd7i6vKbYrfowbavgLUbsZ8dV2/SRrytllThAEmlY8be4yKPJTbUE0+aLU SfXCWekqo7cqYojRpEuV1bkZ08G/bkQ7smEBBSVcXXeVgOeqU0oPRoQGxNxLiR7AFDxf RXK4c5VJlxosVL0fGKhZP/1M3G6OfNs4Psmsk7W0Qcc2Go4DmAQDpvkvmNA2RkuzoiW+ xudllE/qthkTAz8xmR7qqDEA+sDa6XWpKudP7KZuyXfi8HlDR5JvoV+LPEkK6n0mlYAk JBgg== X-Gm-Message-State: AJaThX4r6V0i+42+M6pB6vOO8OQLTKGJCEK+R8f+7vhVA2bjkljSEbMg nbCon2D2AEEa+BGU+xhU9inkeQ== X-Google-Smtp-Source: AGs4zMb/JShW1jst0uG3K0UQzQeNx3kq3wexUrSpznfMDUHaUvC5aZxbM9owqpeesGNburmfuc2+Mw== X-Received: by 10.28.65.65 with SMTP id o62mr15060703wma.112.1511779150811; Mon, 27 Nov 2017 02:39:10 -0800 (PST) Received: from ?IPv6:::1? ([2001:41d0:1:6c23::1]) by smtp.gmail.com with ESMTPSA id l16sm37533815wma.19.2017.11.27.02.39.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Nov 2017 02:39:10 -0800 (PST) To: "Zeng, Star" , "Dong, Eric" , "pankaj.bansal@nxp.com" , "lersek@redhat.com" , "leif.lindholm@linaro.org" Cc: "edk2-devel@lists.01.org" , "Ni, Ruiyu" References: <20171124162030.31156-1-julien.grall@linaro.org> <0C09AFA07DD0434D9E2A0C6AEB0483103B9BC152@shsmsx102.ccr.corp.intel.com> From: Julien Grall Message-ID: <51308cb0-ae00-4c66-a259-a11fcc98fcec@linaro.org> Date: Mon, 27 Nov 2017 10:39:09 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B9BC152@shsmsx102.ccr.corp.intel.com> Subject: Re: [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2017 10:34:51 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Star, On 27/11/17 01:46, Zeng, Star wrote: > Reviewed-by: Star Zeng with some minor comments in the separated patches. Thank you for the review. I will resend the series with updating the description in the corresponding headers. Would you mind if I keep you reviewed-by? Regards, > > Thanks, > Star > -----Original Message----- > From: Julien Grall [mailto:julien.grall@linaro.org] > Sent: Saturday, November 25, 2017 12:20 AM > To: Zeng, Star ; Dong, Eric ; pankaj.bansal@nxp.com; lersek@redhat.com; leif.lindholm@linaro.org > Cc: edk2-devel@lists.01.org; Julien Grall > Subject: [PATCH v2 0/3] MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not supported > > Hi all, > > This is another attempt to fix the console issue when using UEFI in Xen guest. > This new series is based on Laszlo suggestions on the previous version (see [1]). > > Cheers, > > [1] https://lists.01.org/pipermail/edk2-devel/2017-October/016181.html > > > Julien Grall (3): > MdeModulePkg/SerialDxe: Describe correctly EFI_DEVICE_ERROR for > SetAttributes > MdeModulePkg/SerialDxe: Fix return valued in SerialSetAttributes > MdeModulePkg/SerialDxe: Do not fail reset when SetAttributes is not > supported > > MdeModulePkg/Universal/SerialDxe/SerialIo.c | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > -- > 2.11.0 > -- Julien Grall