From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A83F721AE30DB for ; Tue, 25 Sep 2018 03:24:08 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 250A330014C9; Tue, 25 Sep 2018 10:24:08 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-71.rdu2.redhat.com [10.10.120.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 106C25C21D; Tue, 25 Sep 2018 10:24:06 +0000 (UTC) To: Jiaxin Wu , edk2-devel@lists.01.org Cc: Ye Ting , Fu Siyuan References: <20180925034445.14896-1-Jiaxin.wu@intel.com> <20180925034445.14896-4-Jiaxin.wu@intel.com> From: Laszlo Ersek Message-ID: <513aceae-e2fd-7158-20ea-ceecb0708fae@redhat.com> Date: Tue, 25 Sep 2018 12:24:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180925034445.14896-4-Jiaxin.wu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 25 Sep 2018 10:24:08 +0000 (UTC) Subject: Re: [Patch 3/6] MdeModulePkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe in NetworkPkg. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 10:24:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/25/18 05:44, Jiaxin Wu wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 > > This patch is to add the driver usage/difference clarification > compared to UefiPxeBcDxe in NetworkPkg. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin > --- > .../Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > index b5b9e80710..0fef0058bd 100644 > --- a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > +++ b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > @@ -2,11 +2,20 @@ > # This module produces EFI Preboot Execution Environment (PXE) Base Code Protocol. > # > # This module produces EFI PXE Base Code Protocol upon EFI MMP Protocl and IPv4 > # network stack, used to control PXE-compatible devices. It produces EFI Load File > # Protocol to provide one clean way to otain control from the boot manager if the > -# boot patch is from the remote device. > +# boot patch is from the remote device. This driver only supports IPv4 network stack. > +# > +# Notes: > +# 1) This driver can't co-work with the UefiPxeBcDxe driver in NetworkPkg. > +# 2) This driver might have some issues that have been fixed in the UefiPxeBcDxe > +# driver in NetworkPkg. > +# 3) This driver supports less feature than the UefiPxeBcDxe driver in NetworkPkg > +# (e.g. IPv6, MTFTP windowsize). > +# 4) UefiPxeBcDxe driver in NetworkPkg is recommanded to use instead of this one even > +# both of them can be used. > # > # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
> # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > # which accompanies this distribution. The full text of the license may be found at > Same comments as for patch #1. With those addressed: Reviewed-by: Laszlo Ersek Thanks, Laszlo