[Patch 0/6] Add the clarification for TCP/ISCSI/PXE drivers.

[Patch 0/6] Add the clarification for TCP/ISCSI/PXE drivers.

[Jiaxin Wu]

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205

The series patches describe the difference against the overlapped network 
drivers between NetworkPkg and MdeModulePkg (ISCSI/TCP/PXE drivers - 
Tcp4Dxe VS TcpDxe, IScsiDxe VS IScsiDxe,  UefiPxeBcDxe VS UefiPxeBcDxe).

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>

Jiaxin Wu (6):
  MdeModulePkg/Tcp4Dxe: Add the clarification compared to TcpDxe in
    NetworkPkg.
  MdeModulePkg/IScsiDxe: Add the clarification compared to IScsiDxe in
    NetworkPkg.
  MdeModulePkg/UefiPxeBcDxe: Add the clarification compared to
    UefiPxeBcDxe in NetworkPkg.
  NetworkPkg/TcpDxe: Add the clarification compared to Tcp4Dxe in
    MdeModulePkg.
  NetworkPkg/IScsiDxe: Add the clarification compared to IScsiDxe in
    MdeModulePkg.
  NetworkPkg/UefiPxeBcDxe: Add the clarification compared to
    UefiPxeBcDxe in MdeModulePkg.

 MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf | 12 +++++++++++-
 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf   | 12 +++++++++++-
 .../Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf  | 11 ++++++++++-
 NetworkPkg/IScsiDxe/IScsiDxe.inf                     | 12 +++++++++++-
 NetworkPkg/TcpDxe/TcpDxe.inf                         |  9 +++++++--
 NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf             |  9 +++++++--
 6 files changed, 57 insertions(+), 8 deletions(-)

-- 
2.17.1.windows.2

[Patch 1/6] MdeModulePkg/Tcp4Dxe: Add the clarification compared to TcpDxe in NetworkPkg.

[Jiaxin Wu]

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205

This patch is to add the driver usage/difference clarification
compared to TcpDxe in NetworkPkg.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
index b54321caaa..0561eb7421 100644
--- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
+++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
@@ -1,10 +1,20 @@
 ## @file
 #  This module produces EFI TCPv4 Protocol and EFI TCPv4 Service Binding Protocol.
 #
 #  This module produces EFI TCPv4(Transmission Control Protocol version 4) Protocol
-#  upon EFI IPv4 Protocol, to provide basic TCPv4 I/O services.
+#  upon EFI IPv4 Protocol, to provide basic TCPv4 I/O services. This driver only 
+#  supports IPv4 network stack.
+#
+#  Notes: 
+#  1) This driver can't co-work with the TcpDxe driver in NetworkPkg. 
+#  2) This driver might have some issues that have been fixed in the TcpDxe driver 
+#     in NetworkPkg. 
+#  3) This driver supports less feature than the TcpDxe driver in NetworkPkg (e.g. IPv6, 
+#     TCP Cancel function). 
+#  4) TcpDxe driver in NetworkPkg is recommanded to use instead of this one even both 
+#     of them can be used.
 #
 #  Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD License
 #  which accompanies this distribution. The full text of the license may be found at
-- 
2.17.1.windows.2

Re: [Patch 1/6] MdeModulePkg/Tcp4Dxe: Add the clarification compared to TcpDxe in NetworkPkg.

[Laszlo Ersek]

On 09/25/18 05:44, Jiaxin Wu wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205
> 
> This patch is to add the driver usage/difference clarification
> compared to TcpDxe in NetworkPkg.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> index b54321caaa..0561eb7421 100644
> --- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> +++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> @@ -1,10 +1,20 @@
>  ## @file
>  #  This module produces EFI TCPv4 Protocol and EFI TCPv4 Service Binding Protocol.
>  #
>  #  This module produces EFI TCPv4(Transmission Control Protocol version 4) Protocol
> -#  upon EFI IPv4 Protocol, to provide basic TCPv4 I/O services.
> +#  upon EFI IPv4 Protocol, to provide basic TCPv4 I/O services. This driver only 
> +#  supports IPv4 network stack.
> +#
> +#  Notes: 
> +#  1) This driver can't co-work with the TcpDxe driver in NetworkPkg. 
> +#  2) This driver might have some issues that have been fixed in the TcpDxe driver 
> +#     in NetworkPkg. 
> +#  3) This driver supports less feature than the TcpDxe driver in NetworkPkg (e.g. IPv6, 
> +#     TCP Cancel function). 

I suggest replacing "less feature" with "fewer features".

Looks good to me, otherwise.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo

> +#  4) TcpDxe driver in NetworkPkg is recommanded to use instead of this one even both 
> +#     of them can be used.
>  #
>  #  Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>  #  This program and the accompanying materials
>  #  are licensed and made available under the terms and conditions of the BSD License
>  #  which accompanies this distribution. The full text of the license may be found at
> 

Re: [Patch 1/6] MdeModulePkg/Tcp4Dxe: Add the clarification compared to TcpDxe in NetworkPkg.

[Laszlo Ersek]

On 09/25/18 05:44, Jiaxin Wu wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205
> 
> This patch is to add the driver usage/difference clarification
> compared to TcpDxe in NetworkPkg.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> index b54321caaa..0561eb7421 100644
> --- a/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> +++ b/MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf
> @@ -1,10 +1,20 @@
>  ## @file
>  #  This module produces EFI TCPv4 Protocol and EFI TCPv4 Service Binding Protocol.
>  #
>  #  This module produces EFI TCPv4(Transmission Control Protocol version 4) Protocol
> -#  upon EFI IPv4 Protocol, to provide basic TCPv4 I/O services.
> +#  upon EFI IPv4 Protocol, to provide basic TCPv4 I/O services. This driver only 
> +#  supports IPv4 network stack.
> +#
> +#  Notes: 
> +#  1) This driver can't co-work with the TcpDxe driver in NetworkPkg. 
> +#  2) This driver might have some issues that have been fixed in the TcpDxe driver 
> +#     in NetworkPkg. 
> +#  3) This driver supports less feature than the TcpDxe driver in NetworkPkg (e.g. IPv6, 
> +#     TCP Cancel function). 
> +#  4) TcpDxe driver in NetworkPkg is recommanded to use instead of this one even both 
> +#     of them can be used.

Sorry, a few more suggestions:

- "recommanded to use" --> "recommended for use" (both typo fix and
grammar fix)

- "even" --> "even though".

Anyway I don't think it's necessary to repost the patch just because of
this.

Thanks!
Laszlo



>  #
>  #  Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
>  #  This program and the accompanying materials
>  #  are licensed and made available under the terms and conditions of the BSD License
>  #  which accompanies this distribution. The full text of the license may be found at
> 

[Patch 2/6] MdeModulePkg/IScsiDxe: Add the clarification compared to IScsiDxe in NetworkPkg.

[Jiaxin Wu]

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205

This patch is to add the driver usage/difference clarification
compared to IScsiDxe in NetworkPkg.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
index c3b8c7d15a..cd6a2ef843 100644
--- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
+++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
@@ -2,11 +2,21 @@
 #  This module produces EFI iSCSI Initiator Name Protocol.
 #
 #  This module produces EFI iSCSI Initiator Name Protocol upon EFI TCPv4 Protocol
 #  and EFI DHCPv4 Protocol, to provide the capability to do the transport for SCSI
 #  data over TCP/IP. It installs EFI HII Configuration Access Protocol to provide
-#  one way to configurate the iSCSI setting.
+#  one way to configurate the iSCSI setting. This driver only supports IPv4 network 
+#  stack.
+#
+#  Notes: 
+#  1) This driver can't co-work with the IScsiDxe driver in NetworkPkg. 
+#  2) This driver might have some issues that have been fixed in the IScsiDxe driver 
+#     in NetworkPkg.
+#  3) This driver supports less feature than the IScsiDxe driver in NetworkPkg 
+#     (e.g. IPv6, Dns support for target URL configuration, iSCSI keyword support).
+#  4) IScsiDxe driver in NetworkPkg is recommanded to use instead of this one even 
+#     both of them can be used.
 #
 #  Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD License
 #  which accompanies this distribution.  The full text of the license may be found at
-- 
2.17.1.windows.2

Re: [Patch 2/6] MdeModulePkg/IScsiDxe: Add the clarification compared to IScsiDxe in NetworkPkg.

[Laszlo Ersek]

On 09/25/18 05:44, Jiaxin Wu wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205
> 
> This patch is to add the driver usage/difference clarification
> compared to IScsiDxe in NetworkPkg.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
> index c3b8c7d15a..cd6a2ef843 100644
> --- a/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
> +++ b/MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf
> @@ -2,11 +2,21 @@
>  #  This module produces EFI iSCSI Initiator Name Protocol.
>  #
>  #  This module produces EFI iSCSI Initiator Name Protocol upon EFI TCPv4 Protocol
>  #  and EFI DHCPv4 Protocol, to provide the capability to do the transport for SCSI
>  #  data over TCP/IP. It installs EFI HII Configuration Access Protocol to provide
> -#  one way to configurate the iSCSI setting.
> +#  one way to configurate the iSCSI setting. This driver only supports IPv4 network 
> +#  stack.
> +#
> +#  Notes: 
> +#  1) This driver can't co-work with the IScsiDxe driver in NetworkPkg. 
> +#  2) This driver might have some issues that have been fixed in the IScsiDxe driver 
> +#     in NetworkPkg.
> +#  3) This driver supports less feature than the IScsiDxe driver in NetworkPkg 
> +#     (e.g. IPv6, Dns support for target URL configuration, iSCSI keyword support).
> +#  4) IScsiDxe driver in NetworkPkg is recommanded to use instead of this one even 
> +#     both of them can be used.
>  #
>  #  Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
>  #  This program and the accompanying materials
>  #  are licensed and made available under the terms and conditions of the BSD License
>  #  which accompanies this distribution.  The full text of the license may be found at
> 

Same comments as for patch #1. With those addressed:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo

[Patch 3/6] MdeModulePkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe in NetworkPkg.

[Jiaxin Wu]

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205

This patch is to add the driver usage/difference clarification
compared to UefiPxeBcDxe in NetworkPkg.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 .../Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf   | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
index b5b9e80710..0fef0058bd 100644
--- a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
+++ b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
@@ -2,11 +2,20 @@
 #  This module produces EFI Preboot Execution Environment (PXE) Base Code Protocol.
 #
 #  This module produces EFI PXE Base Code Protocol upon EFI MMP Protocl and IPv4
 #  network stack, used to control PXE-compatible devices. It produces EFI Load File
 #  Protocol to provide one clean way to otain control from the boot manager if the
-#  boot patch is from the remote device.
+#  boot patch is from the remote device. This driver only supports IPv4 network stack.
+#
+#  Notes: 
+#  1) This driver can't co-work with the UefiPxeBcDxe driver in NetworkPkg. 
+#  2) This driver might have some issues that have been fixed in the UefiPxeBcDxe 
+#     driver in NetworkPkg. 
+#  3) This driver supports less feature than the UefiPxeBcDxe driver in NetworkPkg 
+#     (e.g. IPv6, MTFTP windowsize).
+#  4) UefiPxeBcDxe driver in NetworkPkg is recommanded to use instead of this one even 
+#     both of them can be used.
 #
 #  Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD License
 #  which accompanies this distribution. The full text of the license may be found at
-- 
2.17.1.windows.2

Re: [Patch 3/6] MdeModulePkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe in NetworkPkg.

[Laszlo Ersek]

On 09/25/18 05:44, Jiaxin Wu wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205
> 
> This patch is to add the driver usage/difference clarification
> compared to UefiPxeBcDxe in NetworkPkg.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  .../Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf   | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
> index b5b9e80710..0fef0058bd 100644
> --- a/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
> +++ b/MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf
> @@ -2,11 +2,20 @@
>  #  This module produces EFI Preboot Execution Environment (PXE) Base Code Protocol.
>  #
>  #  This module produces EFI PXE Base Code Protocol upon EFI MMP Protocl and IPv4
>  #  network stack, used to control PXE-compatible devices. It produces EFI Load File
>  #  Protocol to provide one clean way to otain control from the boot manager if the
> -#  boot patch is from the remote device.
> +#  boot patch is from the remote device. This driver only supports IPv4 network stack.
> +#
> +#  Notes: 
> +#  1) This driver can't co-work with the UefiPxeBcDxe driver in NetworkPkg. 
> +#  2) This driver might have some issues that have been fixed in the UefiPxeBcDxe 
> +#     driver in NetworkPkg. 
> +#  3) This driver supports less feature than the UefiPxeBcDxe driver in NetworkPkg 
> +#     (e.g. IPv6, MTFTP windowsize).
> +#  4) UefiPxeBcDxe driver in NetworkPkg is recommanded to use instead of this one even 
> +#     both of them can be used.
>  #
>  #  Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
>  #  This program and the accompanying materials
>  #  are licensed and made available under the terms and conditions of the BSD License
>  #  which accompanies this distribution. The full text of the license may be found at
> 

Same comments as for patch #1. With those addressed:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo

[Patch 4/6] NetworkPkg/TcpDxe: Add the clarification compared to Tcp4Dxe in MdeModulePkg.

[Jiaxin Wu]

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205

This patch is to add the driver usage/difference clarification
compared to Tcp4Dxe in MdeModulePkg.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 NetworkPkg/TcpDxe/TcpDxe.inf | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/NetworkPkg/TcpDxe/TcpDxe.inf b/NetworkPkg/TcpDxe/TcpDxe.inf
index eb693a147f..56cfd16b98 100644
--- a/NetworkPkg/TcpDxe/TcpDxe.inf
+++ b/NetworkPkg/TcpDxe/TcpDxe.inf
@@ -1,12 +1,17 @@
 ## @file
 #  TCPv4 I/O and TCPv6 I/O services.
 #
 #  This module provides EFI TCPv4 Protocol and EFI TCPv6 Protocol to send and receive data stream.
-#  It might provide TCPv4 Protocol or TCPv6 Protocol or both of them that depends on
-#  which network stack has been loaded in system.
+#  It might provide TCPv4 Protocol or TCPv6 Protocol or both of them that depends on which network 
+#  stack has been loaded in system. This driver supports both IPv4 and IPv6 network stack.
 #
+#  Notes: 
+#  1) This driver can't co-work with the Tcp4Dxe driver in MdeModulePkg. 
+#  2) This driver includes more bugs fix and supports more features (e.g. IPv6, TCP Cancel 
+#     function) than the Tcp4Dxe driver in MdeModulePkg. So, we recommand to use this driver 
+#     even both of them can be used.
 #
 #  Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
 #
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD License
-- 
2.17.1.windows.2

Re: [Patch 4/6] NetworkPkg/TcpDxe: Add the clarification compared to Tcp4Dxe in MdeModulePkg.

[Laszlo Ersek]

On 09/25/18 05:44, Jiaxin Wu wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205
> 
> This patch is to add the driver usage/difference clarification
> compared to Tcp4Dxe in MdeModulePkg.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  NetworkPkg/TcpDxe/TcpDxe.inf | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/NetworkPkg/TcpDxe/TcpDxe.inf b/NetworkPkg/TcpDxe/TcpDxe.inf
> index eb693a147f..56cfd16b98 100644
> --- a/NetworkPkg/TcpDxe/TcpDxe.inf
> +++ b/NetworkPkg/TcpDxe/TcpDxe.inf
> @@ -1,12 +1,17 @@
>  ## @file
>  #  TCPv4 I/O and TCPv6 I/O services.
>  #
>  #  This module provides EFI TCPv4 Protocol and EFI TCPv6 Protocol to send and receive data stream.
> -#  It might provide TCPv4 Protocol or TCPv6 Protocol or both of them that depends on
> -#  which network stack has been loaded in system.
> +#  It might provide TCPv4 Protocol or TCPv6 Protocol or both of them that depends on which network 
> +#  stack has been loaded in system. This driver supports both IPv4 and IPv6 network stack.
>  #
> +#  Notes: 
> +#  1) This driver can't co-work with the Tcp4Dxe driver in MdeModulePkg. 
> +#  2) This driver includes more bugs fix and supports more features (e.g. IPv6, TCP Cancel 

suggestion: "bugs fix" --> "bug fixes"

> +#     function) than the Tcp4Dxe driver in MdeModulePkg. So, we recommand to use this driver 

suggestion: "recommand to use" --> "recommend using"

> +#     even both of them can be used.

"even" --> "even though"

With those:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo

>  #
>  #  Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
>  #
>  #  This program and the accompanying materials
>  #  are licensed and made available under the terms and conditions of the BSD License
> 

[Patch 5/6] NetworkPkg/IScsiDxe: Add the clarification compared to IScsiDxe in MdeModulePkg.

[Jiaxin Wu]

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205

This patch is to add the driver usage/difference clarification
compared to IScsiDxe in MdeModulePkg.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 NetworkPkg/IScsiDxe/IScsiDxe.inf | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/NetworkPkg/IScsiDxe/IScsiDxe.inf b/NetworkPkg/IScsiDxe/IScsiDxe.inf
index 61a0693a07..007418fd9c 100644
--- a/NetworkPkg/IScsiDxe/IScsiDxe.inf
+++ b/NetworkPkg/IScsiDxe/IScsiDxe.inf
@@ -1,10 +1,20 @@
 ## @file
 #  Client-side iSCSI service.
 #
 #  The iSCSI driver provides iSCSI service in the preboot environment and supports
-#  booting over iSCSI.
+#  booting over iSCSI. This driver supports both IPv4 and IPv6 network stack.
+#
+#  Notes: 
+#  1) This driver can't co-work with the IScsiDxe driver in MdeModulePkg. 
+#  2) This driver includes more bugs fix and supports more features (e.g. IPv6, Dns 
+#     support for target URL configuration, iSCSI keyword support) than the IscsiDxe 
+#     driver in MdeModulePkg. So, we recommand to use this driver even both of them 
+#     can be used.
+#  3) This driver depends on the OpenSSL building. To use this driver, please follow 
+#     the instructions found in the file "Patch-HOWTO.txt" located in 
+#     CryptoPkg\Library\OpensslLib to enable the OpenSSL building first.
 #
 # Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
 # This program and the accompanying materials
 # are licensed and made available under the terms and conditions of the BSD License
 # which accompanies this distribution.  The full text of the license may be found at
-- 
2.17.1.windows.2

Re: [Patch 5/6] NetworkPkg/IScsiDxe: Add the clarification compared to IScsiDxe in MdeModulePkg.

[Laszlo Ersek]

On 09/25/18 05:44, Jiaxin Wu wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205
> 
> This patch is to add the driver usage/difference clarification
> compared to IScsiDxe in MdeModulePkg.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  NetworkPkg/IScsiDxe/IScsiDxe.inf | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/NetworkPkg/IScsiDxe/IScsiDxe.inf b/NetworkPkg/IScsiDxe/IScsiDxe.inf
> index 61a0693a07..007418fd9c 100644
> --- a/NetworkPkg/IScsiDxe/IScsiDxe.inf
> +++ b/NetworkPkg/IScsiDxe/IScsiDxe.inf
> @@ -1,10 +1,20 @@
>  ## @file
>  #  Client-side iSCSI service.
>  #
>  #  The iSCSI driver provides iSCSI service in the preboot environment and supports
> -#  booting over iSCSI.
> +#  booting over iSCSI. This driver supports both IPv4 and IPv6 network stack.
> +#
> +#  Notes: 
> +#  1) This driver can't co-work with the IScsiDxe driver in MdeModulePkg. 
> +#  2) This driver includes more bugs fix and supports more features (e.g. IPv6, Dns 
> +#     support for target URL configuration, iSCSI keyword support) than the IscsiDxe 
> +#     driver in MdeModulePkg. So, we recommand to use this driver even both of them 
> +#     can be used.

Same comments as for patch #4.

> +#  3) This driver depends on the OpenSSL building. To use this driver, please follow 

I suggest "on the OpenSSL building" --> "on OpenSSL".

> +#     the instructions found in the file "Patch-HOWTO.txt" located in 
> +#     CryptoPkg\Library\OpensslLib to enable the OpenSSL building first.

The "Patch-HOWTO.txt" file no longer exists; it's now called
"OpenSSL-HOWTO.txt".

With those fixed:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo

>  #
>  # Copyright (c) 2004 - 2018, Intel Corporation. All rights reserved.<BR>
>  # This program and the accompanying materials
>  # are licensed and made available under the terms and conditions of the BSD License
>  # which accompanies this distribution.  The full text of the license may be found at
> 

[Patch 6/6] NetworkPkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe in MdeModulePkg.

[Jiaxin Wu]

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205

This patch is to add the driver usage/difference clarification
compared to UefiPxeBcDxe in MdeModulePkg.

Cc: Ye Ting <ting.ye@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
---
 NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
index e2a0eb44b1..f2ec34df93 100644
--- a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
+++ b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
@@ -1,12 +1,17 @@
 ## @file
 #  Access PXE-compatible devices for network access and network booting.
 #
 #  This driver provides PXE Base Code Protocol which is used to accessing
-#  PXE-compatible device for network access or booting. It could work together
-#  with an IPv4 stack, an IPv6 stack or both.
+#  PXE-compatible device for network access or booting. This driver supports 
+#  both IPv4 and IPv6 network stack.
 #
+#  Notes: 
+#  1) This driver can't co-work with the UefiPxeBcDxe driver in MdeModulePkg. 
+#  2) This driver includes more bugs fix and supports more features (e.g. IPv6, 
+#     MTFTP windowsize) than the UefiPxeBcDxe driver in MdeModulePkg. So, we 
+#     recommand to use this driver even both of them can be used.
 #
 #  Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
 #
 #  This program and the accompanying materials
 #  are licensed and made available under the terms and conditions of the BSD License
-- 
2.17.1.windows.2

Re: [Patch 6/6] NetworkPkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe in MdeModulePkg.

[Laszlo Ersek]

On 09/25/18 05:44, Jiaxin Wu wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205
> 
> This patch is to add the driver usage/difference clarification
> compared to UefiPxeBcDxe in MdeModulePkg.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> index e2a0eb44b1..f2ec34df93 100644
> --- a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> +++ b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> @@ -1,12 +1,17 @@
>  ## @file
>  #  Access PXE-compatible devices for network access and network booting.
>  #
>  #  This driver provides PXE Base Code Protocol which is used to accessing
> -#  PXE-compatible device for network access or booting. It could work together
> -#  with an IPv4 stack, an IPv6 stack or both.
> +#  PXE-compatible device for network access or booting. This driver supports 
> +#  both IPv4 and IPv6 network stack.
>  #
> +#  Notes: 
> +#  1) This driver can't co-work with the UefiPxeBcDxe driver in MdeModulePkg. 
> +#  2) This driver includes more bugs fix and supports more features (e.g. IPv6, 
> +#     MTFTP windowsize) than the UefiPxeBcDxe driver in MdeModulePkg. So, we 
> +#     recommand to use this driver even both of them can be used.
>  #
>  #  Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
>  #
>  #  This program and the accompanying materials
>  #  are licensed and made available under the terms and conditions of the BSD License
> 

Same comments as for patch #4. With those updates:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo

Re: [Patch 6/6] NetworkPkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe in MdeModulePkg.

[Wu, Jiaxin]

Thanks the correction, I will refine all the patches according your comments before committing the patches. 

Best Regards!
Jiaxin


> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Tuesday, September 25, 2018 6:31 PM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: Re: [Patch 6/6] NetworkPkg/UefiPxeBcDxe: Add the clarification
> compared to UefiPxeBcDxe in MdeModulePkg.
> 
> On 09/25/18 05:44, Jiaxin Wu wrote:
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205
> >
> > This patch is to add the driver usage/difference clarification
> > compared to UefiPxeBcDxe in MdeModulePkg.
> >
> > Cc: Ye Ting <ting.ye@intel.com>
> > Cc: Fu Siyuan <siyuan.fu@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > ---
> >  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > index e2a0eb44b1..f2ec34df93 100644
> > --- a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > +++ b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> > @@ -1,12 +1,17 @@
> >  ## @file
> >  #  Access PXE-compatible devices for network access and network booting.
> >  #
> >  #  This driver provides PXE Base Code Protocol which is used to accessing
> > -#  PXE-compatible device for network access or booting. It could work
> together
> > -#  with an IPv4 stack, an IPv6 stack or both.
> > +#  PXE-compatible device for network access or booting. This driver
> supports
> > +#  both IPv4 and IPv6 network stack.
> >  #
> > +#  Notes:
> > +#  1) This driver can't co-work with the UefiPxeBcDxe driver in
> MdeModulePkg.
> > +#  2) This driver includes more bugs fix and supports more features (e.g.
> IPv6,
> > +#     MTFTP windowsize) than the UefiPxeBcDxe driver in MdeModulePkg.
> So, we
> > +#     recommand to use this driver even both of them can be used.
> >  #
> >  #  Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
> >  #
> >  #  This program and the accompanying materials
> >  #  are licensed and made available under the terms and conditions of the
> BSD License
> >
> 
> Same comments as for patch #4. With those updates:
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks,
> Laszlo