From: "PierreGondois" <pierre.gondois@arm.com>
To: PierreGondois <pierre.gondois@arm.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Align include guards policy
Date: Mon, 25 Jan 2021 07:56:46 -0800 [thread overview]
Message-ID: <5141.1611590206926051567@groups.io> (raw)
In-Reply-To: <20210125154525.18449-1-Pierre.Gondois@arm.com>
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
Please consider that currently, a vast majority of include guards have one or two leading underscore (such as __INCLUDE_FILE_H_) and are not respecting the edk2 coding standard. This patch will raise many Ecc errors in the CI. They should however not break it. Indeed, the Ecc errors should only reject a patch if it modifies a line having an Ecc error. This means that:
- merging this patch should not break all the CI jobs
- modifying a header file that has a bad include guard will make the CI prevent the patch from being merged
- any newly created header file will trigger the new check and ask for a correction
- any modification of a bad include guard will trigger the new check and ask for a correction
Regards,
Pierre
[-- Attachment #2: Type: text/html, Size: 764 bytes --]
next prev parent reply other threads:[~2021-01-25 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 15:45 [PATCH v1 1/1] BaseTools: Align include guards policy PierreGondois
2021-01-25 15:56 ` PierreGondois [this message]
2021-01-26 1:22 ` 回复: " gaoliming
2021-01-26 11:07 ` [edk2-devel] " Leif Lindholm
2021-02-03 22:31 ` PierreGondois
2021-02-04 7:27 ` 回复: " gaoliming
2021-02-04 10:16 ` Sami Mujawar
2021-02-15 22:03 ` [edk2-devel] 回复: " PierreGondois
2021-02-18 5:42 ` 回复: " gaoliming
2021-02-04 10:22 ` Sami Mujawar
2021-02-15 22:08 ` [edk2-devel] " Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5141.1611590206926051567@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox