From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Align include guards policy
To: PierreGondois <pierre.gondois@arm.com>,devel@edk2.groups.io
From: "PierreGondois" <pierre.gondois@arm.com>
X-Originating-Location: Cambridge, England, GB (81.156.200.233)
X-Originating-Platform: Linux Firefox 84
User-Agent: GROUPS.IO Web Poster
MIME-Version: 1.0
Date: Mon, 25 Jan 2021 07:56:46 -0800
References: <20210125154525.18449-1-Pierre.Gondois@arm.com>
In-Reply-To: <20210125154525.18449-1-Pierre.Gondois@arm.com>
Message-ID: <5141.1611590206926051567@groups.io>
Content-Type: multipart/alternative; boundary="xxc3oYmNQ8wisVb5MlY7"

--xxc3oYmNQ8wisVb5MlY7
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Please consider that currently, a vast majority of include guards have one =
or two leading underscore (such as __INCLUDE_FILE_H_) and are not respectin=
g the edk2 coding standard. This patch will raise many Ecc errors in the CI=
. They should however not break it. Indeed, the Ecc errors should only reje=
ct a patch if it modifies a line having an Ecc error. This means that:
- merging this patch should not break all the CI jobs
- modifying a header file that has a bad include guard will make the CI pr=
event the patch from being merged
- any newly created header file will trigger the new check and ask for a c=
orrection
- any modification of a bad include guard will trigger the new check and a=
sk for a correction

Regards,
Pierre

--xxc3oYmNQ8wisVb5MlY7
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Please consider that currently, a vast majority of include guards have one =
or two leading underscore (such as __INCLUDE_FILE_H_) and are not respectin=
g the edk2 coding standard. This patch will raise many Ecc errors in the CI=
. They should however not break it. Indeed, the Ecc errors should only reje=
ct a patch if it modifies a line having an Ecc error. This means that:<br /=
>- merging this patch should not break all the CI jobs<br />- modifying a h=
eader file that has a bad include guard will make the CI prevent the patch =
from being merged<br />- any newly created header file will trigger the new=
 check and ask for a correction<br />- any modification of a bad include gu=
ard will trigger the new check and ask for a correction<br /><br />Regards,=
<br />Pierre

--xxc3oYmNQ8wisVb5MlY7--