Re: [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt

["Rebecca Cran" <rebecca@bsdio.com>]

Reviewed-by: Rebecca Cran <rebecca@bsdio.com>


It would be nice if we could pass all paths through pathlib 
(https://medium.com/@ageitgey/python-3-quick-tip-the-easy-way-to-deal-with-file-paths-on-windows-mac-and-linux-11a072b58d5f) 
but that's clearly a longer-term project.


-- 

Rebecca Cran


On 5/5/23 20:46, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4448
>
> Update tools_def.txt to add quotes around the file target in
> OBJCOPY_ADDDEBUGFLAGS for compatibility with GCC like tool
> chains used on Windows.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   BaseTools/Conf/tools_def.template | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index 1b3a9e7a540a..535dda1d5d99 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -731,9 +731,9 @@ NOOPT_VS2019_AARCH64_DLINK_FLAGS   = /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
>   *_*_*_OBJCOPY_FLAGS             = objcopy not needed for
>   *_*_*_SYMRENAME_PATH            = echo
>   *_*_*_SYMRENAME_FLAGS           = Symbol renaming not needed for
> -DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG     = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> +DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG     = --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
>   RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG   =
> -NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG     = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> +NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG     = --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
>   *_*_*_OBJCOPY_STRIPFLAG            = --strip-unneeded -R .eh_frame
>   *_*_*_DTC_FLAGS                    = -H epapr
>   *_*_*_DTCPP_PATH                   = DEF(DTCPP_BIN)