* [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt
@ 2023-05-06 2:46 Michael D Kinney
2023-05-06 3:01 ` 回复: [edk2-devel] " gaoliming
2023-05-06 9:40 ` Rebecca Cran
0 siblings, 2 replies; 6+ messages in thread
From: Michael D Kinney @ 2023-05-06 2:46 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran, Liming Gao, Bob Feng, Yuwei Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4448
Update tools_def.txt to add quotes around the file target in
OBJCOPY_ADDDEBUGFLAGS for compatibility with GCC like tool
chains used on Windows.
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
BaseTools/Conf/tools_def.template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
index 1b3a9e7a540a..535dda1d5d99 100755
--- a/BaseTools/Conf/tools_def.template
+++ b/BaseTools/Conf/tools_def.template
@@ -731,9 +731,9 @@ NOOPT_VS2019_AARCH64_DLINK_FLAGS = /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
*_*_*_OBJCOPY_FLAGS = objcopy not needed for
*_*_*_SYMRENAME_PATH = echo
*_*_*_SYMRENAME_FLAGS = Symbol renaming not needed for
-DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
+DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG =
-NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
+NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
*_*_*_OBJCOPY_STRIPFLAG = --strip-unneeded -R .eh_frame
*_*_*_DTC_FLAGS = -H epapr
*_*_*_DTCPP_PATH = DEF(DTCPP_BIN)
--
2.40.1.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* 回复: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt
2023-05-06 2:46 [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt Michael D Kinney
@ 2023-05-06 3:01 ` gaoliming
2023-05-06 4:55 ` Michael D Kinney
2023-05-06 9:40 ` Rebecca Cran
1 sibling, 1 reply; 6+ messages in thread
From: gaoliming @ 2023-05-06 3:01 UTC (permalink / raw)
To: devel, michael.d.kinney
Cc: 'Rebecca Cran', 'Bob Feng', 'Yuwei Chen'
Mike:
Do you mean $(DEBUG_DIR)/$(MODULE_NAME).debug file path may have space on
windows OS? Does the workspace directory include the space?
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D
> Kinney
> 发送时间: 2023年5月6日 10:47
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran <rebecca@bsdio.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Bob Feng <bob.c.feng@intel.com>; Yuwei Chen
> <yuwei.chen@intel.com>
> 主题: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> ADDDEBUGFLAG in tools_def.txt
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4448
>
> Update tools_def.txt to add quotes around the file target in
> OBJCOPY_ADDDEBUGFLAGS for compatibility with GCC like tool
> chains used on Windows.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> BaseTools/Conf/tools_def.template | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> index 1b3a9e7a540a..535dda1d5d99 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -731,9 +731,9 @@ NOOPT_VS2019_AARCH64_DLINK_FLAGS =
> /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
> *_*_*_OBJCOPY_FLAGS = objcopy not needed for
> *_*_*_SYMRENAME_PATH = echo
> *_*_*_SYMRENAME_FLAGS = Symbol renaming not needed for
> -DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG =
> --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> +DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG =
> --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
> RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG =
> -NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG =
> --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> +NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG =
> --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
> *_*_*_OBJCOPY_STRIPFLAG = --strip-unneeded -R .eh_frame
> *_*_*_DTC_FLAGS = -H epapr
> *_*_*_DTCPP_PATH = DEF(DTCPP_BIN)
> --
> 2.40.1.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt
2023-05-06 3:01 ` 回复: [edk2-devel] " gaoliming
@ 2023-05-06 4:55 ` Michael D Kinney
2023-05-06 5:39 ` 回复: " gaoliming
0 siblings, 1 reply; 6+ messages in thread
From: Michael D Kinney @ 2023-05-06 4:55 UTC (permalink / raw)
To: Gao, Liming, devel@edk2.groups.io
Cc: 'Rebecca Cran', Feng, Bob C, Chen, Christine,
Kinney, Michael D
The issue I saw was a mix of / and \ in the file path. On Windows $(DEBUG_DIR) would
Have '\' in path and then a '/' before $(MODULE_NAME). Without the quotes, this
would generate an error. With quotes, it would get the full filename correct.
On Linux, only '/' are used for the whole path and everything works with and
Without quotes.
Mike
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Friday, May 5, 2023 8:01 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: 'Rebecca Cran' <rebecca@bsdio.com>; Feng, Bob C
> <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>
> Subject: 回复: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> ADDDEBUGFLAG in tools_def.txt
>
> Mike:
> Do you mean $(DEBUG_DIR)/$(MODULE_NAME).debug file path may have
> space on
> windows OS? Does the workspace directory include the space?
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael D
> > Kinney
> > 发送时间: 2023年5月6日 10:47
> > 收件人: devel@edk2.groups.io
> > 抄送: Rebecca Cran <rebecca@bsdio.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Bob Feng <bob.c.feng@intel.com>; Yuwei
> Chen
> > <yuwei.chen@intel.com>
> > 主题: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> > ADDDEBUGFLAG in tools_def.txt
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4448
> >
> > Update tools_def.txt to add quotes around the file target in
> > OBJCOPY_ADDDEBUGFLAGS for compatibility with GCC like tool
> > chains used on Windows.
> >
> > Cc: Rebecca Cran <rebecca@bsdio.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> > BaseTools/Conf/tools_def.template | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/BaseTools/Conf/tools_def.template
> > b/BaseTools/Conf/tools_def.template
> > index 1b3a9e7a540a..535dda1d5d99 100755
> > --- a/BaseTools/Conf/tools_def.template
> > +++ b/BaseTools/Conf/tools_def.template
> > @@ -731,9 +731,9 @@ NOOPT_VS2019_AARCH64_DLINK_FLAGS =
> > /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
> > *_*_*_OBJCOPY_FLAGS = objcopy not needed for
> > *_*_*_SYMRENAME_PATH = echo
> > *_*_*_SYMRENAME_FLAGS = Symbol renaming not needed for
> > -DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG =
> > --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> > +DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG =
> > --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
> > RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG =
> > -NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG =
> > --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> > +NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG =
> > --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
> > *_*_*_OBJCOPY_STRIPFLAG = --strip-unneeded -R .eh_frame
> > *_*_*_DTC_FLAGS = -H epapr
> > *_*_*_DTCPP_PATH = DEF(DTCPP_BIN)
> > --
> > 2.40.1.windows.1
> >
> >
> >
> >
> >
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* 回复: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt
2023-05-06 4:55 ` Michael D Kinney
@ 2023-05-06 5:39 ` gaoliming
2023-05-06 16:28 ` Michael D Kinney
0 siblings, 1 reply; 6+ messages in thread
From: gaoliming @ 2023-05-06 5:39 UTC (permalink / raw)
To: 'Kinney, Michael D', devel
Cc: 'Rebecca Cran', 'Feng, Bob C',
'Chen, Christine'
Mike:
I also see GCC_DLINK2_FLAGS_COMMON option uses / as the file path. Does it bring the same problem in Windows OS?
DEFINE GCC_DLINK2_FLAGS_COMMON = -Wl,--script=$(EDK_TOOLS_PATH)/Scripts/GccBase.lds
Thanks
Liming
> -----邮件原件-----
> 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> 发送时间: 2023年5月6日 12:55
> 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: 'Rebecca Cran' <rebecca@bsdio.com>; Feng, Bob C
> <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> 主题: RE: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> ADDDEBUGFLAG in tools_def.txt
>
> The issue I saw was a mix of / and \ in the file path. On Windows
> $(DEBUG_DIR) would
> Have '\' in path and then a '/' before $(MODULE_NAME). Without the
> quotes, this
> would generate an error. With quotes, it would get the full filename correct.
>
> On Linux, only '/' are used for the whole path and everything works with and
> Without quotes.
>
> Mike
>
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Friday, May 5, 2023 8:01 PM
> > To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> > Cc: 'Rebecca Cran' <rebecca@bsdio.com>; Feng, Bob C
> > <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>
> > Subject: 回复: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> > ADDDEBUGFLAG in tools_def.txt
> >
> > Mike:
> > Do you mean $(DEBUG_DIR)/$(MODULE_NAME).debug file path may
> have
> > space on
> > windows OS? Does the workspace directory include the space?
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael
> D
> > > Kinney
> > > 发送时间: 2023年5月6日 10:47
> > > 收件人: devel@edk2.groups.io
> > > 抄送: Rebecca Cran <rebecca@bsdio.com>; Liming Gao
> > > <gaoliming@byosoft.com.cn>; Bob Feng <bob.c.feng@intel.com>; Yuwei
> > Chen
> > > <yuwei.chen@intel.com>
> > > 主题: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> > > ADDDEBUGFLAG in tools_def.txt
> > >
> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4448
> > >
> > > Update tools_def.txt to add quotes around the file target in
> > > OBJCOPY_ADDDEBUGFLAGS for compatibility with GCC like tool
> > > chains used on Windows.
> > >
> > > Cc: Rebecca Cran <rebecca@bsdio.com>
> > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > Cc: Bob Feng <bob.c.feng@intel.com>
> > > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> > > ---
> > > BaseTools/Conf/tools_def.template | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/BaseTools/Conf/tools_def.template
> > > b/BaseTools/Conf/tools_def.template
> > > index 1b3a9e7a540a..535dda1d5d99 100755
> > > --- a/BaseTools/Conf/tools_def.template
> > > +++ b/BaseTools/Conf/tools_def.template
> > > @@ -731,9 +731,9 @@ NOOPT_VS2019_AARCH64_DLINK_FLAGS =
> > > /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
> > > *_*_*_OBJCOPY_FLAGS = objcopy not needed for
> > > *_*_*_SYMRENAME_PATH = echo
> > > *_*_*_SYMRENAME_FLAGS = Symbol renaming not
> needed for
> > > -DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG =
> > > --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> > > +DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG =
> > > --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
> > > RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG =
> > > -NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG =
> > > --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> > > +NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG =
> > > --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
> > > *_*_*_OBJCOPY_STRIPFLAG = --strip-unneeded
> -R .eh_frame
> > > *_*_*_DTC_FLAGS = -H epapr
> > > *_*_*_DTCPP_PATH = DEF(DTCPP_BIN)
> > > --
> > > 2.40.1.windows.1
> > >
> > >
> > >
> > >
> > >
> >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt
2023-05-06 2:46 [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt Michael D Kinney
2023-05-06 3:01 ` 回复: [edk2-devel] " gaoliming
@ 2023-05-06 9:40 ` Rebecca Cran
1 sibling, 0 replies; 6+ messages in thread
From: Rebecca Cran @ 2023-05-06 9:40 UTC (permalink / raw)
To: Michael D Kinney, devel; +Cc: Liming Gao, Bob Feng, Yuwei Chen
Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
It would be nice if we could pass all paths through pathlib
(https://medium.com/@ageitgey/python-3-quick-tip-the-easy-way-to-deal-with-file-paths-on-windows-mac-and-linux-11a072b58d5f)
but that's clearly a longer-term project.
--
Rebecca Cran
On 5/5/23 20:46, Michael D Kinney wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4448
>
> Update tools_def.txt to add quotes around the file target in
> OBJCOPY_ADDDEBUGFLAGS for compatibility with GCC like tool
> chains used on Windows.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> BaseTools/Conf/tools_def.template | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> index 1b3a9e7a540a..535dda1d5d99 100755
> --- a/BaseTools/Conf/tools_def.template
> +++ b/BaseTools/Conf/tools_def.template
> @@ -731,9 +731,9 @@ NOOPT_VS2019_AARCH64_DLINK_FLAGS = /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
> *_*_*_OBJCOPY_FLAGS = objcopy not needed for
> *_*_*_SYMRENAME_PATH = echo
> *_*_*_SYMRENAME_FLAGS = Symbol renaming not needed for
> -DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> +DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
> RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG =
> -NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> +NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
> *_*_*_OBJCOPY_STRIPFLAG = --strip-unneeded -R .eh_frame
> *_*_*_DTC_FLAGS = -H epapr
> *_*_*_DTCPP_PATH = DEF(DTCPP_BIN)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt
2023-05-06 5:39 ` 回复: " gaoliming
@ 2023-05-06 16:28 ` Michael D Kinney
0 siblings, 0 replies; 6+ messages in thread
From: Michael D Kinney @ 2023-05-06 16:28 UTC (permalink / raw)
To: Gao, Liming, devel@edk2.groups.io
Cc: 'Rebecca Cran', Feng, Bob C, Chen, Christine,
Kinney, Michael D
Hi Liming,
Potentially. I have not observed a failure with that one. It may be an OBJCOPY specific issue.
Mike
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Friday, May 5, 2023 10:40 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> Cc: 'Rebecca Cran' <rebecca@bsdio.com>; Feng, Bob C
> <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>
> Subject: 回复: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> ADDDEBUGFLAG in tools_def.txt
>
> Mike:
> I also see GCC_DLINK2_FLAGS_COMMON option uses / as the file path. Does
> it bring the same problem in Windows OS?
>
> DEFINE GCC_DLINK2_FLAGS_COMMON = -Wl,--
> script=$(EDK_TOOLS_PATH)/Scripts/GccBase.lds
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Kinney, Michael D <michael.d.kinney@intel.com>
> > 发送时间: 2023年5月6日 12:55
> > 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > 抄送: 'Rebecca Cran' <rebecca@bsdio.com>; Feng, Bob C
> > <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>; Kinney,
> > Michael D <michael.d.kinney@intel.com>
> > 主题: RE: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> > ADDDEBUGFLAG in tools_def.txt
> >
> > The issue I saw was a mix of / and \ in the file path. On Windows
> > $(DEBUG_DIR) would
> > Have '\' in path and then a '/' before $(MODULE_NAME). Without the
> > quotes, this
> > would generate an error. With quotes, it would get the full filename
> correct.
> >
> > On Linux, only '/' are used for the whole path and everything works with
> and
> > Without quotes.
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: gaoliming <gaoliming@byosoft.com.cn>
> > > Sent: Friday, May 5, 2023 8:01 PM
> > > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > > Cc: 'Rebecca Cran' <rebecca@bsdio.com>; Feng, Bob C
> > > <bob.c.feng@intel.com>; Chen, Christine <yuwei.chen@intel.com>
> > > Subject: 回复: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> > > ADDDEBUGFLAG in tools_def.txt
> > >
> > > Mike:
> > > Do you mean $(DEBUG_DIR)/$(MODULE_NAME).debug file path may
> > have
> > > space on
> > > windows OS? Does the workspace directory include the space?
> > >
> > > Thanks
> > > Liming
> > > > -----邮件原件-----
> > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael
> > D
> > > > Kinney
> > > > 发送时间: 2023年5月6日 10:47
> > > > 收件人: devel@edk2.groups.io
> > > > 抄送: Rebecca Cran <rebecca@bsdio.com>; Liming Gao
> > > > <gaoliming@byosoft.com.cn>; Bob Feng <bob.c.feng@intel.com>; Yuwei
> > > Chen
> > > > <yuwei.chen@intel.com>
> > > > 主题: [edk2-devel] [Patch 1/1] BaseTools/Conf: Add quotes to
> > > > ADDDEBUGFLAG in tools_def.txt
> > > >
> > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4448
> > > >
> > > > Update tools_def.txt to add quotes around the file target in
> > > > OBJCOPY_ADDDEBUGFLAGS for compatibility with GCC like tool
> > > > chains used on Windows.
> > > >
> > > > Cc: Rebecca Cran <rebecca@bsdio.com>
> > > > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > > > Cc: Bob Feng <bob.c.feng@intel.com>
> > > > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > > > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> > > > ---
> > > > BaseTools/Conf/tools_def.template | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/BaseTools/Conf/tools_def.template
> > > > b/BaseTools/Conf/tools_def.template
> > > > index 1b3a9e7a540a..535dda1d5d99 100755
> > > > --- a/BaseTools/Conf/tools_def.template
> > > > +++ b/BaseTools/Conf/tools_def.template
> > > > @@ -731,9 +731,9 @@ NOOPT_VS2019_AARCH64_DLINK_FLAGS =
> > > > /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF
> > > > *_*_*_OBJCOPY_FLAGS = objcopy not needed for
> > > > *_*_*_SYMRENAME_PATH = echo
> > > > *_*_*_SYMRENAME_FLAGS = Symbol renaming not
> > needed for
> > > > -DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG =
> > > > --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> > > > +DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG =
> > > > --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
> > > > RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG =
> > > > -NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG =
> > > > --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug
> > > > +NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG =
> > > > --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug"
> > > > *_*_*_OBJCOPY_STRIPFLAG = --strip-unneeded
> > -R .eh_frame
> > > > *_*_*_DTC_FLAGS = -H epapr
> > > > *_*_*_DTCPP_PATH = DEF(DTCPP_BIN)
> > > > --
> > > > 2.40.1.windows.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-06 16:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-06 2:46 [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt Michael D Kinney
2023-05-06 3:01 ` 回复: [edk2-devel] " gaoliming
2023-05-06 4:55 ` Michael D Kinney
2023-05-06 5:39 ` 回复: " gaoliming
2023-05-06 16:28 ` Michael D Kinney
2023-05-06 9:40 ` Rebecca Cran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox