From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx.groups.io with SMTP id smtpd.web11.30895.1683366052216924557 for ; Sat, 06 May 2023 02:40:52 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=z3icneL9; spf=pass (domain: bsdio.com, ip: 66.111.4.28, mailfrom: rebecca@bsdio.com) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 7741D5C0040; Sat, 6 May 2023 05:40:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 06 May 2023 05:40:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683366049; x=1683452449; bh=CiTAVpmmO7UMFpAgo4mlI+22qlHKTsT1QQ6 c6lHikQ0=; b=z3icneL9A21KWRV5IP1t/CONP+WjKzQZjNUgoVT9WViZ4Wpq7GI 4L8XFmZBzyHdqFaIq9DT4rqNL09+t4BzhBBILgZ0c6QbtUwJO522+38nj5EhPnbA jA8hkpgyTzTTK7bLs1KQoLb977xNEnW5qqhrZ8DPGctanC5TxkOPaxEXDzX/M9z/ nbS53K6drLTsCS+xb8C8jaRSKBQf3avFKsbm6/VHjLmrzbg6MnzYgliwgFOMsPOQ gazco99y2QHdQXvMKmqrHrf+f7BOY4eL0JhrUbQWpXE8tQYL+bj6iiav4YSH7Yvp Gb1A4YAvZq3/hm7qnMsk7w7thMdpUo5rKUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683366049; x=1683452449; bh=CiTAVpmmO7UMFpAgo4mlI+22qlHKTsT1QQ6 c6lHikQ0=; b=flPuBR0UOZC+EQv20wNIm1NtDH9NBUoTVgiKDUqleVV1DF92QN+ f30Vsxvt4CbETOUIxpd3NwQ5VG3wR82iwcHFhGKZdcFvgG689U7wnY6BezkW6rNl 9BGMEvCNBLtcOotOuDetbNjMm+Gm5ZMl3ZI0YCC/z5WJbPcIbjTFiafIjJk0/gRC jarE6TroYBkKU0+TrDM1POIYKOantAzSa7V/J51r7/oc87HjP08nbHyGU32EcuMb F3xFn5nGT3lzT2CHzJmNSQh4T9WToPo/9wuasTata319Hg/aZ5yRpDSKgTiNfQhQ htpF+VL7Yw1qhjhg6rucBD6SaTzHu9tW8Fw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeffedgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheptfgv sggvtggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrf grthhtvghrnhepveeuieehudeutdevuddvhfdvvdfffeejheegieeggfeikeegheegieel ffehtdeinecuffhomhgrihhnpehmvgguihhumhdrtghomhdpthhirghnohgtohhrvgdroh hrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehr vggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 May 2023 05:40:48 -0400 (EDT) Message-ID: <514defe6-a9f7-19e9-5e47-fb22305a1277@bsdio.com> Date: Sat, 6 May 2023 03:40:47 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [Patch 1/1] BaseTools/Conf: Add quotes to ADDDEBUGFLAG in tools_def.txt To: Michael D Kinney , devel@edk2.groups.io Cc: Liming Gao , Bob Feng , Yuwei Chen References: <20230506024636.1245-1-michael.d.kinney@intel.com> From: "Rebecca Cran" In-Reply-To: <20230506024636.1245-1-michael.d.kinney@intel.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Rebecca Cran It would be nice if we could pass all paths through pathlib (https://medium.com/@ageitgey/python-3-quick-tip-the-easy-way-to-deal-with-file-paths-on-windows-mac-and-linux-11a072b58d5f) but that's clearly a longer-term project. -- Rebecca Cran On 5/5/23 20:46, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4448 > > Update tools_def.txt to add quotes around the file target in > OBJCOPY_ADDDEBUGFLAGS for compatibility with GCC like tool > chains used on Windows. > > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Signed-off-by: Michael D Kinney > --- > BaseTools/Conf/tools_def.template | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template > index 1b3a9e7a540a..535dda1d5d99 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -731,9 +731,9 @@ NOOPT_VS2019_AARCH64_DLINK_FLAGS = /NOLOGO /NODEFAULTLIB /IGNORE:4001 /OPT:REF > *_*_*_OBJCOPY_FLAGS = objcopy not needed for > *_*_*_SYMRENAME_PATH = echo > *_*_*_SYMRENAME_FLAGS = Symbol renaming not needed for > -DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug > +DEBUG_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug" > RELEASE_*_*_OBJCOPY_ADDDEBUGFLAG = > -NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink=$(DEBUG_DIR)/$(MODULE_NAME).debug > +NOOPT_*_*_OBJCOPY_ADDDEBUGFLAG = --add-gnu-debuglink="$(DEBUG_DIR)/$(MODULE_NAME).debug" > *_*_*_OBJCOPY_STRIPFLAG = --strip-unneeded -R .eh_frame > *_*_*_DTC_FLAGS = -H epapr > *_*_*_DTCPP_PATH = DEF(DTCPP_BIN)