From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1EEFD2097FABF for ; Tue, 17 Jul 2018 12:09:00 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9CD8A4021FC6; Tue, 17 Jul 2018 19:08:59 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-194.rdu2.redhat.com [10.10.120.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 09652111C481; Tue, 17 Jul 2018 19:08:58 +0000 (UTC) From: Laszlo Ersek To: Eric Dong Cc: edk2-devel@lists.01.org References: <20180716030851.13752-1-eric.dong@intel.com> <4878637c-df4f-f099-32e8-370208c01a71@redhat.com> Message-ID: <515aab01-f775-b513-add7-9c100a954235@redhat.com> Date: Tue, 17 Jul 2018 21:08:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <4878637c-df4f-f099-32e8-370208c01a71@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 17 Jul 2018 19:08:59 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 17 Jul 2018 19:08:59 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [Patch v3 0/3] Optimize load uCode performance X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 19:09:01 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 07/17/18 18:38, Laszlo Ersek wrote: > Hi Eric, > > On 07/16/18 05:08, Eric Dong wrote: >> Use below three rules to optimize load uCode performance: >> 1. Let BSP relocate uCode from flash to memory for better performance. >> 2. BSP caches the CPU ID and address of uCode so AP doesn’t need to look >> for the uCode again if the CPU ID is same as BSP’s. >> 3. Only apply uCode in one thread of a core when hyper threading is enabled. >> >> v2 changes: >> Fix potential issue if allocate memory failed. >> >> V3 Changes: >> Remove the ASSERT code which is not correct. > > Based on the above, my understanding is that you didn't modify patches > #2 and #3, from v2 to v3. Is that correct? I compared the v2 and v3 patches pair-wise; indeed the ASSERT()'s removal in patch #1 is the only difference. > If it's correct, then you should have picked up my Acked-by tags from > the v2 review, for the v3 posting: > > http://mid.mail-archive.com/dcf4df85-1d35-65e9-2c9b-d5d47a0988aa@redhat.com > > http://mid.mail-archive.com/dbc8439f-448e-306c-cdbd-1b2edc1f4aef@redhat.com > > If you don't pick up my previous review tags for un-modified patches in > new postings of the patch series, then I have to re-review those patches > every single time. I described this workflow element here: > > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-26 > > ---------- > 26. § More frequently though, you will get requests for changes for > *some* of your patches, while *others* of your patches will be > fine, and garner Reviewed-by, Acked-by, and Tested-by tags. What > you need to do in this case is: > > * create the next version of your local branch > * pick up the tags that you got on the list > * implement the requested changes > * mark the v2 changes on each patch outside of the commit > message > * push the next version to your personal repo again > * post the next version to the list > > In the following steps, we'll go through each of these in more > detail. > ---------- * For patch #1: Reviewed-by: Laszlo Ersek Regression-tested-by: Laszlo Ersek * For patches #2 and #3: Acked-by: Laszlo Ersek Regression-tested-by: Laszlo Ersek Thanks Laszlo