From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B454B21B02834 for ; Thu, 7 Dec 2017 03:04:47 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3E1D16A7DA; Thu, 7 Dec 2017 11:09:20 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-204.rdu2.redhat.com [10.10.120.204]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63E756928B; Thu, 7 Dec 2017 11:09:18 +0000 (UTC) To: "Shi, Steven" , Ard Biesheuvel , "edk2-devel@lists.01.org" Cc: "leif.lindholm@linaro.org" , "Gao, Liming" , "Zhu, Yonghong" , "evan.lloyd@arm.com" References: <20171206113917.6166-1-ard.biesheuvel@linaro.org> <06C8AB66E78EE34A949939824ABE2B313B5E441A@shsmsx102.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <515cbe9a-fa89-6bc7-2909-6ccb295ec68b@redhat.com> Date: Thu, 7 Dec 2017 12:09:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <06C8AB66E78EE34A949939824ABE2B313B5E441A@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 07 Dec 2017 11:09:20 +0000 (UTC) Subject: Re: [PATCH] BaseTools/tools_def: add CLANG38 LTO versions for AARCH64 and ARM X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 11:04:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/07/17 03:05, Shi, Steven wrote: > Hi Ard, > I'm OK for the patch. > BTW, would you mind to help add the "-Wno-unused-const-variable" in the CLANG38_WARNING_OVERRIDES? I happen to need add it in CLANG38 (https://bugzilla.tianocore.org/show_bug.cgi?id=790) and I see it seems a shared flag for ARM/AARCH64 as well. I suggest we handle that flag / BZ separately from this patch. (If Ard feels very generous, he could append a separate patch to this series, for adding the flag, but I don't think we can *ask* for that. It's a totally separate topic.) Thanks! Laszlo > > Steven Shi > Intel\SSG\STO\UEFI Firmware > > Tel: +86 021-61166522 > iNet: 821-6522 > > >> -----Original Message----- >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> Sent: Wednesday, December 6, 2017 7:39 PM >> To: edk2-devel@lists.01.org >> Cc: leif.lindholm@linaro.org; Gao, Liming ; Zhu, >> Yonghong ; Shi, Steven ; >> evan.lloyd@arm.com; lersek@redhat.com; Ard Biesheuvel >> >> Subject: [PATCH] BaseTools/tools_def: add CLANG38 LTO versions for >> AARCH64 and ARM >> >> Extend the CLANG38 toolchain definition so it can be used for >> ARM and AARCH64 as well. Note that this requires llvm-ar and >> the LLVMgold.so linker plugin. >> >> In preparation of doing the same for GCC5, this toolchain version >> also departs from the custom of using -O0 for DEBUG builds, which >> makes them needlessly slow. Instead, let's add a NOOPT flavor as >> well, and enable optimization for DEBUG like the other architectures >> do. (Note that this will require some trivial changes to the platform >> description files) >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> BaseTools/Conf/tools_def.template | 98 +++++++++++++++++++- >> 1 file changed, 95 insertions(+), 3 deletions(-) >> >> diff --git a/BaseTools/Conf/tools_def.template >> b/BaseTools/Conf/tools_def.template >> index 91b135c2e569..6ee720d7586e 100755 >> --- a/BaseTools/Conf/tools_def.template >> +++ b/BaseTools/Conf/tools_def.template >> @@ -399,8 +399,8 @@ DEFINE DTC_BIN = ENV(DTC_PREFIX)dtc >> # Intel(r) ACPI Compiler from >> # https://acpica.org/downloads >> # CLANG38 -Linux- Requires: >> -# Clang v3.8, LLVMgold plugin and GNU binutils 2.26 >> targeting x86_64-linux-gnu >> -# Clang v3.9 or later, LLVMgold plugin and GNU binutils 2.28 >> targeting x86_64-linux-gnu >> +# Clang v3.8, LLVMgold plugin and GNU binutils 2.26 >> targeting x86_64-linux-gnu, aarch64-linux-gnu or arm-linux-gnueabi >> +# Clang v3.9 or later, LLVMgold plugin and GNU binutils 2.28 >> targeting x86_64-linux-gnu, aarch64-linux-gnu or arm-linux-gnueabi >> # Optional: >> # Required to build platforms or ACPI tables: >> # Intel(r) ACPI Compiler from >> @@ -5652,6 +5652,7 @@ RELEASE_CLANG35_AARCH64_CC_FLAGS = >> DEF(CLANG35_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) >> *_CLANG38_*_MAKE_PATH = make >> *_CLANG38_*_*_DLL = ENV(CLANG38_DLL) >> *_CLANG38_*_ASL_PATH = DEF(UNIX_IASL_BIN) >> +*_CLANG38_*_DTC_PATH = DEF(DTC_BIN) >> >> *_CLANG38_*_APP_FLAGS = >> *_CLANG38_*_ASL_FLAGS = DEF(IASL_FLAGS) >> @@ -5663,7 +5664,8 @@ DEFINE CLANG38_X64_PREFIX = >> ENV(CLANG38_BIN) >> DEFINE CLANG38_IA32_TARGET = -target i686-pc-linux-gnu >> DEFINE CLANG38_X64_TARGET = -target x86_64-pc-linux-gnu >> >> -DEFINE CLANG38_ALL_CC_FLAGS = DEF(GCC44_ALL_CC_FLAGS) -Wno- >> empty-body -fno-stack-protector -mms-bitfields -Wno-address -Wno-shift- >> negative-value -Wno-parentheses-equality -Wno-unknown-pragmas -Wno- >> tautological-constant-out-of-range-compare -Wno-incompatible-library- >> redeclaration -fno-asynchronous-unwind-tables -mno-sse -mno-mmx - >> msoft-float -mno-implicit-float -ftrap- >> function=undefined_behavior_has_been_optimized_away_by_clang - >> funsigned-char -fno-ms-extensions -Wno-null-dereference -Wno- >> tautological-compare -Wno-unknown-warning-option -Wno-varargs >> +DEFINE CLANG38_WARNING_OVERRIDES = -Wno-parentheses-equality - >> Wno-tautological-compare -Wno-tautological-constant-out-of-range- >> compare -Wno-empty-body -Wno-varargs >> +DEFINE CLANG38_ALL_CC_FLAGS = DEF(GCC44_ALL_CC_FLAGS) >> DEF(CLANG38_WARNING_OVERRIDES) -fno-stack-protector -mms-bitfields - >> Wno-address -Wno-shift-negative-value -Wno-unknown-pragmas -Wno- >> incompatible-library-redeclaration -fno-asynchronous-unwind-tables -mno- >> sse -mno-mmx -msoft-float -mno-implicit-float -ftrap- >> function=undefined_behavior_has_been_optimized_away_by_clang - >> funsigned-char -fno-ms-extensions -Wno-null-dereference -Wno-unknown- >> warning-option >> >> ########################### >> # CLANG38 IA32 definitions >> @@ -5739,6 +5741,96 @@ NOOPT_CLANG38_X64_CC_FLAGS = >> DEF(CLANG38_ALL_CC_FLAGS) -m64 "-DEFIAPI=__ >> NOOPT_CLANG38_X64_DLINK_FLAGS = >> DEF(GCC5_IA32_X64_DLINK_FLAGS) -Wl,-O0 -Wl,-melf_x86_64 -Wl,-- >> oformat=elf64-x86-64 -Wl,-pie -mcmodel=small >> NOOPT_CLANG38_X64_DLINK2_FLAGS = DEF(GCC5_X64_DLINK2_FLAGS) - >> O0 >> >> +################## >> +# CLANG38 ARM definitions >> +################## >> +DEFINE CLANG38_ARM_TARGET = -target arm-linux-gnueabihf >> +DEFINE CLANG38_ARM_CC_FLAGS = DEF(GCC_ARM_CC_FLAGS) >> DEF(CLANG38_ARM_TARGET) DEF(CLANG38_WARNING_OVERRIDES) -mno- >> movt >> +DEFINE CLANG38_ARM_DLINK_FLAGS = DEF(CLANG38_ARM_TARGET) >> DEF(GCC_ARM_DLINK_FLAGS) >> + >> +*_CLANG38_ARM_PP_FLAGS = DEF(GCC_PP_FLAGS) >> +*_CLANG38_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) >> +*_CLANG38_ARM_APP_FLAGS = >> +*_CLANG38_ARM_ASL_FLAGS = DEF(IASL_FLAGS) >> +*_CLANG38_ARM_ASL_OUTFLAGS = DEF(IASL_OUTFLAGS) >> +*_CLANG38_ARM_DTCPP_FLAGS = DEF(GCC_DTCPP_FLAGS) >> + >> +*_CLANG38_ARM_CC_PATH = ENV(CLANG38_BIN)clang >> +*_CLANG38_ARM_ASM_PATH = ENV(CLANG38_BIN)clang >> +*_CLANG38_ARM_PP_PATH = ENV(CLANG38_BIN)clang >> +*_CLANG38_ARM_VFRPP_PATH = ENV(CLANG38_BIN)clang >> +*_CLANG38_ARM_ASLCC_PATH = ENV(CLANG38_BIN)clang >> +*_CLANG38_ARM_ASLPP_PATH = ENV(CLANG38_BIN)clang >> +*_CLANG38_ARM_DLINK_PATH = ENV(CLANG38_BIN)clang >> +*_CLANG38_ARM_ASLDLINK_PATH = ENV(CLANG38_BIN)clang >> + >> +*_CLANG38_ARM_SLINK_PATH = ENV(CLANG38_BIN)llvm-ar >> +*_CLANG38_ARM_RC_PATH = ENV(CLANG38_ARM_PREFIX)objcopy >> + >> +*_CLANG38_ARM_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) >> +*_CLANG38_ARM_ASLDLINK_FLAGS = DEF(CLANG38_ARM_TARGET) >> DEF(GCC_ARM_ASLDLINK_FLAGS) >> +*_CLANG38_ARM_ASM_FLAGS = DEF(GCC_ASM_FLAGS) >> DEF(CLANG38_ARM_TARGET) $(ARCHASM_FLAGS) $(PLATFORM_FLAGS) - >> Qunused-arguments >> +*_CLANG38_ARM_DLINK2_FLAGS = >> DEF(GCC_DLINK2_FLAGS_COMMON) -Wl,-- >> defsym=PECOFF_HEADER_SIZE=0x220 >> +*_CLANG38_ARM_PLATFORM_FLAGS = -march=armv7-a >> +*_CLANG38_ARM_PP_FLAGS = DEF(GCC_PP_FLAGS) >> DEF(CLANG38_ARM_TARGET) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) >> +*_CLANG38_ARM_RC_FLAGS = DEF(GCC_ARM_RC_FLAGS) >> +*_CLANG38_ARM_VFRPP_FLAGS = DEF(GCC_VFRPP_FLAGS) >> DEF(CLANG38_ARM_TARGET) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) >> +*_CLANG38_ARM_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS) >> DEF(CLANG38_ARM_TARGET) >> +*_CLANG38_ARM_CC_XIPFLAGS = DEF(GCC_ARM_CC_XIPFLAGS) >> + >> + DEBUG_CLANG38_ARM_CC_FLAGS = DEF(CLANG38_ARM_CC_FLAGS) >> $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O3 >> + DEBUG_CLANG38_ARM_DLINK_FLAGS = >> DEF(CLANG38_ARM_DLINK_FLAGS) -flto -Wl,-O3 >> + NOOPT_CLANG38_ARM_CC_FLAGS = DEF(CLANG38_ARM_CC_FLAGS) >> $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O0 >> + NOOPT_CLANG38_ARM_DLINK_FLAGS = >> DEF(CLANG38_ARM_DLINK_FLAGS) >> +RELEASE_CLANG38_ARM_CC_FLAGS = DEF(CLANG38_ARM_CC_FLAGS) >> $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) -O3 >> +RELEASE_CLANG38_ARM_DLINK_FLAGS = >> DEF(CLANG38_ARM_DLINK_FLAGS) -flto -Wl,-O3 >> + >> +################## >> +# CLANG38 AARCH64 definitions >> +################## >> +DEFINE CLANG38_AARCH64_TARGET = -target aarch64-linux-gnu >> +DEFINE CLANG38_AARCH64_CC_FLAGS = DEF(GCC_AARCH64_CC_FLAGS) >> DEF(CLANG38_AARCH64_TARGET) -mcmodel=small >> DEF(CLANG38_WARNING_OVERRIDES) >> +DEFINE CLANG38_AARCH64_DLINK_FLAGS = >> DEF(CLANG38_AARCH64_TARGET) DEF(GCC_AARCH64_DLINK_FLAGS) -z >> common-page-size=0x1000 >> + >> +*_CLANG38_AARCH64_PP_FLAGS = DEF(GCC_PP_FLAGS) >> +*_CLANG38_AARCH64_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) >> +*_CLANG38_AARCH64_APP_FLAGS = >> +*_CLANG38_AARCH64_ASL_FLAGS = DEF(IASL_FLAGS) >> +*_CLANG38_AARCH64_ASL_OUTFLAGS = DEF(IASL_OUTFLAGS) >> +*_CLANG38_AARCH64_DTCPP_FLAGS = DEF(GCC_DTCPP_FLAGS) >> + >> +*_CLANG38_AARCH64_CC_PATH = ENV(CLANG38_BIN)clang >> +*_CLANG38_AARCH64_ASM_PATH = ENV(CLANG38_BIN)clang >> +*_CLANG38_AARCH64_PP_PATH = ENV(CLANG38_BIN)clang >> +*_CLANG38_AARCH64_VFRPP_PATH = ENV(CLANG38_BIN)clang >> +*_CLANG38_AARCH64_ASLCC_PATH = ENV(CLANG38_BIN)clang >> +*_CLANG38_AARCH64_ASLPP_PATH = ENV(CLANG38_BIN)clang >> +*_CLANG38_AARCH64_DLINK_PATH = ENV(CLANG38_BIN)clang >> +*_CLANG38_AARCH64_ASLDLINK_PATH = ENV(CLANG38_BIN)clang >> + >> +*_CLANG38_AARCH64_SLINK_PATH = ENV(CLANG38_BIN)llvm-ar >> +*_CLANG38_AARCH64_RC_PATH = >> ENV(CLANG38_AARCH64_PREFIX)objcopy >> + >> +*_CLANG38_AARCH64_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) >> +*_CLANG38_AARCH64_ASLDLINK_FLAGS = >> DEF(CLANG38_AARCH64_TARGET) DEF(GCC_AARCH64_ASLDLINK_FLAGS) >> +*_CLANG38_AARCH64_ASM_FLAGS = DEF(GCC_ASM_FLAGS) >> DEF(CLANG38_AARCH64_TARGET) $(ARCHASM_FLAGS) $(PLATFORM_FLAGS) >> -Qunused-arguments >> +*_CLANG38_AARCH64_DLINK_FLAGS = DEF(CLANG38_AARCH64_TARGET) >> DEF(GCC_AARCH64_DLINK_FLAGS) -z common-page-size=0x1000 >> +*_CLANG38_AARCH64_DLINK_XIPFLAGS = -z common-page-size=0x20 >> +*_CLANG38_AARCH64_DLINK2_FLAGS = >> DEF(GCC_DLINK2_FLAGS_COMMON) -Wl,-- >> defsym=PECOFF_HEADER_SIZE=0x228 >> +*_CLANG38_AARCH64_PLATFORM_FLAGS = >> +*_CLANG38_AARCH64_PP_FLAGS = DEF(GCC_PP_FLAGS) >> DEF(CLANG38_AARCH64_TARGET) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) >> +*_CLANG38_AARCH64_RC_FLAGS = DEF(GCC_AARCH64_RC_FLAGS) >> +*_CLANG38_AARCH64_VFRPP_FLAGS = DEF(GCC_VFRPP_FLAGS) >> DEF(CLANG38_AARCH64_TARGET) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) >> +*_CLANG38_AARCH64_ASLPP_FLAGS = DEF(GCC_ASLPP_FLAGS) >> DEF(CLANG38_AARCH64_TARGET) >> +*_CLANG38_AARCH64_CC_XIPFLAGS = DEF(GCC_AARCH64_CC_XIPFLAGS) >> + >> + DEBUG_CLANG38_AARCH64_CC_FLAGS = >> DEF(CLANG38_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) >> -O3 >> + DEBUG_CLANG38_AARCH64_DLINK_FLAGS = >> DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl,-O3 >> + NOOPT_CLANG38_AARCH64_CC_FLAGS = >> DEF(CLANG38_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) >> -O0 >> + NOOPT_CLANG38_AARCH64_DLINK_FLAGS = >> DEF(CLANG38_AARCH64_DLINK_FLAGS) >> +RELEASE_CLANG38_AARCH64_CC_FLAGS = >> DEF(CLANG38_AARCH64_CC_FLAGS) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS) >> -O3 >> +RELEASE_CLANG38_AARCH64_DLINK_FLAGS = >> DEF(CLANG38_AARCH64_DLINK_FLAGS) -flto -Wl,-O3 >> + >> >> ############################################################## >> ###################### >> # >> # Cygwin GCC And Intel ACPI Compiler >> -- >> 2.11.0 >