From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2597694139E for ; Tue, 9 Jan 2024 13:33:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WOVyjoZNfBGrko7mmeohJw4q3ORp0+FkD8JAXyle+EM=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704807199; v=1; b=L2oKvYZEk3qNv+B6SUFsHF7JFEzD4TPDfWXgyVWeKp+LroGTBIN/sdsaDSVYHfy3zoDJVwId s0z8eCaySnC0uz+mCo3Dsc2+VHmyj9YQXOHjtpLOXMMdhjP5ojgxM3VsVHlsb7pwoyDdnfW+XPE Vu5knESf2nW+6f7C2NhMqejg= X-Received: by 127.0.0.2 with SMTP id ArpaYY7687511xDnzYivFOZ2; Tue, 09 Jan 2024 05:33:19 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.16679.1704807199033058912 for ; Tue, 09 Jan 2024 05:33:19 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-0ZDRdnAkMSGx4tHaUJs2-g-1; Tue, 09 Jan 2024 08:33:15 -0500 X-MC-Unique: 0ZDRdnAkMSGx4tHaUJs2-g-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3A052285F983; Tue, 9 Jan 2024 13:33:15 +0000 (UTC) X-Received: from [10.39.193.97] (unknown [10.39.193.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E42FA51E3; Tue, 9 Jan 2024 13:33:13 +0000 (UTC) Message-ID: <5164e131-228f-32b6-d8e7-2df00bddf402@redhat.com> Date: Tue, 9 Jan 2024 14:33:12 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] Updates to .mailmap needed for Jeff Brasen, Jake Garver, Joey Vagades and Michael Roth? To: Michael Brown , devel@edk2.groups.io, Ard Biesheuvel , Michael Kinney Cc: rebecca@os.amperecomputing.com, Jeff Brasen , jake@nvidia.com, Michael.Roth@amd.com, joeyvagedes@microsoft.com References: <2490526e-539f-9d5c-4572-f09c324a07aa@redhat.com> <24565570-4147-db82-27c1-1281c895254a@redhat.com> <0102018cee32359e-436bd43a-4778-462e-98a3-7d00c24eb27e-000000@eu-west-1.amazonses.com> From: "Laszlo Ersek" In-Reply-To: <0102018cee32359e-436bd43a-4778-462e-98a3-7d00c24eb27e-000000@eu-west-1.amazonses.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: lc5t50sH98DgNts5ikRD92R7x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=L2oKvYZE; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/9/24 13:28, Michael Brown wrote: > On 09/01/2024 12:13, Laszlo Ersek wrote: >> On 1/9/24 11:45, Ard Biesheuvel wrote: >>> Note that git am does support a 'From: ' header as the first line of >>> the commit log, and will use it correctly to supersede the From: >>> header in the SMTP envelope. >> >> OTOH, that doesn't help in this case, IIUC. When the poster originally >> formats and sends the patch, their gitconfig says >> user.email=foobar@example.com, and the author meta-datum on the patch >> most likely *also* says foobar@example.com. (I.e., they are formatting a >> patch they have authored themselves.) Therefore >> git-format-patch/git-send-email have no reason to include an explicit >> "From:" line at the top of the commit message body. I agree that >> "From:", if present, mitigates the issue, but in most cases, I reckon, >> it's not present. > > Is there a way to configure git to force git-format-patch to > unconditionally include the inline "From:" header?  I tried: > >   git config format.forceInBodyFrom true > > which is described in the man page as "may help if the mailing list > software mangles the sender’s identity", but it seems to have an effect > only if "--from" is also specified. That still sounds great; I (and I expect many others) use alias(es) around git-format-patch anyway (because of [1] eg.), so wiring "--from" into that could work. (Not that I personally need this quirk right at the moment.) [1] https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23 What confuses me is that git-format-patch(1) specifically advises against the "--from" option "if you are feeding the result to git send-email". Huh. Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113448): https://edk2.groups.io/g/devel/message/113448 Mute This Topic: https://groups.io/mt/103534194/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-