From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.7284.1624359659292721710 for ; Tue, 22 Jun 2021 04:00:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CbJpV/ie; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624359658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jyHIPOIf/sQ2fTHHzluBPtTgpc/jWMi8VWfU295DwDI=; b=CbJpV/ieCjA4d816fIT8kQvm2X8Cep/9Y1XU8sHV/bS3DmDTdizhLkcQ1InKMFQ/S8Dm7v VKEJbR1wwJT6feSNu1NAtjPrOr3/GvmPLlqe6Ns1rFHLHb11nYnNPAfumkAbTQKOk7IH4/ 0H6v74I9I2fBd9001lexOV8lS93wiBU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-rIXOjnOINXufykGRjafxgQ-1; Tue, 22 Jun 2021 07:00:55 -0400 X-MC-Unique: rIXOjnOINXufykGRjafxgQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 936A55074F; Tue, 22 Jun 2021 11:00:53 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-52.ams2.redhat.com [10.36.115.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1922D5D9CA; Tue, 22 Jun 2021 11:00:51 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH RESEND v1 0/2] ArmVirtPkg: Enable PCIe support for Kvmtool To: devel@edk2.groups.io, alexandru.elisei@arm.com, pierre.gondois@arm.com, Ard Biesheuvel , Sami Mujawar Cc: Leif Lindholm References: <20210615152128.25565-1-Pierre.Gondois@arm.com> From: "Laszlo Ersek" Message-ID: <51849690-9857-fa44-3d82-b4784e9ec606@redhat.com> Date: Tue, 22 Jun 2021 13:00:50 +0200 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/21/21 15:43, Alexandru Elisei wrote: > Hi Pierre, > > On 6/15/21 4:21 PM, PierreGondois via groups.io wrote: >> From: Pierre Gondois >> >> PCIe support has been added to the Kvmtool virtual machine >> manager. Therefore, add a PciHostBridgeUtilityLib and enable >> PCIe support for Kvmtool firmware. >> >> The patches were re-send as the devel@edk2.groups.io was not included. >> >> The patches can be seen at: https://github.com/PierreARM/edk2/tree/1413_Enable_ArmVirt_Pci_v1 >> The results of the CI can be seen at: https://github.com/tianocore/edk2/pull/1718 > > Tested the patches with the latest version of the kvmtool PCI Express support [1], > and everything worked as expected. A summary of the tests that I ran can be found > at [1]. So you can add for the entire series: > > Tested-by: Alexandru Elisei > > One thing of note is that applying patch #2 of this series on top of 11b1c1d4b98b > ("SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttributes parameter") > failed. If there is a conflict that needs to be resolved, then Pierre, can you please repost? Otherwise: Sami, can you please merge the series with Ard's and Alex's tags? Thanks! Laszlo > However, building from your repo went fine, and the binary that I used for > testing was built from your repo. > > [1] https://lore.kernel.org/kvm/20210621092128.11313-1-alexandru.elisei@arm.com/ > > Thanks, > > Alex > >> >> Sami Mujawar (2): >> ArmVirtPkg: Add PCIe host bridge utility lib for ArmVirtPkg >> ArmVirtPkg: Enable PCIe support for Kvmtool >> >> ArmVirtPkg/ArmVirtKvmTool.dsc | 35 ++- >> ArmVirtPkg/ArmVirtKvmTool.fdf | 11 +- >> .../ArmVirtPciHostBridgeUtilityLib.c | 219 ++++++++++++++++++ >> .../ArmVirtPciHostBridgeUtilityLib.inf | 39 ++++ >> 4 files changed, 301 insertions(+), 3 deletions(-) >> create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.c >> create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.inf >> > > > > >