Re: [edk2-devel] [PATCH] Remove memory cache setting for memory under 1MB

["Laszlo Ersek" <lersek@redhat.com>]

On 10/18/23 13:55, Yuanhao Xie wrote:
> With the fact that CSM is not supported,
> the request is to remove the cache setting for memory under 1MB.
> This can be treated as the missing part of legacy CSM deprecation.
> 
> This patch only set the 00000 to 9FFFF and C0000 to FFFFF as Write Back.
> A0000-BFFFF range is still uncacheable for VGA.
> 
> M: Chasel Chiu <chasel.chiu@intel.com>
> M: Nate DeSimone <nathaniel.l.desimone@intel.com>
> M: Isaac Oram <isaac.w.oram@intel.com>
> R: Liming Gao <gaoliming@byosoft.com.cn>
> R: Eric Dong <eric.dong@intel.com>
> Signed-off-by: Yuanhao Xie <yuanhao.xie@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.c b/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.c
> index 05728275a5..38a8db6b3f 100644
> --- a/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.c
> +++ b/Platform/Intel/MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.c
> @@ -245,7 +245,7 @@ SetCacheMtrrAfterEndOfPei (
>                           &MtrrSetting,
>                           0xC0000,
>                           0x40000,
> -                         CacheWriteProtected
> +                         CacheWriteBack
>                           );
>    ASSERT_EFI_ERROR ( Status);
>  

Patch subject line is bogus; first, it does not identify edk2-platforms
between the brackets, second, the subject proper does not identify
MinPlatformPkg.

Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109747): https://edk2.groups.io/g/devel/message/109747
Mute This Topic: https://groups.io/mt/102037244/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-