From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::443; helo=mail-pf1-x443.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 26A7C2194EB70 for ; Tue, 12 Feb 2019 04:08:04 -0800 (PST) Received: by mail-pf1-x443.google.com with SMTP id f132so1201465pfa.6 for ; Tue, 12 Feb 2019 04:08:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XhS3NCgdZHdfbQTQPcKdX+NNcZv48dindaub+mjtj8Y=; b=mbyqz/6DDJXF9kcxP2faCG5I48XHkxaetDGvcoc5Z6FhdxsFMk8nXsAYj2cUQEsvOX Ubjoqk6cd8CERUoz2fOZ6Qz6H0G2+XUsmTuF3JNrQUB9MIjEteO/XfwyECdNIJ+nGQPZ PT7Vft3l6IGhR2HPF9eLiFUwRqSzd41PI3K5t3YF9ICP+c4jLB8hxS+3uA3VCNXlLZon I+59Jw+wwgg+u4gweQw0pQvsxh380iF9ixiikv8+m8ImzuREPPO1fjEhBr6UbJxI2cFm eqFpZugTNMT98NTKumiZJfzrLAG3Po9t7Nj3/H0+X1OOTjOsCa6ouF+6HlIlspMkD+cl 88EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XhS3NCgdZHdfbQTQPcKdX+NNcZv48dindaub+mjtj8Y=; b=IOIHKqocEd+J0BOQCjUGWr0bCCv4rJZ4X9oASGStV2uJBqHwPah7pxKuaEIsZwEqSI lnoxur4wCI1Z/C7C5DUtshQCfF+QyXHgm3Mz1tEJaYcfhTabYRwubTPc2Q4Bvf4VSisx PcfwQGNHryE/umtcfObnLfmPtxSDBoZBZ1yPaoHJ/oXaMj8ir5HxEXd9BfrAYW9fmdVz GnGjRSRv2XKaxHrPfIacHnxOHgXu4Hr5FcfAv1skiWlTIbXKazNVUDehR+Sh8vg8W6Wb cneZu0WNrfTy6cqBUG63DDYcVnuzQytcR5nUg6khw3DcoEI7qob92Iyapu2V+mdSgk4f Q2Pg== X-Gm-Message-State: AHQUAubsnQjf9LnDVwnVKwuj2GgFKZA2WpEmGnVDUVrcqtli/hcXrLAH owhrDbiAB/3ToWMuY6UUM1A+ow== X-Google-Smtp-Source: AHgI3IZg15buFfJ6+KZ8TvNXr3ZDQA+4ED2pTZG2JG8XUWncRM1dmDg3HgTTgnt+1QcS3gvQCaDw/Q== X-Received: by 2002:a65:610f:: with SMTP id z15mr3292940pgu.153.1549973283575; Tue, 12 Feb 2019 04:08:03 -0800 (PST) Received: from [10.15.0.66] ([64.64.108.250]) by smtp.gmail.com with ESMTPSA id z67sm27354408pfd.188.2019.02.12.04.07.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 04:08:02 -0800 (PST) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com References: <20190201142507.30454-1-ming.huang@linaro.org> <20190201142507.30454-3-ming.huang@linaro.org> <20190211213608.w7zqyap6vws4lam5@bivouac.eciton.net> <9c8d26cd-b0bb-e573-8a12-20259271c40e@linaro.org> <20190212104459.lifteascit2anj6h@bivouac.eciton.net> From: Ming Huang Message-ID: <51a23852-cfb8-a6c0-9a0d-21c39143d506@linaro.org> Date: Tue, 12 Feb 2019 20:07:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20190212104459.lifteascit2anj6h@bivouac.eciton.net> Subject: Re: [PATCH edk2-non-osi v1 2/7] Hisilicon/D0x: Rename StartupAp() function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 12:08:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/12/2019 6:44 PM, Leif Lindholm wrote: > On Tue, Feb 12, 2019 at 04:05:50PM +0800, Ming Huang wrote: >> On 2/12/2019 5:36 AM, Leif Lindholm wrote: >>> On Fri, Feb 01, 2019 at 10:25:02PM +0800, Ming Huang wrote: >>>> As suggestion of community, 'AP' is a bit unfortunate to use in EDK2 >>>> context. PI specifies 'BSP' for Boot-strap Processor, as the one >>>> executing all of the EDK2 code. It then uses 'AP' to refer to >>>> Additional Processors, which can be assigned tasks using the >>>> EFI_MP_SERVICES_PROTOCOL. In a TianoCore context, this should be >>>> 'BSP'. So, Rename StartupAp() to StartUpBSP. >>> >>> Please add a comment somewhere that this applies to D0x >>> PlatformSysCtrlLib. >> >> ok >> >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: Ming Huang >>>> --- >>>> Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib | Bin 297590 -> 229128 bytes >>>> Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib | Bin 344310 -> 275312 bytes >>>> Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib | Bin 356032 -> 375916 bytes >>>> 3 files changed, 0 insertions(+), 0 deletions(-) >>> >>> These are substantial changes in image size from only changing the >>> name of a function. So I'll have a little look around. >>> >>> 1610 version appears to have switched from building with GCC49_RELEASE >>> to GCC48_RELEASE. >>> 1616 and 1620 versions seem to have used GCC48_RELEASE all along. >>> >>> I definitely see additional renamed functions in these libraries too. >>> >>> Please have an inventory and determine what may be affecting image sizes. >>> >>> Also, I *beg* you - please upgrade from "GNU C 4.8.3 20131202 (prerelease)". >> >> We have plan to upgrage gcc to 7.3, but our build server is share for all ARM >> project, so need discuss with other project groups, it may be not enough time >> for 19.02. > > Oh, we're too late in the game to change for this release. > But you are using ancient toolchains with poor code generation and > quite likely known bugs. > And this has been the state for quite some time. > If that can change for 19.06, that's good enough. Ok, I will upgrade gcc from 4.8 for 19.06. > >> For D05/D03 libraries, just remove 2 functions from OemMiscLib which used >> by PlatformSysCtrlLib. Does edk2 version effect the libraries size? >> old edk2 base on: 2017-0904 >> now edk2 base on: 2018-0801 > > Well, changing edk2 version will mean that command line options to > compiler and linker may change. So certainly some change can be seen. > But when the changes are this big, I suspect something else has been > going on. I also think it is strange for big size change. > >> For D06 library, we use the same source code to support all Hi1620 projects, >> include product projects,so there are some modify for this, like support >> 3 sockets, 4 sockets and remove some useless functions. > > So please reword the subject line of this commit to explain it is an > overall update of PlatformSysCtrlLib - including which bits are dropped. > > And I think this makes a good argument for moving the header files for > binary-only libraries from edk2-platforms to edk2-non-osi. > If you do that in a separate patch before this one, you won't need to > include as much detail in the commit message as you will otherwise. Do youe mean move PlatformSysCtrlLib.h, OemAddressMapLib.h and LpcLib.h to edk2-non-osi? > > Regards, > > Leif > >> Thanks. >> >>> >>> / >>> Leif >>> >>>> >>>> diff --git a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib >>>> index 68be770..4c63a26 100644 >>>> Binary files a/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib and b/Silicon/Hisilicon/Hi1610/Library/PlatformSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.lib differ >>>> diff --git a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib >>>> index b3cc88e..cb2c652 100644 >>>> Binary files a/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib and b/Silicon/Hisilicon/Hi1616/Library/PlatformSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.lib differ >>>> diff --git a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib >>>> index 50d453a..d643f7b 100644 >>>> Binary files a/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib and b/Silicon/Hisilicon/Hi1620/Library/PlatformSysCtrlLibHi1620/PlatformSysCtrlLibHi1620.lib differ >>>> -- >>>> 2.9.5 >>>>