public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Long Qin <qin.long@intel.com>, edk2-devel@lists.01.org
Cc: feng.tian@intel.com, eric.dong@intel.com, ting.ye@intel.com,
	hao.a.wu@intel.com
Subject: Re: [PATCH v2 0/4] Resolving Some CryptoPkg Build Issues
Date: Thu, 6 Apr 2017 10:54:56 +0200	[thread overview]
Message-ID: <51a65891-7565-086a-3827-f29d6b0d3529@redhat.com> (raw)
In-Reply-To: <20170401053834.12856-1-qin.long@intel.com>

On 04/01/17 07:38, Long Qin wrote:
> From: Qin Long <qin.long@intel.com>
> 
> V2:
>   Updated the patches as the comments from Laszlo (lersek@redhat.com).
>   And filed two TianoCore BZ (#455, #456) to track the further follow-ups
>   on openssl and EDKII-CryptoPkg:
>     https://bugzilla.tianocore.org/show_bug.cgi?id=455
>     https://bugzilla.tianocore.org/show_bug.cgi?id=456
> 
> This patch series introduced some hotfixes and workaround to resolve
> the build issues under different toolchain, and from potential external
> consumers, including:
>   - build warning under GCC48 and VS2010 toolchain;
>   - Potential unresolved external symbol link issue;
>   - One bug fix of timer() wrapper in ConstantTimeClock.c;
>   - One workaround to resolve macro re-definitions issue from some
>     external BaseCryptLib consumer.
> 
>   (https://github.com/qloong/edk2/commits/dev-openssl-hotfix)
> 
> Qin Long (4):
>   CryptoPkg/OpensslLib: Suppress extra build warnings in openssl source
>   CryptoPkg: Fix possible unresolved external symbol issue.
>   CryptoPkg/BaseCryptLib: Adding NULL checking in time() wrapper.
>   CryptoPkg: One workaround to resolve potential build issue.
> 
>  CryptoPkg/Include/CrtLibSupport.h                  |   1 +
>  CryptoPkg/Include/openssl/e_os2.h                  | 321 +++++++++++++++++++++
>  .../BaseCryptLib/SysCall/ConstantTimeClock.c       |   6 +-
>  CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c  |  10 +-
>  CryptoPkg/Library/OpensslLib/OpensslLib.inf        |  15 +-
>  CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf  |  15 +-
>  6 files changed, 355 insertions(+), 13 deletions(-)
>  create mode 100644 CryptoPkg/Include/openssl/e_os2.h
> 

I can see the upstream OpenSSL pull req / issue report references in
TianoCore BZs 455 and 456.

series
Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo


  parent reply	other threads:[~2017-04-06  8:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01  5:38 [PATCH v2 0/4] Resolving Some CryptoPkg Build Issues Long Qin
2017-04-01  5:38 ` [PATCH v2 1/4] CryptoPkg/OpensslLib: Suppress extra build warnings in openssl source Long Qin
2017-04-01  5:38 ` [PATCH v2 2/4] CryptoPkg: Fix possible unresolved external symbol issue Long Qin
2017-04-01  5:38 ` [PATCH v2 3/4] CryptoPkg/BaseCryptLib: Adding NULL checking in time() wrapper Long Qin
2017-04-01  5:38 ` [PATCH v2 4/4] CryptoPkg: One workaround to resolve potential build issue Long Qin
2017-04-03 16:45 ` [PATCH v2 0/4] Resolving Some CryptoPkg Build Issues Laszlo Ersek
2017-04-06  8:54 ` Laszlo Ersek [this message]
2017-04-06 11:26   ` Long, Qin
2017-04-06 12:56     ` Laszlo Ersek
2017-04-06 14:17       ` Long, Qin
2017-04-06 17:17         ` Laszlo Ersek
2017-04-07 10:17         ` Laszlo Ersek
2017-04-07 13:22           ` Long, Qin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51a65891-7565-086a-3827-f29d6b0d3529@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox