From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4B14F2194232B for ; Thu, 6 Apr 2017 01:54:59 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A74EA7AEA5; Thu, 6 Apr 2017 08:54:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A74EA7AEA5 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A74EA7AEA5 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-84.phx2.redhat.com [10.3.116.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id 36E59892C1; Thu, 6 Apr 2017 08:54:57 +0000 (UTC) To: Long Qin , edk2-devel@lists.01.org References: <20170401053834.12856-1-qin.long@intel.com> Cc: feng.tian@intel.com, eric.dong@intel.com, ting.ye@intel.com, hao.a.wu@intel.com From: Laszlo Ersek Message-ID: <51a65891-7565-086a-3827-f29d6b0d3529@redhat.com> Date: Thu, 6 Apr 2017 10:54:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170401053834.12856-1-qin.long@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 06 Apr 2017 08:54:58 +0000 (UTC) Subject: Re: [PATCH v2 0/4] Resolving Some CryptoPkg Build Issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 08:54:59 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/01/17 07:38, Long Qin wrote: > From: Qin Long > > V2: > Updated the patches as the comments from Laszlo (lersek@redhat.com). > And filed two TianoCore BZ (#455, #456) to track the further follow-ups > on openssl and EDKII-CryptoPkg: > https://bugzilla.tianocore.org/show_bug.cgi?id=455 > https://bugzilla.tianocore.org/show_bug.cgi?id=456 > > This patch series introduced some hotfixes and workaround to resolve > the build issues under different toolchain, and from potential external > consumers, including: > - build warning under GCC48 and VS2010 toolchain; > - Potential unresolved external symbol link issue; > - One bug fix of timer() wrapper in ConstantTimeClock.c; > - One workaround to resolve macro re-definitions issue from some > external BaseCryptLib consumer. > > (https://github.com/qloong/edk2/commits/dev-openssl-hotfix) > > Qin Long (4): > CryptoPkg/OpensslLib: Suppress extra build warnings in openssl source > CryptoPkg: Fix possible unresolved external symbol issue. > CryptoPkg/BaseCryptLib: Adding NULL checking in time() wrapper. > CryptoPkg: One workaround to resolve potential build issue. > > CryptoPkg/Include/CrtLibSupport.h | 1 + > CryptoPkg/Include/openssl/e_os2.h | 321 +++++++++++++++++++++ > .../BaseCryptLib/SysCall/ConstantTimeClock.c | 6 +- > CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 +- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 15 +- > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 15 +- > 6 files changed, 355 insertions(+), 13 deletions(-) > create mode 100644 CryptoPkg/Include/openssl/e_os2.h > I can see the upstream OpenSSL pull req / issue report references in TianoCore BZs 455 and 456. series Reviewed-by: Laszlo Ersek Thanks! Laszlo