From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7F8A521B02822 for ; Wed, 28 Nov 2018 09:58:22 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0C03885363; Wed, 28 Nov 2018 17:58:22 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-170.rdu2.redhat.com [10.10.120.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE56768387; Wed, 28 Nov 2018 17:58:12 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: Leif Lindholm , Eric Auger , Andrew Jones , Philippe Mathieu-Daude , Julien Grall References: <20181128143357.991-1-ard.biesheuvel@linaro.org> <20181128143357.991-3-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: <51cf2268-e562-2672-f12a-d63052526c9c@redhat.com> Date: Wed, 28 Nov 2018 18:58:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181128143357.991-3-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 28 Nov 2018 17:58:22 +0000 (UTC) Subject: Re: [PATCH v3 02/16] EmbeddedPkg/PrePiHobLib: drop CreateHobList() from library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 17:58:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/28/18 15:33, Ard Biesheuvel wrote: > Drop the declaration and the implementation of CreateHoblist(), > which is not used anywhere. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > EmbeddedPkg/Include/Library/PrePiLib.h | 18 --------- > EmbeddedPkg/Library/PrePiHobLib/Hob.c | 41 -------------------- > 2 files changed, 59 deletions(-) > > diff --git a/EmbeddedPkg/Include/Library/PrePiLib.h b/EmbeddedPkg/Include/Library/PrePiLib.h > index cf70fca3b619..a857308ecec2 100644 > --- a/EmbeddedPkg/Include/Library/PrePiLib.h > +++ b/EmbeddedPkg/Include/Library/PrePiLib.h > @@ -274,24 +274,6 @@ HobConstructor ( > IN VOID *EfiFreeMemoryTop > ); > > -/** > - Retrieves the magic value from the PE/COFF header. > - > - @param Hdr The buffer in which to return the PE32, PE32+, or TE header. > - > - @return EFI_IMAGE_NT_OPTIONAL_HDR32_MAGIC - Image is PE32 > - @return EFI_IMAGE_NT_OPTIONAL_HDR64_MAGIC - Image is PE32+ > - > -**/ > -VOID > -CreateHobList ( > - IN VOID *MemoryBegin, > - IN UINTN MemoryLength, > - IN VOID *HobBase, > - IN VOID *StackBase > - ); > - > - > /** > This service enables PEIMs to create various types of HOBs. > > diff --git a/EmbeddedPkg/Library/PrePiHobLib/Hob.c b/EmbeddedPkg/Library/PrePiHobLib/Hob.c > index aff8ea05797b..ba16899a9184 100644 > --- a/EmbeddedPkg/Library/PrePiHobLib/Hob.c > +++ b/EmbeddedPkg/Library/PrePiHobLib/Hob.c > @@ -175,47 +175,6 @@ BuildResourceDescriptorHob ( > Hob->ResourceLength = NumberOfBytes; > } > > -/** > - > - > -**/ > -VOID > -CreateHobList ( > - IN VOID *MemoryBegin, > - IN UINTN MemoryLength, > - IN VOID *HobBase, > - IN VOID *StackBase > - ) > -{ > - EFI_HOB_HANDOFF_INFO_TABLE *Hob; > - EFI_RESOURCE_ATTRIBUTE_TYPE Attributes; > - > - Hob = HobConstructor (MemoryBegin,MemoryLength,HobBase,StackBase); > - SetHobList (Hob); > - > - BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize)); > - > - Attributes =( > - EFI_RESOURCE_ATTRIBUTE_PRESENT | > - EFI_RESOURCE_ATTRIBUTE_INITIALIZED | > - EFI_RESOURCE_ATTRIBUTE_TESTED | > - EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE | > - EFI_RESOURCE_ATTRIBUTE_WRITE_COMBINEABLE | > - EFI_RESOURCE_ATTRIBUTE_WRITE_THROUGH_CACHEABLE | > - EFI_RESOURCE_ATTRIBUTE_WRITE_BACK_CACHEABLE > - ); > - > - BuildResourceDescriptorHob (EFI_RESOURCE_SYSTEM_MEMORY, Attributes, (UINTN)MemoryBegin, MemoryLength); > - > - BuildStackHob ((EFI_PHYSICAL_ADDRESS)(UINTN)StackBase, ((UINTN)MemoryBegin + MemoryLength) - (UINTN)StackBase); > - > - if (FeaturePcdGet (PcdPrePiProduceMemoryTypeInformationHob)) { > - // Optional feature that helps prevent EFI memory map fragmentation. > - BuildMemoryTypeInformationHob (); > - } > -} > - > - > VOID > EFIAPI > BuildFvHobs ( > Reviewed-by: Laszlo Ersek