From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6EACA740032 for ; Thu, 23 May 2024 01:04:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=uE5ZzKUKj4JVWS1NPMsiMXe9Tds8IChd1uqx+cFhIFA=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1716426249; v=1; b=pKkp3ghU7f3iTnlcVpUCFXORJVN9cvXdTOCTla7eVsO9DxZA0+smU3TDLo9IjmwNEK+rh/8D doyviLGtOF7loyRaUkSjVSNowh+MOwVw5uLfn3SN6xHCjuJ7Qhe43SACgd0Y8hIn0mB/ZtvoTgZ x9RqTWprgklx4fxjSEYUeNOmvDO0fg9PHceTiVtAJz+WpvNDCm/M2xPy36JYBmqJQldgKDDYzak IL5SotFlY+Az/C5IpNdFRbr+xld6mdViCTS3M2LweAQHPVKXjFOmao0zoc/PSg9TrPL19ru1jjy tz/GzAcS5tXT6/CK6doHuJhPwtKA3Z6gLGmQzFvMRxCJw== X-Received: by 127.0.0.2 with SMTP id gnSKYY7687511x5Am0d8A2Aa; Wed, 22 May 2024 18:04:09 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.6471.1716426243973195591 for ; Wed, 22 May 2024 18:04:04 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.8]) by linux.microsoft.com (Postfix) with ESMTPSA id 403D620B915A; Wed, 22 May 2024 18:04:03 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 403D620B915A Message-ID: <51da0825-bed8-4d7f-8e33-0ad8059776aa@linux.microsoft.com> Date: Wed, 22 May 2024 21:04:02 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] libspdm Breaking Builds To: "Kinney, Michael D" , "devel@edk2.groups.io" , "Yao, Jiewen" References: <82e90314-b068-49ec-b819-d0f9ba9d69e6@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 22 May 2024 18:04:04 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: etsPIfIoC79uS5Prh32se6ONx7686176AA= Content-Language: en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=pKkp3ghU; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io We looked at Stuart and it can prevent a recursive submodule update at=20 the first level but then it would prevent further updates. Here Repo A=20 can prevent a recursive update in edk2 but it would then not be able to=20 get libspdm. [Repo A] -[1]> [edk2] -[2]> [libspdm] -[3]> [cmocka] At its root, the issue is that this is broken, not wasteful. Therefore,=20 it is disruptive and a regression for existing workflows. We, and I'm sure many other projects, recursively clone packages in edk2=20 with submodules. For years, this has been fine except for a few brief=20 exceptions. We pulled the change with the libspdm dependency into our=20 codebase 8 days ago and this has been broken all day. The track record=20 of cryptomilk.org in the past was also very poor and frequently caused=20 problems. There is not an incident response team that I'm aware of at=20 cryptomilk.org that provides status updates and proactively addresses=20 services issues (i.e. https://www.githubstatus.com/). Also, libspdm is now a dependency and cloning cmocka there may fail.=20 Users should expect that they can clone and work in that repo as part of=20 their firmware development process without frequent service disruptions=20 in the way. While I started this thread to raise the issue for users impacted here,=20 I filed https://github.com/DMTF/libspdm/issues/2707 to track the request=20 in the libspdm repo. Thanks, Michael On 5/22/2024 6:24 PM, Kinney, Michael D wrote: > Libspdm also depends on openssl. We did not want to clone openssl twice. >=20 > I though stuart config specifies which submodules to clone. Can=E2=80=99= t we skip > all the submodules within libspdm to fix CI? >=20 > Can't devs choose to not use --recursive? >=20 > Mike >=20 >> -----Original Message----- >> From: Michael Kubacki >> Sent: Wednesday, May 22, 2024 3:16 PM >> To: devel@edk2.groups.io; Kinney, Michael D = ; >> Yao, Jiewen >> Subject: Re: [edk2-devel] libspdm Breaking Builds >> >> I don't think that's a very good solution given the diversity of >> downstream projects dependent on the repo or even for the libspdm repo >> itself. >> >> Thanks, >> Michael >> >> On 5/22/2024 5:57 PM, Michael D Kinney wrote: >>> This was discussed and the decision was made to no use recursive clone = on >> libspdm. >>> >>> Mike >>> >>>> -----Original Message----- >>>> From: Michael Kubacki >>>> Sent: Wednesday, May 22, 2024 1:40 PM >>>> To: devel@edk2.groups.io; Yao, Jiewen >>>> Cc: Kinney, Michael D >>>> Subject: libspdm Breaking Builds >>>> >>>> Recently, the libspdm submodule was added to SecurityPkg >>>> (SecurityPkg/DeviceSecurity/SpdmLib/libspdm) [1]. >>>> >>>> That submodule points to https://github.com/DMTF/libspdm.git. >>>> >>>> The libspdm repo contains a submodule for cmocka that is hosted on >>>> cryptomilk.org [2]. >>>> >>>> Cloning that submodule is failing today, breaking all builds/CI >>>> dependent on SecurityPkg. >>>> >>>> This has been an issue in the past and it is very disruptive given the >>>> number of dependencies on edk2/SecurityPkg. Because of its reliability >>>> issues, edk2 moved to a version of the repo hosted in tianocore [3] in >>>> 2021 [4] >>>> >>>> Can you please make a similar change in libspdm and we get edk2 update= d >>>> as soon as possible? >>>> >>>> Thanks, >>>> Michael >>>> >>>> [1] >>>> >> https://github.com/tianocore/edk2/commit/54a4fd9b35cac79e7c54b750d3dddd0= fbb43 >>>> dca1 >>>> >>>> [2] https://github.com/DMTF/libspdm/blob/main/.gitmodules >>>> >>>> [3] https://github.com/tianocore/edk2-cmocka >>>> >>>> [4] >>>> >> https://github.com/tianocore/edk2/commit/2ad22420a710dc07e3b644f91a5b55c= 09c39 >>>> ecf3 >>> >>> >>>=20 >>> >>> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119122): https://edk2.groups.io/g/devel/message/119122 Mute This Topic: https://groups.io/mt/106250971/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-