public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* MdeModulePkg/UefiBootManagerLib: recursive call of BmRepairAllControllers
@ 2018-02-24  6:23 Guo Heyi
  2018-02-24  8:20 ` Ni, Ruiyu
  0 siblings, 1 reply; 5+ messages in thread
From: Guo Heyi @ 2018-02-24  6:23 UTC (permalink / raw)
  To: edk2-devel; +Cc: Star Zeng, Eric Dong, Ruiyu Ni

Hi folks,

In BmDriverHealth.c, function BmRepairAllControllers may recursively call itself
if some driver health protocol returns EfiDriverHealthStatusReconnectRequired.
However, if there is something wrong in some 3rd party driver (e.g. PCI oprom),
the driver health protocol of that driver may always return such status even
after one and another reconnect. The endless iteration will cause stack overflow
and then system exception, and it may be not easy to find that the exception is
actually caused by stack overflow.

So does it make sense to set a maximum count of this recursive call to avoid
whole system hang even there is a buggy 3rd party driver?

Thanks,

Gary (Heyi Guo)



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-02-24  8:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-24  6:23 MdeModulePkg/UefiBootManagerLib: recursive call of BmRepairAllControllers Guo Heyi
2018-02-24  8:20 ` Ni, Ruiyu
2018-02-24  8:28   ` Guo Heyi
2018-02-24  8:40     ` Ni, Ruiyu
2018-02-24  8:47       ` Guo Heyi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox