public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sai Phanindra Gandikota" <sai.phanindra.gandikota@intel.com>
To: devel@edk2.groups.io
Cc: Gandikota Sai Phanindra
	<102981786+saiphanindrag@users.noreply.github.com>,
	Ray Ni <ray.ni@intel.com>, Liming Gao <gaoliming@byosoft.com.cn>,
	Sai Phanindra Gandikota <sai.phanindra.gandikota@intel.com>
Subject: [edk2-devel] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update switch to highspeed timing flow
Date: Thu, 11 Apr 2024 14:10:16 +0530	[thread overview]
Message-ID: <51e3cf1362f5507026ddf07e8ffff6c7044caf82.1712824811.git.sai.phanindra.gandikota@intel.com> (raw)

From: Gandikota Sai Phanindra <102981786+saiphanindrag@users.noreply.github.com>

Switch to DDR50 speed mode is failing with the existing code flow.
Exiting flow sets Bus width first then bus timing and clock frequency,
with this flow switch to DDR50 speed mode is failing.
After updating the flow to set the bus timing and clock frequency then
bus width resolved the issue and switch to DDR50 is successful.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>

Signed-off-by: Sai Phanindra Gandikota <sai.phanindra.gandikota@intel.com>
---
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
index a392a4e31a..2bca6da3db 100644
--- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
+++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c
@@ -833,12 +833,12 @@ EmmcSwitchToHighSpeed (
     IsDdr = FALSE;
   }
 
-  Status = EmmcSwitchBusWidth (PciIo, PassThru, Slot, Rca, IsDdr, BusMode->BusWidth);
+  Status = EmmcSwitchBusTiming (PciIo, PassThru, Slot, Rca, BusMode->DriverStrength, BusMode->BusTiming, BusMode->ClockFreq);
   if (EFI_ERROR (Status)) {
     return Status;
   }
 
-  return EmmcSwitchBusTiming (PciIo, PassThru, Slot, Rca, BusMode->DriverStrength, BusMode->BusTiming, BusMode->ClockFreq);
+  return EmmcSwitchBusWidth (PciIo, PassThru, Slot, Rca, IsDdr, BusMode->BusWidth);
 }
 
 /**
-- 
2.38.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117626): https://edk2.groups.io/g/devel/message/117626
Mute This Topic: https://groups.io/mt/105458662/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



             reply	other threads:[~2024-04-11  8:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11  8:40 Sai Phanindra Gandikota [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-04-11  8:21 [edk2-devel] [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update switch to highspeed timing flow Sai Phanindra Gandikota
2024-02-06 11:59 Sai Phanindra Gandikota

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51e3cf1362f5507026ddf07e8ffff6c7044caf82.1712824811.git.sai.phanindra.gandikota@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox